From: Sylvain Lemieux <slemieux.tyco@gmail.com>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
robh+dt@kernel.org, mturquette@baylibre.com, stigge@antcom.de,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 1/2] clk: lpc32xx: add clock frequency output configuration
Date: Wed, 10 Feb 2016 12:33:49 -0500 [thread overview]
Message-ID: <1455125629.14667.10.camel@localhost> (raw)
In-Reply-To: <56BA7D89.7060505@mleia.com>
Hi Vladimir
On Wed, 2016-02-10 at 02:00 +0200, Vladimir Zapolskiy wrote:
> Hi Sylvain,
>
> On 09.02.2016 22:07, Sylvain Lemieux wrote:
> > On Tue, 2016-02-09 at 10:57 -0800, Stephen Boyd wrote:
> >> On 02/09, slemieux.tyco@gmail.com wrote:
> >>> From: Sylvain Lemieux <slemieux@tycoint.com>
> >>>
> >>> This patch add the support to setup the clock frequency output
> >>> using an optional parameter from the device tree.
> >>>
> >>> The previous kernel version did not change the clock frequency
> >>> output setup by the kickstart and/or bootloader;
> >>> this version always setup the clock frequency output to 208MHz.
>
> ok, it makes perfect sense, and here I see two options, one is to recover
> the previous behaviour by removing clk_set_rate() of LPC32XX_CLK_HCLK_PLL
> completely, another one (and more preferable) is to add this clock
> to a list in include/dt-bindings/clock/lpc32xx-clock.h and set its
> rate in a board specific DTB file.
I will submit a version 2 of this patch later today using the
second option.
>
> >>> Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> >>> ---
> >>
> >> We have assigned-clock-rates, can you use that instead?
> >>
> > OK, I will submit a new version of the patch tomorrow.
> >
>
> By the way if you have a cover letter or 2/2 patch in the series,
> please send it to linux-clk as well.
The was no cover letter for this series (trivial change).
The patch 2/2 was submitted to the "linux-clk" mailling list
(http://thread.gmane.org/gmane.linux.kernel.clk/3911).
>
> --
> With best wishes,
> Vladimir
Sylvain Lemieux
prev parent reply other threads:[~2016-02-10 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 18:47 [PATCH 1/2] clk: lpc32xx: add clock frequency output configuration slemieux.tyco
2016-02-09 18:57 ` Stephen Boyd
2016-02-09 20:00 ` Sylvain Lemieux
2016-02-09 20:07 ` Sylvain Lemieux
2016-02-10 0:00 ` Vladimir Zapolskiy
2016-02-10 17:33 ` Sylvain Lemieux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455125629.14667.10.camel@localhost \
--to=slemieux.tyco@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=stigge@antcom.de \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).