[PATCH 1/2] dt-bindings: Add LG lp120up1 panel bindings

[PATCH 1/2] dt-bindings: Add LG lp120up1 panel bindings

[Jitao Shi]

Add documentation for lp120up1 panel

Signed-off-by: Jitao Shi <jitao.shi-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
 .../bindings/display/panel/lg,lp120up1.txt         |    7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/lg,lp120up1.txt

diff --git a/Documentation/devicetree/bindings/display/panel/lg,lp120up1.txt b/Documentation/devicetree/bindings/display/panel/lg,lp120up1.txt
new file mode 100644
index 0000000..ff0b6c6
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/lg,lp120up1.txt
@@ -0,0 +1,7 @@
+LG 12.0" (1920x1280 pixels) TFT LCD panel
+
+Required properties:
+- compatible: should be "lg,lp120up1"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] drm/panel: Add support for LG lp120up1 panel

[Jitao Shi]

The LG lp120up1 panel is a 12.0" 1920x1280 panel,
which can be supported by the simple panel driver

Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
---
 drivers/gpu/drm/panel/panel-simple.c |   26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index f88a631..2030c37 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -982,6 +982,29 @@ static const struct panel_desc lg_lb070wv8 = {
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
 };
 
+static const struct drm_display_mode lg_lp120up1_mode = {
+	.clock = 162300,
+	.hdisplay = 1920,
+	.hsync_start = 1920 + 40,
+	.hsync_end = 1920 + 40 + 40,
+	.htotal = 1920 + 40 + 40+ 80,
+	.vdisplay = 1280,
+	.vsync_start = 1280 + 4,
+	.vsync_end = 1280 + 4 + 4,
+	.vtotal = 1280 + 4 + 4 + 12,
+	.vrefresh = 60,
+};
+
+static const struct panel_desc lg_lp120up1 = {
+	.modes = &lg_lp120up1_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 267,
+		.height = 183,
+	},
+};
+
 static const struct drm_display_mode lg_lp129qe_mode = {
 	.clock = 285250,
 	.hdisplay = 2560,
@@ -1256,6 +1279,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "lg,lb070wv8",
 		.data = &lg_lb070wv8,
 	}, {
+		.compatible = "lg,lp120up1",
+		.data = &lg_lp120up1,
+	}, {
 		.compatible = "lg,lp129qe",
 		.data = &lg_lp129qe,
 	}, {
-- 
1.7.9.5

Re: [PATCH 1/2] dt-bindings: Add LG lp120up1 panel bindings

[Rob Herring]

On Wed, Feb 17, 2016 at 02:50:38PM +0800, Jitao Shi wrote:
> Add documentation for lp120up1 panel
> 
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---
>  .../bindings/display/panel/lg,lp120up1.txt         |    7 +++++++
>  1 file changed, 7 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/lg,lp120up1.txt

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH 2/2] drm/panel: Add support for LG lp120up1 panel

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

On Wed, Feb 17, 2016 at 02:50:39PM +0800, Jitao Shi wrote:
> The LG lp120up1 panel is a 12.0" 1920x1280 panel,
> which can be supported by the simple panel driver

It'd be nice to mention the type of interface of the panel here. While
at it, please rewrite the commit message to make use of what width you
have (i.e. any line after the subject can be 72 characters wide).

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 2/2] drm/panel: Add support for LG lp120up1 panel

[Jitao Shi]

On Thu, 2016-02-18 at 16:12 +0100, Thierry Reding wrote:
> On Wed, Feb 17, 2016 at 02:50:39PM +0800, Jitao Shi wrote:
> > The LG lp120up1 panel is a 12.0" 1920x1280 panel,
> > which can be supported by the simple panel driver
> 
> It'd be nice to mention the type of interface of the panel here. While
> at it, please rewrite the commit message to make use of what width you
> have (i.e. any line after the subject can be 72 characters wide).
> 
> Thierry

Thanks for your review.
I'll fix it next patchset.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] dt-bindings: Add LG lp120up1 panel bindings

[Jitao Shi]

On Thu, 2016-02-18 at 08:36 -0600, Rob Herring wrote:
> On Wed, Feb 17, 2016 at 02:50:38PM +0800, Jitao Shi wrote:
> > Add documentation for lp120up1 panel
> > 
> > Signed-off-by: Jitao Shi <jitao.shi-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > ---
> >  .../bindings/display/panel/lg,lp120up1.txt         |    7 +++++++
> >  1 file changed, 7 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/panel/lg,lp120up1.txt
> 
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

Thanks for your "acked"

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html