devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	devicetree@vger.kernel.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org,
	Javier Martinez Canillas <javier@osg.samsung.com>
Subject: [PATCH] Revert "[media] tvp5150: document input connectors DT bindings"
Date: Tue, 23 Feb 2016 15:48:08 -0300	[thread overview]
Message-ID: <1456253288-397-1-git-send-email-javier@osg.samsung.com> (raw)

This reverts commit 82c2ffeb217a ("[media] tvp5150: document input
connectors DT bindings") since the DT binding is too device driver
specific and should instead be more generic and use the bindings
in Documentation/devicetree/bindings/display/connector/ and linked
to the tvp5150 using the OF graph port and endpoints.

There are still ongoing discussions about how the input connectors
will be supported by the Media Controller framework so until that
is settled, it is better to revert the connectors portion of the
bindings to avoid known to be broken bindings docs to hit mainline.

Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 .../devicetree/bindings/media/i2c/tvp5150.txt      | 43 ----------------------
 1 file changed, 43 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/i2c/tvp5150.txt b/Documentation/devicetree/bindings/media/i2c/tvp5150.txt
index daa20e43a8e3..8c0fc1a26bf0 100644
--- a/Documentation/devicetree/bindings/media/i2c/tvp5150.txt
+++ b/Documentation/devicetree/bindings/media/i2c/tvp5150.txt
@@ -12,32 +12,6 @@ Optional Properties:
 - pdn-gpios: phandle for the GPIO connected to the PDN pin, if any.
 - reset-gpios: phandle for the GPIO connected to the RESETB pin, if any.
 
-Optional nodes:
-- connectors: The input connectors of tvp5150 have to be defined under
-  a subnode name "connectors" using the following format:
-
-	input-connector-name {
-		input connector properties
-	};
-
-Each input connector must contain the following properties:
-
-	- label: a name for the connector.
-	- input: the input connector.
-
-The possible values for the "input" property are:
-	0: Composite0
-	1: Composite1
-	2: S-Video
-
-and on a tvp5150am1 and tvp5151 there is another:
-	4: Signal generator
-
-The list of valid input connectors are defined in dt-bindings/media/tvp5150.h
-header file and can be included by device tree source files.
-
-Each input connector can be defined only once.
-
 The device node must contain one 'port' child node for its digital output
 video port, in accordance with the video interface bindings defined in
 Documentation/devicetree/bindings/media/video-interfaces.txt.
@@ -62,23 +36,6 @@ Example:
 		pdn-gpios = <&gpio4 30 GPIO_ACTIVE_LOW>;
 		reset-gpios = <&gpio6 7 GPIO_ACTIVE_LOW>;
 
-		connectors {
-			composite0 {
-				label = "Composite0";
-				input = <TVP5150_COMPOSITE0>;
-			};
-
-			composite1 {
-				label = "Composite1";
-				input = <TVP5150_COMPOSITE1>;
-			};
-
-			s-video {
-				label = "S-Video";
-				input = <TVP5150_SVIDEO>;
-			};
-		};
-
 		port {
 			tvp5150_1: endpoint {
 				remote-endpoint = <&ccdc_ep>;
-- 
2.5.0

             reply	other threads:[~2016-02-23 18:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23 18:48 Javier Martinez Canillas [this message]
2016-02-23 19:11 ` [PATCH] Revert "[media] tvp5150: document input connectors DT bindings" Laurent Pinchart
     [not found] ` <1456253288-397-1-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-02-23 19:50   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456253288-397-1-git-send-email-javier@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).