From: kernel@martin.sperl.org
To: Jonathan Corbet <corbet@lwn.net>,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>, Eric Anholt <eric@anholt.net>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>,
linux-doc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Cc: Martin Sperl <kernel@martin.sperl.org>
Subject: [PATCH 5/8] clk: bcm2835: add the dsi clocks
Date: Mon, 29 Feb 2016 15:43:59 +0000 [thread overview]
Message-ID: <1456760642-2412-6-git-send-email-kernel@martin.sperl.org> (raw)
In-Reply-To: <1456760642-2412-1-git-send-email-kernel@martin.sperl.org>
From: Martin Sperl <kernel@martin.sperl.org>
Add the missing dsi clocks using the currently "best known"
parent-mux available for these clocks.
Signed-off-by: Martin Sperl <kernel@martin.sperl.org>
---
drivers/clk/bcm/clk-bcm2835.c | 88 +++++++++++++++++++++++++++++++++++
include/dt-bindings/clock/bcm2835.h | 4 ++
2 files changed, 92 insertions(+)
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
index aec9b22..91a6086 100644
--- a/drivers/clk/bcm/clk-bcm2835.c
+++ b/drivers/clk/bcm/clk-bcm2835.c
@@ -199,6 +199,8 @@
# define CM_LOCK_FLOCKA BIT(8)
#define CM_EVENT 0x118
+#define CM_DSI0HSCK 0x120
+# define CM_DSI0HSCK_SELPLLD BIT(0)
#define CM_DSI1ECTL 0x158
#define CM_DSI1EDIV 0x15c
#define CM_DSI1PCTL 0x160
@@ -1483,10 +1485,68 @@ static const char * const bcm2835_clock_ccp2_parents[] = {
.parents = bcm2835_clock_ccp2_parents, \
__VA_ARGS__)
+/* dsi0 parent mux */
+static const char * const bcm2835_clock_dsi0_parents[] = {
+ "gnd",
+ "xosc",
+ "testdebug0",
+ "testdebug1",
+ /*
+ * more parent clocks, but unknown at this time
+ * the current definition follows the "common" pattern
+ * that already applies to all the other parent mux
+ * in so far as all the known mux contain gnd, xosc, testdebug0/1
+ * as the first 3 entries.
+ * The mux should contain "plla_dsi0/plld_dsi0" at one position.
+ * the selection which pll is used depends on CM_DSI0HSCK_SELPLLD
+ * here some possible candidates for the next parents in the list.
+ * plla_core/per or plla_dsi0/plld_dsi0
+ * pllc_core/per
+ * plld_core/per
+ * pllh_aux/pix
+ * maybe plla_dsi0/plld_dsi0 (depends on CM_DSI0HSCK_SELPLLD)
+ * up to 16 different parents
+ */
+};
+
+#define REGISTER_DSI0_CLK(...) REGISTER_CLK( \
+ .num_mux_parents = ARRAY_SIZE(bcm2835_clock_dsi0_parents), \
+ .parents = bcm2835_clock_dsi0_parents, \
+ __VA_ARGS__)
+
+/* dsi1 parent mux */
+static const char * const bcm2835_clock_dsi1_parents[] = {
+ "gnd",
+ "xosc",
+ "testdebug0",
+ "testdebug1",
+ /*
+ * more parent clocks, but unknown at this time
+ * the current definition follows the "common" pattern
+ * that already applies to all the other parent mux
+ * in so far as all the known mux contain gnd, xosc, testdebug0/1
+ * as the first 3 entries.
+ * The mux should contain "plld_dsi1" at one position.
+ * here some possible candidates for the next parents in the list.
+ * plla_core/per
+ * pllc_core/per
+ * plld_core/per or plld_dsi1
+ * pllh_aux/pix
+ * maybe plld_dsi1
+ * up to 16 different parents
+ */
+};
+
+#define REGISTER_DSI1_CLK(...) REGISTER_CLK( \
+ .num_mux_parents = ARRAY_SIZE(bcm2835_clock_dsi1_parents), \
+ .parents = bcm2835_clock_dsi1_parents, \
+ __VA_ARGS__)
+
/*
* the real definition of all the pll, pll_dividers and clocks
* these make use of the above REGISTER_* macros
*/
+
static const struct bcm2835_clk_desc clk_desc_array[] = {
/* the PLL + PLL dividers */
@@ -1950,6 +2010,34 @@ static const struct bcm2835_clk_desc clk_desc_array[] = {
.int_bits = 1,
.frac_bits = 0),
+ /* dsi clocks */
+ [BCM2835_CLOCK_DSI0E] = REGISTER_DSI0_CLK(
+ .name = "dsi0e",
+ .ctl_reg = CM_DSI0ECTL,
+ .div_reg = CM_DSI0EDIV,
+ .int_bits = 4,
+ .frac_bits = 8),
+ [BCM2835_CLOCK_DSI0_IMAGE] = REGISTER_DSI0_CLK(
+ /* this is in principle a gate with a 4 bit mux */
+ .name = "dsi0_image",
+ .ctl_reg = CM_DSI0PCTL,
+ .div_reg = CM_DSI0PDIV,
+ .int_bits = 1,
+ .frac_bits = 0),
+ [BCM2835_CLOCK_DSI1E] = REGISTER_DSI1_CLK(
+ .name = "dsi1e",
+ .ctl_reg = CM_DSI1ECTL,
+ .div_reg = CM_DSI1EDIV,
+ .int_bits = 4,
+ .frac_bits = 8),
+ [BCM2835_CLOCK_DSI1_IMAGE] = REGISTER_DSI1_CLK(
+ /* this is in principle a gate with a 4 bit mux */
+ .name = "dsi1_image",
+ .ctl_reg = CM_DSI1PCTL,
+ .div_reg = CM_DSI1PDIV,
+ .int_bits = 1,
+ .frac_bits = 0),
+
/* the gates */
/*
diff --git a/include/dt-bindings/clock/bcm2835.h b/include/dt-bindings/clock/bcm2835.h
index 1d70088..9254c78 100644
--- a/include/dt-bindings/clock/bcm2835.h
+++ b/include/dt-bindings/clock/bcm2835.h
@@ -66,3 +66,7 @@
#define BCM2835_CLOCK_CAM0 48
#define BCM2835_CLOCK_CAM1 49
#define BCM2835_CLOCK_CCP2 50
+#define BCM2835_CLOCK_DSI0E 51
+#define BCM2835_CLOCK_DSI0_IMAGE 52
+#define BCM2835_CLOCK_DSI1E 53
+#define BCM2835_CLOCK_DSI1_IMAGE 54
--
1.7.10.4
next prev parent reply other threads:[~2016-02-29 15:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 15:43 [PATCH 0/8] clk: bcm2835: add most missing clocks of bcm2835 kernel
2016-02-29 15:43 ` [PATCH 1/8] clk: bcm2835: documenentation: add graphiz bcm2835 clock tree kernel
2016-02-29 15:43 ` [PATCH 2/8] clk: bcm2835: add missing PLL clock divider kernel
2016-03-17 16:57 ` Eric Anholt
2016-03-17 17:38 ` Martin Sperl
2016-03-17 17:58 ` Eric Anholt
2016-02-29 15:43 ` [PATCH 3/8] clk: bcm2835: add missing osc and per clocks kernel
2016-03-17 17:10 ` Eric Anholt
2016-03-17 17:19 ` Eric Anholt
2016-02-29 15:43 ` [PATCH 4/8] clk: bcm2835: add the camera related clocks cam0, cam1 and ccp2 kernel
2016-02-29 15:43 ` kernel [this message]
2016-03-17 17:27 ` [PATCH 5/8] clk: bcm2835: add the dsi clocks Eric Anholt
2016-02-29 15:44 ` [PATCH 6/8] clk: bcm2835: add arm clock kernel
[not found] ` <1456760642-2412-1-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2016-02-29 15:44 ` [PATCH 7/8] clk: bcm2835: add gates that require PM_DEBUG to be set kernel-TqfNSX0MhmxHKSADF0wUEw
2016-02-29 15:44 ` [PATCH 8/8] clk: bcm2835: add the testdebug clock generators kernel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456760642-2412-6-git-send-email-kernel@martin.sperl.org \
--to=kernel@martin.sperl.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).