[PATCH 0/3] Enable Ethernet on STM32F429 EVAL board

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 0/3] Enable Ethernet on STM32F429 EVAL board
@ 2016-02-29 16:29 Alexandre TORGUE
  2016-02-29 16:29 ` [PATCH 1/3] ARM: dts: stm32f429: Add system config bank node Alexandre TORGUE
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Alexandre TORGUE @ 2016-02-29 16:29 UTC (permalink / raw)
  To: Arnd Bergmann, olof, khilman, linux-arm-kernel,
	Giuseppe Cavallaro
  Cc: devicetree, linux-kernel, Daniel Thompson, Kamil Lulko, afaerber,
	netdev

This series adds Ethernet support on STM32F429 SOC and enable it on Eval
board:
 -Add Ethernet node in SOC file:
  -Define MII mode pinctrl
  -use Mixed burst and PBL 8
 -Add system config node for glue.
 -Enable Ethernet for Eval board:
  -mii mode
  -connected to a PHY through MDIO.

Note, this series follow the series which adds glue and update stmmac driver:

https://lkml.org/lkml/2016/2/26/329

Best regards.

Alex

Alexandre TORGUE (3):
  ARM: dts: stm32f429: Add system config bank node
  ARM: dts: stm32f429: Add Ethernet support
  ARM: dts: stm32f429: Enable Ethernet on Eval board

 arch/arm/boot/dts/stm32429i-eval.dts | 15 ++++++++++++++
 arch/arm/boot/dts/stm32f429.dtsi     | 40 ++++++++++++++++++++++++++++++++++++
 2 files changed, 55 insertions(+)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/3] ARM: dts: stm32f429: Add system config bank node
  2016-02-29 16:29 [PATCH 0/3] Enable Ethernet on STM32F429 EVAL board Alexandre TORGUE
@ 2016-02-29 16:29 ` Alexandre TORGUE
  2016-02-29 16:29 ` [PATCH 2/3] ARM: dts: stm32f429: Add Ethernet support Alexandre TORGUE
  2016-02-29 16:29 ` [PATCH 3/3] ARM: dts: stm32f429: Enable Ethernet on Eval board Alexandre TORGUE
  2 siblings, 0 replies; 6+ messages in thread
From: Alexandre TORGUE @ 2016-02-29 16:29 UTC (permalink / raw)
  To: Arnd Bergmann, olof, khilman, linux-arm-kernel,
	Giuseppe Cavallaro
  Cc: devicetree, linux-kernel, Daniel Thompson, Kamil Lulko, afaerber,
	netdev

Signed-off-by: Alexandre TORGUE <alexandre.torgue@gmail.com>

diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
index 598362e..bb7a736 100644
--- a/arch/arm/boot/dts/stm32f429.dtsi
+++ b/arch/arm/boot/dts/stm32f429.dtsi
@@ -171,6 +171,11 @@
 			status = "disabled";
 		};
 
+		syscfg: system-config@40013800 {
+			compatible = "syscon";
+			reg = <0x40013800 0x400>;
+		};
+
 		pin-controller {
 			#address-cells = <1>;
 			#size-cells = <1>;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/3] ARM: dts: stm32f429: Add Ethernet support
  2016-02-29 16:29 [PATCH 0/3] Enable Ethernet on STM32F429 EVAL board Alexandre TORGUE
  2016-02-29 16:29 ` [PATCH 1/3] ARM: dts: stm32f429: Add system config bank node Alexandre TORGUE
@ 2016-02-29 16:29 ` Alexandre TORGUE
       [not found]   ` <1456763376-21457-3-git-send-email-alexandre.torgue-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  2016-02-29 16:29 ` [PATCH 3/3] ARM: dts: stm32f429: Enable Ethernet on Eval board Alexandre TORGUE
  2 siblings, 1 reply; 6+ messages in thread
From: Alexandre TORGUE @ 2016-02-29 16:29 UTC (permalink / raw)
  To: Arnd Bergmann, olof, khilman, linux-arm-kernel,
	Giuseppe Cavallaro
  Cc: devicetree, linux-kernel, Daniel Thompson, Kamil Lulko, afaerber,
	netdev

Add Ethernet support (Synopsys MAC IP 3.50a) on stm32f429 SOC.

Signed-off-by: Alexandre TORGUE <alexandre.torgue@gmail.com>

diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
index bb7a736..af0367c 100644
--- a/arch/arm/boot/dts/stm32f429.dtsi
+++ b/arch/arm/boot/dts/stm32f429.dtsi
@@ -283,6 +283,26 @@
 					bias-disable;
 				};
 			};
+
+			ethernet0_mii: mii@0 {
+				mii {
+					slew-rate = <2>;
+					pinmux = <STM32F429_PG13_FUNC_ETH_MII_TXD0_ETH_RMII_TXD0>,
+						 <STM32F429_PG14_FUNC_ETH_MII_TXD1_ETH_RMII_TXD1>,
+						 <STM32F429_PC2_FUNC_ETH_MII_TXD2>,
+						 <STM32F429_PB8_FUNC_ETH_MII_TXD3>,
+						 <STM32F429_PC3_FUNC_ETH_MII_TX_CLK>,
+						 <STM32F429_PG11_FUNC_ETH_MII_TX_EN_ETH_RMII_TX_EN>,
+						 <STM32F429_PA2_FUNC_ETH_MDIO>,
+						 <STM32F429_PC1_FUNC_ETH_MDC>,
+						 <STM32F429_PA1_FUNC_ETH_MII_RX_CLK_ETH_RMII_REF_CLK>,
+						 <STM32F429_PA7_FUNC_ETH_MII_RX_DV_ETH_RMII_CRS_DV>,
+						 <STM32F429_PC4_FUNC_ETH_MII_RXD0_ETH_RMII_RXD0>,
+						 <STM32F429_PC5_FUNC_ETH_MII_RXD1_ETH_RMII_RXD1>,
+						 <STM32F429_PH6_FUNC_ETH_MII_RXD2>,
+						 <STM32F429_PH7_FUNC_ETH_MII_RXD3>;
+				};
+			};
 		};
 
 		rcc: rcc@40023810 {
@@ -323,6 +343,21 @@
 			st,mem2mem;
 		};
 
+		ethernet0: dwmac@40028000 {
+			compatible = "st,stm32-dwmac", "snps,dwmac-3.50a";
+			status = "disabled";
+			reg = <0x40028000 0x8000>;
+			reg-names = "stmmaceth";
+			interrupts = <0 61 0>, <0 62 0>;
+			interrupt-names = "macirq", "eth_wake_irq";
+			clock-names = "stmmaceth", "tx-clk", "rx-clk";
+			clocks = <&rcc 0 25>, <&rcc 0 26>, <&rcc 0 27>;
+			st,syscon = <&syscfg 0x4>;
+			snps,pbl = <8>;
+			snps,mixed-burst;
+			dma-ranges;
+		};
+
 		rng: rng@50060800 {
 			compatible = "st,stm32-rng";
 			reg = <0x50060800 0x400>;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

[parent not found: <1456763376-21457-3-git-send-email-alexandre.torgue-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

* Re: [PATCH 2/3] ARM: dts: stm32f429: Add Ethernet support
       [not found]   ` <1456763376-21457-3-git-send-email-alexandre.torgue-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2016-03-01 17:24     ` Maxime Coquelin
  2016-03-02  8:23       ` Alexandre Torgue
  0 siblings, 1 reply; 6+ messages in thread
From: Maxime Coquelin @ 2016-03-01 17:24 UTC (permalink / raw)
  To: Alexandre TORGUE, Arnd Bergmann, olof-nZhT3qVonbNeoWH0uzbU5w,
	khilman-DgEjT+Ai2ygdnm+yROfE0A,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Giuseppe Cavallaro
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Daniel Thompson,
	netdev-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Kamil Lulko,
	afaerber-l3A5Bk7waGM

Hi Alex,

     I have made a handful of changes on your patch, let me know if this 
is ok for you.
     If ok, it will be part of the PR I'll send tomorrow.

On 02/29/2016 05:29 PM, Alexandre TORGUE wrote:
> Add Ethernet support (Synopsys MAC IP 3.50a) on stm32f429 SOC.
>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
> index bb7a736..af0367c 100644
> --- a/arch/arm/boot/dts/stm32f429.dtsi
> +++ b/arch/arm/boot/dts/stm32f429.dtsi
> @@ -283,6 +283,26 @@
>   					bias-disable;
>   				};
>   			};
> +
> +			ethernet0_mii: mii@0 {
> +				mii {
> +					slew-rate = <2>;
I moved slew-rate property below the pinmux one for consistency with 
other pin configs in the file.
> +					pinmux = <STM32F429_PG13_FUNC_ETH_MII_TXD0_ETH_RMII_TXD0>,
> +						 <STM32F429_PG14_FUNC_ETH_MII_TXD1_ETH_RMII_TXD1>,
> +						 <STM32F429_PC2_FUNC_ETH_MII_TXD2>,
> +						 <STM32F429_PB8_FUNC_ETH_MII_TXD3>,
> +						 <STM32F429_PC3_FUNC_ETH_MII_TX_CLK>,
> +						 <STM32F429_PG11_FUNC_ETH_MII_TX_EN_ETH_RMII_TX_EN>,
> +						 <STM32F429_PA2_FUNC_ETH_MDIO>,
> +						 <STM32F429_PC1_FUNC_ETH_MDC>,
> +						 <STM32F429_PA1_FUNC_ETH_MII_RX_CLK_ETH_RMII_REF_CLK>,
> +						 <STM32F429_PA7_FUNC_ETH_MII_RX_DV_ETH_RMII_CRS_DV>,
> +						 <STM32F429_PC4_FUNC_ETH_MII_RXD0_ETH_RMII_RXD0>,
> +						 <STM32F429_PC5_FUNC_ETH_MII_RXD1_ETH_RMII_RXD1>,
> +						 <STM32F429_PH6_FUNC_ETH_MII_RXD2>,
> +						 <STM32F429_PH7_FUNC_ETH_MII_RXD3>;
> +				};
> +			};
>   		};
>   
>   		rcc: rcc@40023810 {
> @@ -323,6 +343,21 @@
>   			st,mem2mem;
>   		};
>   
> +		ethernet0: dwmac@40028000 {
> +			compatible = "st,stm32-dwmac", "snps,dwmac-3.50a";
> +			status = "disabled";
I moved status property at the end of the node for consistency
> +			reg = <0x40028000 0x8000>;
> +			reg-names = "stmmaceth";
> +			interrupts = <0 61 0>, <0 62 0>;
#interrupt-cells is set to 1 in the nvic node, meaning that a single 
cell is expected here:

interrupts = <61>, <62>;

> +			interrupt-names = "macirq", "eth_wake_irq";
> +			clock-names = "stmmaceth", "tx-clk", "rx-clk";
> +			clocks = <&rcc 0 25>, <&rcc 0 26>, <&rcc 0 27>;
> +			st,syscon = <&syscfg 0x4>;
> +			snps,pbl = <8>;
> +			snps,mixed-burst;
> +			dma-ranges;
> +		};
> +
>   		rng: rng@50060800 {
>   			compatible = "st,stm32-rng";
>   			reg = <0x50060800 0x400>;

Regards,
Maxime


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/3] ARM: dts: stm32f429: Add Ethernet support
  2016-03-01 17:24     ` Maxime Coquelin
@ 2016-03-02  8:23       ` Alexandre Torgue
  0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Torgue @ 2016-03-02  8:23 UTC (permalink / raw)
  To: Maxime Coquelin
  Cc: Arnd Bergmann, olof, khilman, linux-arm-kernel,
	Giuseppe Cavallaro, devicetree, Daniel Thompson, netdev,
	linux-kernel, Kamil Lulko, Andreas Färber

Hi Maxime,

2016-03-01 18:24 GMT+01:00 Maxime Coquelin <mcoquelin.stm32@gmail.com>:
> Hi Alex,
>
>     I have made a handful of changes on your patch, let me know if this is
> ok for you.
>     If ok, it will be part of the PR I'll send tomorrow.

I agree with modifications.

Regards

alex

>
> On 02/29/2016 05:29 PM, Alexandre TORGUE wrote:
>>
>> Add Ethernet support (Synopsys MAC IP 3.50a) on stm32f429 SOC.
>>
>> Signed-off-by: Alexandre TORGUE <alexandre.torgue@gmail.com>
>>
>> diff --git a/arch/arm/boot/dts/stm32f429.dtsi
>> b/arch/arm/boot/dts/stm32f429.dtsi
>> index bb7a736..af0367c 100644
>> --- a/arch/arm/boot/dts/stm32f429.dtsi
>> +++ b/arch/arm/boot/dts/stm32f429.dtsi
>> @@ -283,6 +283,26 @@
>>                                         bias-disable;
>>                                 };
>>                         };
>> +
>> +                       ethernet0_mii: mii@0 {
>> +                               mii {
>> +                                       slew-rate = <2>;
>
> I moved slew-rate property below the pinmux one for consistency with other
> pin configs in the file.
>>
>> +                                       pinmux =
>> <STM32F429_PG13_FUNC_ETH_MII_TXD0_ETH_RMII_TXD0>,
>> +
>> <STM32F429_PG14_FUNC_ETH_MII_TXD1_ETH_RMII_TXD1>,
>> +
>> <STM32F429_PC2_FUNC_ETH_MII_TXD2>,
>> +
>> <STM32F429_PB8_FUNC_ETH_MII_TXD3>,
>> +
>> <STM32F429_PC3_FUNC_ETH_MII_TX_CLK>,
>> +
>> <STM32F429_PG11_FUNC_ETH_MII_TX_EN_ETH_RMII_TX_EN>,
>> +
>> <STM32F429_PA2_FUNC_ETH_MDIO>,
>> +
>> <STM32F429_PC1_FUNC_ETH_MDC>,
>> +
>> <STM32F429_PA1_FUNC_ETH_MII_RX_CLK_ETH_RMII_REF_CLK>,
>> +
>> <STM32F429_PA7_FUNC_ETH_MII_RX_DV_ETH_RMII_CRS_DV>,
>> +
>> <STM32F429_PC4_FUNC_ETH_MII_RXD0_ETH_RMII_RXD0>,
>> +
>> <STM32F429_PC5_FUNC_ETH_MII_RXD1_ETH_RMII_RXD1>,
>> +
>> <STM32F429_PH6_FUNC_ETH_MII_RXD2>,
>> +
>> <STM32F429_PH7_FUNC_ETH_MII_RXD3>;
>> +                               };
>> +                       };
>>                 };
>>                 rcc: rcc@40023810 {
>> @@ -323,6 +343,21 @@
>>                         st,mem2mem;
>>                 };
>>   +             ethernet0: dwmac@40028000 {
>> +                       compatible = "st,stm32-dwmac", "snps,dwmac-3.50a";
>> +                       status = "disabled";
>
> I moved status property at the end of the node for consistency
>>
>> +                       reg = <0x40028000 0x8000>;
>> +                       reg-names = "stmmaceth";
>> +                       interrupts = <0 61 0>, <0 62 0>;
>
> #interrupt-cells is set to 1 in the nvic node, meaning that a single cell is
> expected here:
>
> interrupts = <61>, <62>;
>
>> +                       interrupt-names = "macirq", "eth_wake_irq";
>> +                       clock-names = "stmmaceth", "tx-clk", "rx-clk";
>> +                       clocks = <&rcc 0 25>, <&rcc 0 26>, <&rcc 0 27>;
>> +                       st,syscon = <&syscfg 0x4>;
>> +                       snps,pbl = <8>;
>> +                       snps,mixed-burst;
>> +                       dma-ranges;
>> +               };
>> +
>>                 rng: rng@50060800 {
>>                         compatible = "st,stm32-rng";
>>                         reg = <0x50060800 0x400>;
>
>
> Regards,
> Maxime
>
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 3/3] ARM: dts: stm32f429: Enable Ethernet on Eval board
  2016-02-29 16:29 [PATCH 0/3] Enable Ethernet on STM32F429 EVAL board Alexandre TORGUE
  2016-02-29 16:29 ` [PATCH 1/3] ARM: dts: stm32f429: Add system config bank node Alexandre TORGUE
  2016-02-29 16:29 ` [PATCH 2/3] ARM: dts: stm32f429: Add Ethernet support Alexandre TORGUE
@ 2016-02-29 16:29 ` Alexandre TORGUE
  2 siblings, 0 replies; 6+ messages in thread
From: Alexandre TORGUE @ 2016-02-29 16:29 UTC (permalink / raw)
  To: Arnd Bergmann, olof, khilman, linux-arm-kernel,
	Giuseppe Cavallaro
  Cc: devicetree, Daniel Thompson, netdev, linux-kernel, Kamil Lulko,
	afaerber

MAC is connected to a PHY in MII mode.

Signed-off-by: Alexandre TORGUE <alexandre.torgue@gmail.com>

diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts
index 1ae57fa..e345459 100644
--- a/arch/arm/boot/dts/stm32429i-eval.dts
+++ b/arch/arm/boot/dts/stm32429i-eval.dts
@@ -87,6 +87,21 @@
 	clock-frequency = <25000000>;
 };
 
+&ethernet0 {
+	status = "okay";
+	pinctrl-0	= <&ethernet0_mii>;
+	pinctrl-names	= "default";
+	phy-mode	= "mii-id";
+	mdio0 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "snps,dwmac-mdio";
+			phy1: ethernet-phy@1 {
+				reg = <1>;
+			};
+		};
+};
+
 &usart1 {
 	pinctrl-0 = <&usart1_pins_a>;
 	pinctrl-names = "default";
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-03-02  8:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-29 16:29 [PATCH 0/3] Enable Ethernet on STM32F429 EVAL board Alexandre TORGUE
2016-02-29 16:29 ` [PATCH 1/3] ARM: dts: stm32f429: Add system config bank node Alexandre TORGUE
2016-02-29 16:29 ` [PATCH 2/3] ARM: dts: stm32f429: Add Ethernet support Alexandre TORGUE
     [not found]   ` <1456763376-21457-3-git-send-email-alexandre.torgue-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-01 17:24     ` Maxime Coquelin
2016-03-02  8:23       ` Alexandre Torgue
2016-02-29 16:29 ` [PATCH 3/3] ARM: dts: stm32f429: Enable Ethernet on Eval board Alexandre TORGUE

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).