From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Ianovich Subject: Re: [PATCH v7] serial: support for 16550A serial ports on LP-8x4x Date: Tue, 01 Mar 2016 20:14:32 +0300 Message-ID: <1456852472.23036.124.camel@gmail.com> References: <1456589675-25377-1-git-send-email-ynvich@gmail.com> <1456781209-11390-1-git-send-email-ynvich@gmail.com> <1456830401.13244.189.camel@linux.intel.com> <1456849504.23036.108.camel@gmail.com> <1456850782.13244.208.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1456850782.13244.208.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andy Shevchenko , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Alan Cox , Arnd Bergmann , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Greg Kroah-Hartman , Jiri Slaby , Heikki Krogerus , Peter Hurley , Masahiro Yamada , Paul Burton , Mans Rullgard , Joachim Eastwood , Scott Wood , Paul Gortmaker , Peter Ujfalusi , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:SERIAL DRIVERS" List-Id: devicetree@vger.kernel.org On Tue, 2016-03-01 at 18:46 +0200, Andy Shevchenko wrote: > On Tue, 2016-03-01 at 19:25 +0300, Sergei Ianovich wrote: > > On Tue, 2016-03-01 at 13:06 +0200, Andy Shevchenko wrote: > > > On Tue, 2016-03-01 at 00:26 +0300, Sergei Ianovich wrote: >=20 > > > > + len &=3D 3; >=20 > Mask as well to be defined. Sure. > So, but if you support only fixed rates, why do you care about BOTHER > at all? If BOTHER is defined,=C2=A0tty_termios_baud_rate() and=C2=A0tty_termios_encode_baud_rate() allow non-standard baud rates. = I should clear it from=C2=A0c_cflag to indicate I don't support it. > > > > =C2=A0 > > > I think you can call this unconditionally together with case > > > > 115200. > >=20 > > The calls are orthogonal. This one deals with the case when BOTHER > > is > > defined and set, and we have non-zero rate with BOTHER, but we have > > zero rate after BOTHER is cleared. So we set 9600 as a sane default > > speed. > >=20 > > This one deals with the case when the rate is over 115200. If the > > previous case has been triggered, this one won't be. >=20 > Yeah, but I meant to unconditionally call it just once here every > time. I see. It saves a few lines. > > --- > > drivers/tty/serial/8250/8250_lp8841.c: In function > > 'lp8841_serial_probe': > > drivers/tty/serial/8250/8250_lp8841.c:124:32: warning: excess > > elements in struct initializer > > =C2=A0 struct uart_8250_port uart =3D {0}; > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0^ > > drivers/tty/serial/8250/8250_lp8841.c:124:32: note: (near > > initialization for 'uart.port.lock..rlock.raw_lock') >=20 > Do you have any warning verbosity enabled? I see a lot of stuff like > this in the code Plain `make`. The warning seems to be the result of initializing a spinlock with zero. Spinlocks are intentionally obfuscated, but I didn't investigate further. > $ git grep -n 'struct .* =3D {0};' | wc -l > 338 >=20 > $ git grep -n 'struct .* =3D { \?0 \?};' | wc -l > 550 >=20 > ( '=E2=80=A6 =3D { 0 };' included) The first structure member is most likely not a spinlock in those cases. > > --- > >=20 > > Zero triggers a warning. I'll use memset(). >=20 > Either will work. OK The only remaining open point is BOTHER handling. -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html