devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: linux-rockchip@lists.infradead.org
Cc: "Heiko Stuebner" <heiko@sntech.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, "Andreas Färber" <afaerber@suse.de>,
	"Julien Chauveau" <chauveau.julien@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Will Deacon" <will.deacon@arm.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>
Subject: [PATCH v4 5/8] arm64: dts: rockchip: Clean up gpio-keys nodes
Date: Wed, 16 Mar 2016 14:58:43 +0100	[thread overview]
Message-ID: <1458136727-32075-6-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1458136727-32075-1-git-send-email-afaerber@suse.de>

Drop superfluous #address-cells and #size-cells.
Use KEY_POWER define for 116.
Rename sub-nodes to avoid new dtc warnings.

Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
Cc: Julien Chauveau <chauveau.julien@gmail.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v3 -> v4:
 * Renamed sub-node names (Julien)
 
 v3: New (Julien)
 
 arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi | 7 +++----
 arch/arm64/boot/dts/rockchip/rk3368-r88.dts  | 7 +++----
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi b/arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi
index e4c91e86e9b6..bd4f2cf326b2 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi
@@ -40,6 +40,7 @@
  *     OTHER DEALINGS IN THE SOFTWARE.
  */
 
+#include <dt-bindings/input/input.h>
 #include <dt-bindings/pwm/pwm.h>
 #include "rk3368.dtsi"
 
@@ -105,16 +106,14 @@
 
 	keys: gpio-keys {
 		compatible = "gpio-keys";
-		#address-cells = <1>;
-		#size-cells = <0>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pwr_key>;
 
-		button@0 {
+		power {
 			wakeup-source;
 			gpios = <&gpio0 2 GPIO_ACTIVE_LOW>;
 			label = "GPIO Power";
-			linux,code = <116>;
+			linux,code = <KEY_POWER>;
 		};
 	};
 
diff --git a/arch/arm64/boot/dts/rockchip/rk3368-r88.dts b/arch/arm64/boot/dts/rockchip/rk3368-r88.dts
index 5c63f8982128..5ea68c493400 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368-r88.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3368-r88.dts
@@ -42,6 +42,7 @@
 
 /dts-v1/;
 #include "rk3368.dtsi"
+#include <dt-bindings/input/input.h>
 
 / {
 	model = "Rockchip R88";
@@ -65,16 +66,14 @@
 
 	keys: gpio-keys {
 		compatible = "gpio-keys";
-		#address-cells = <1>;
-		#size-cells = <0>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pwr_key>;
 
-		button@0 {
+		power {
 			wakeup-source;
 			gpios = <&gpio0 2 GPIO_ACTIVE_LOW>;
 			label = "GPIO Power";
-			linux,code = <116>;
+			linux,code = <KEY_POWER>;
 		};
 	};
 
-- 
2.6.2

  parent reply	other threads:[~2016-03-16 13:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 13:58 [PATCH v4 0/8] arm64: rockchip: Initial GeekBox enablement Andreas Färber
2016-03-16 13:58 ` [PATCH v4 1/8] arm64: dts: rockchip: Clean up /memory nodes Andreas Färber
     [not found]   ` <1458136727-32075-2-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-03-19  8:04     ` Heiko Stuebner
2016-03-31 17:15       ` Heiko Stuebner
2016-03-31 20:45         ` Heiko Stuebner
2016-04-12  5:24           ` Heiko Stuebner
2016-03-16 13:58 ` [PATCH v4 4/8] arm64: dts: rockchip: Add GeekBox config Andreas Färber
     [not found]   ` <1458136727-32075-5-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-03-29 19:50     ` Heiko Stübner
2016-03-16 13:58 ` Andreas Färber [this message]
     [not found]   ` <1458136727-32075-6-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-03-16 21:55     ` [PATCH v4 5/8] arm64: dts: rockchip: Clean up gpio-keys nodes Julien Chauveau
2016-03-28 20:24     ` Heiko Stübner
2016-03-28 20:25       ` Heiko Stübner
2016-03-16 13:58 ` [PATCH v4 6/8] arm64: dts: rockchip: Add power key to GeekBox Andreas Färber
2016-03-16 21:55   ` Julien Chauveau
     [not found]   ` <1458136727-32075-7-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-03-29 20:14     ` Heiko Stübner
     [not found] ` <1458136727-32075-1-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-03-16 13:58   ` [PATCH v4 2/8] Documentation: devicetree: Add vendor prefix for GeekBuying.com Andreas Färber
     [not found]     ` <1458136727-32075-3-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-03-28 20:24       ` Heiko Stübner
2016-03-16 13:58   ` [PATCH v4 3/8] Documentation: devicetree: rockchip: Document GeekBox Andreas Färber
2016-03-29 20:13     ` Heiko Stübner
2016-03-29 20:45       ` Andreas Färber
2016-03-29 21:21         ` Heiko Stübner
2016-03-31 17:02           ` Heiko Stuebner
2016-03-16 13:58   ` [PATCH v4 7/8] Documentation: devicetree: rockchip: Document Landingship Andreas Färber
     [not found]     ` <1458136727-32075-8-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-03-18 21:30       ` Rob Herring
2016-03-18 21:37         ` Andreas Färber
2016-03-16 13:58   ` [PATCH v4 8/8] arm64: dts: rockchip: Add Landingship config Andreas Färber
2016-03-29 20:18     ` Heiko Stübner
2016-03-29 22:18       ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458136727-32075-6-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=catalin.marinas@arm.com \
    --cc=chauveau.julien@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=heiko@sntech.de \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).