From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFFF41A3AA8 for ; Wed, 20 Nov 2024 12:38:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732106310; cv=none; b=F0FX+NB+nqIQEzptGUyiGZIExuFgrwa/q+U6VFPh05rynPenSLWdZ0eqx06xk0myAFmPCJ3b6RKSv/lPd0ueyVTyluiQRzHDzQooxtD3TUIuNDrl1nLHYDRs9WM8E0r1z7b1dpI/BCpjzhI2trOZ3TmARjrSmu4MdLDsl5/LfUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732106310; c=relaxed/simple; bh=T1SHhS5gSBi3f2Ap4tHWCiN3xBm5XNZaeGss3DVKBDY=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=VdcQmm0ct55BgLPcLqkYB+uuc1KOi05dEAi03Ju5QChcA7Q6v/uYIguKpIIyDI3sxy1KlaJ9+7XQxJ10D0UkvHkOdkhMtpFm/vtt4IR8sP5j3v0/QGG1dsax8iWggjH58dslAmjYWgEfnIExLLxeOCLvrkIzknKNsF3jAYHp6tI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eqs2hFtD; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eqs2hFtD" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-53d9ff8f1e4so5149142e87.2 for ; Wed, 20 Nov 2024 04:38:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732106307; x=1732711107; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=LcUEOpFKPbKPpXUIzJ5sVKWN691GW1SaJnZt3c54KG0=; b=eqs2hFtD1NXa08JLrxuTdUnrV19/JgL7RLd96Azc9bHuuKn00lPDwiOUr+d3zPRHlk d2c+k65DszUP2tm5/YQ5WoRaoJQsOQZ6/A1cWm71W+8Ol3ohkqOe9Drl24jGppiKuR+I k6iDR+aX9pSIQT3Gs9UIZrERNoch8n5BfUnH3O02VTdnnzOW7YK+UYE4V9sr2IdzuGOY u48hPqX3ZJTKwVc3J+9TUMIOH6Skq8m/STDM9GmiEuRoKmPUGtEczVspimFfHp7atnUh 4Y/A/RMFlkwHAwMSBOCXhe0G23+wKNmFjZCLX96GUHrw7zawVPmocNi/osqTg8j1M2Gn EKBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732106307; x=1732711107; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LcUEOpFKPbKPpXUIzJ5sVKWN691GW1SaJnZt3c54KG0=; b=YO7RPQjGLbL7GYle2DlIBhDL3SaQSdKcyktyXszCIBrcmfS9Xu82ugFHJMH7yUVOdd HopwC8sDfmEP9T2TeMmLx3dMYyYJ3f2Eii9V70NXmkeBK8lodTauoiKxT7Y73sgIqkyg yM8uMyYQergyWiYwru/+FI4J0ST84ZJTqq14lMI/ru2/NeblKRq7LFBnG+o9qaQt4bfJ vLvMQjQASUQyUbnBdMQP+tNUijujV5tng52gM22oOnMm1j3fhDv1BVRDwo7fFbNywbUW 0rnLLEpK209Xg+xUO9acJ7TQoAfenVks9knYcrjv/bTUWsG0lRZ+m01yh4/7tpoXTu/X 42zw== X-Forwarded-Encrypted: i=1; AJvYcCVDGImVNkkk7qq3nUDjdobfWH/qSowKo1O4G1lnyMq3O6oJlMg2QWfF2xnlevrWCc0NVU+K7wRFhsLJ@vger.kernel.org X-Gm-Message-State: AOJu0YwK9Tb2lGLf6IbLHC0gRvuDFLbPKI1RE1Vwm/9iWHGRdjpUfsKJ oMsxraxVZoZfTbN8PFbqCm6Wkn3eOppPbEUXKoRumF4I8VKrt7DEdbb7YTEu3vo= X-Google-Smtp-Source: AGHT+IET0Zw1GUg8juWJTYxh5Mnsf3Wkht9UNm0mLBOVYbwCAwfJ4/8EQhMft+wrL/1dot2VgyvChA== X-Received: by 2002:a05:6512:b8e:b0:538:9e40:94b with SMTP id 2adb3069b0e04-53dc13384aemr1066848e87.19.1732106306977; Wed, 20 Nov 2024 04:38:26 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:927b:2848:1f7d:3776? ([2a01:e0a:982:cbb0:927b:2848:1f7d:3776]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53dbd4783c1sm626248e87.239.2024.11.20.04.38.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Nov 2024 04:38:25 -0800 (PST) Message-ID: <14583b16-776f-46ca-85fb-c1d151a72781@linaro.org> Date: Wed, 20 Nov 2024 13:38:23 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2 10/11] arm64: qcom: dts: sm8550: add interconnect and opp-peak-kBps for GPU To: Dmitry Baryshkov Cc: Akhil P Oommen , Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , Rob Clark , Sean Paul , Konrad Dybcio , Abhinav Kumar , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Connor Abbott , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org References: <20241119-topic-sm8x50-gpu-bw-vote-v2-0-4deb87be2498@linaro.org> <20241119-topic-sm8x50-gpu-bw-vote-v2-10-4deb87be2498@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/11/2024 12:47, Dmitry Baryshkov wrote: > On Tue, Nov 19, 2024 at 06:56:45PM +0100, Neil Armstrong wrote: >> Each GPU OPP requires a specific peak DDR bandwidth, let's add >> those to each OPP and also the related interconnect path. >> >> Signed-off-by: Neil Armstrong >> --- >> arch/arm64/boot/dts/qcom/sm8550.dtsi | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi >> index 9dc0ee3eb98f8711e01934e47331b99e3bb73682..808dce3a624197d38222f53fffa280e63088c1c1 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi >> @@ -2113,6 +2113,9 @@ gpu: gpu@3d00000 { >> qcom,gmu = <&gmu>; >> #cooling-cells = <2>; >> >> + interconnects = <&gem_noc MASTER_GFX3D 0 &mc_virt SLAVE_EBI1 0>; > > QCOM_ICC_TAG_ALWAYS Exact, bad copy paste... Thanks, Neil > >> + interconnect-names = "gfx-mem"; >> + >> status = "disabled"; >> >> zap-shader { >> @@ -2126,41 +2129,49 @@ gpu_opp_table: opp-table { >> opp-680000000 { >> opp-hz = /bits/ 64 <680000000>; >> opp-level = ; >> + opp-peak-kBps = <16500000>; >> }; >> >> opp-615000000 { >> opp-hz = /bits/ 64 <615000000>; >> opp-level = ; >> + opp-peak-kBps = <16500000>; >> }; >> >> opp-550000000 { >> opp-hz = /bits/ 64 <550000000>; >> opp-level = ; >> + opp-peak-kBps = <12449218>; >> }; >> >> opp-475000000 { >> opp-hz = /bits/ 64 <475000000>; >> opp-level = ; >> + opp-peak-kBps = <8171875>; >> }; >> >> opp-401000000 { >> opp-hz = /bits/ 64 <401000000>; >> opp-level = ; >> + opp-peak-kBps = <6671875>; >> }; >> >> opp-348000000 { >> opp-hz = /bits/ 64 <348000000>; >> opp-level = ; >> + opp-peak-kBps = <6074218>; >> }; >> >> opp-295000000 { >> opp-hz = /bits/ 64 <295000000>; >> opp-level = ; >> + opp-peak-kBps = <6074218>; >> }; >> >> opp-220000000 { >> opp-hz = /bits/ 64 <220000000>; >> opp-level = ; >> + opp-peak-kBps = <6074218>; >> }; >> }; >> }; >> >> -- >> 2.34.1 >> >