From: Marek Vasut <marex@denx.de>
To: pieterjanca@gmail.com, Pavel Machek <pavel@ucw.cz>,
Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Isai Gaspar <isaiezequiel.gaspar@nxp.com>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] leds: leds-pca995x: Add support for NXP PCA9956B
Date: Thu, 11 Jul 2024 13:47:02 +0200 [thread overview]
Message-ID: <1458500b-150f-4882-992c-02823cb8dcf8@denx.de> (raw)
In-Reply-To: <20240711-pca995x-v3-2-a1bf1f3c3f5a@gmail.com>
On 7/11/24 9:52 AM, Pieterjan Camerlynck via B4 Relay wrote:
[...]
> @@ -52,9 +69,9 @@ struct pca995x_led {
> };
>
> struct pca995x_chip {
> + const struct pca995x_chipdef *chipdef;
> struct regmap *regmap;
> struct pca995x_led leds[PCA995X_MAX_OUTPUTS];
> - int btype;
Nitpick, maybe you can replace btype with chipdef in this place, without
reordering the structure ?
> };
>
> static int pca995x_brightness_set(struct led_classdev *led_cdev,
In any case:
Reviewed-by: Marek Vasut <marex@denx.de>
Thanks !
prev parent reply other threads:[~2024-07-11 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 7:52 [PATCH v3 0/2] leds: leds-pca995x: Add support for NXP PCA9956B Pieterjan Camerlynck via B4 Relay
2024-07-11 7:52 ` [PATCH v3 1/2] dt-bindings: leds: pca995x: Add new nxp,pca9956b compatible Pieterjan Camerlynck via B4 Relay
2024-07-11 7:52 ` [PATCH v3 2/2] leds: leds-pca995x: Add support for NXP PCA9956B Pieterjan Camerlynck via B4 Relay
2024-07-11 11:47 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458500b-150f-4882-992c-02823cb8dcf8@denx.de \
--to=marex@denx.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=isaiezequiel.gaspar@nxp.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=pieterjanca@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).