From: "Petr Štetiar" <ynezz@true.cz>
To: devicetree@vger.kernel.org
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Russell King" <linux@arm.linux.org.uk>,
"Pawel Moll" <pawel.moll@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Marcel Ziswiler" <marcel.ziswiler@toradex.com>,
linux-pci@vger.kernel.org, "Tim Harvey" <tharvey@gateworks.com>,
"Richard Zhu" <Richard.Zhu@freescale.com>,
stefan@agner.ch, "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Hałasa" <khalasa@piap.pl>,
"Sascha Hauer" <kernel@pengutronix.de>,
"Kumar Gala" <galak@codeaurora.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Shawn Guo" <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org,
"Lucas Stach" <l.stach@pengutronix.de>
Subject: [PATCH] ARM: imx6: Fix PCIe reset gpio polarity on Toradex Apalis
Date: Fri, 1 Apr 2016 14:41:46 +0200 [thread overview]
Message-ID: <1459514508-8557-1-git-send-email-ynezz@true.cz> (raw)
In commit 5c5fb40de8f14 "PCI: imx6: Add support for active-low reset GPIO"
I've made GPIO reset polarity aware, which made the PCIe working on Apalis SoM
(reset active-high), but it has broken PCIe on several other i.MX6 boards
(reset active-low) due to wrong logic level. It has made the default reset
logic active-high, but it was active-low since beginning due to the bug in the
reset code:
gpio_set_value_cansleep(imx6_pcie->reset_gpio, 0);
msleep(100);
gpio_set_value_cansleep(imx6_pcie->reset_gpio, 1);
This breakage couldn't be fixed correctly by fixing the reset code snippet
mentioned above and fixing the broken DTBs, as we can't touch the DTBs, so the
5c5fb40de8f14 commit is going to be reverted, making PCIe reset broken on
Apalis modules again.
As suggested by Fabio, to fix this situation in backward compatible manner, we
should introduce new boolean DT property reset-gpio-active-high, which would
set PCIe reset GPIO polarity as needed. This patch series tries to do so.
next reply other threads:[~2016-04-01 12:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 12:41 Petr Štetiar [this message]
2016-04-01 12:41 ` [PATCH 1/2] ARM: dts: imx6: Fix PCIe reset gpio polarity on Toradex Apalis Ixora Petr Štetiar
2016-04-01 12:41 ` [PATCH 2/2] PCI: imx6: Add reset-gpio-active-high boolean property to DT Petr Štetiar
[not found] ` <1459514508-8557-3-git-send-email-ynezz-knWk7/PSn+s@public.gmane.org>
2016-04-05 15:46 ` Fabio Estevam
2016-04-06 8:11 ` Petr Štetiar
2016-04-06 9:34 ` [PATCH v2 " Petr Štetiar
[not found] ` <1459935244-10077-1-git-send-email-ynezz-knWk7/PSn+s@public.gmane.org>
2016-04-06 9:48 ` Lucas Stach
2016-04-06 12:36 ` [PATCH v3 " Petr Štetiar
[not found] ` <1459946207-11923-1-git-send-email-ynezz-knWk7/PSn+s@public.gmane.org>
2016-04-06 12:40 ` Lucas Stach
2016-04-11 13:38 ` Rob Herring
2016-04-14 15:28 ` Tim Harvey
2016-04-20 0:48 ` [PATCH] ARM: imx6: Fix PCIe reset gpio polarity on Toradex Apalis Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459514508-8557-1-git-send-email-ynezz@true.cz \
--to=ynezz@true.cz \
--cc=Richard.Zhu@freescale.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=khalasa@piap.pl \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marcel.ziswiler@toradex.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).