Re: [PATCH v3 4/9] dt-bindings: clock: brcm,kona-ccu: Add BCM281xx bus clocks

[Artur Weber <aweber.kernel@gmail.com>]

On 10.03.2025 10:43, Krzysztof Kozlowski wrote:
> On Sat, Mar 08, 2025 at 08:50:42AM +0100, Artur Weber wrote:
>> Add bus clocks corresponding to peripheral clocks currently supported
>> by the BCM281xx clock driver and add the relevant clock IDs to the
>> clock/bcm281xx.h dt-bindings header.
> 
> Please squash the patch so we see complete change.

> 
>>
>> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
>> ---
>> Changes in v3:
>> - Add more clock output names to example
>> - Drop CLOCK_COUNT defines from the DT binding header
>>
>> Changes in v2:
>> - Add this commit (BCM281xx bus clocks)
>> ---
>>   .../devicetree/bindings/clock/brcm,kona-ccu.yaml   | 33 ++++++++++++++++++++--
>>   include/dt-bindings/clock/bcm281xx.h               | 19 +++++++++++++
>>   2 files changed, 50 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/brcm,kona-ccu.yaml b/Documentation/devicetree/bindings/clock/brcm,kona-ccu.yaml
>> index dff04e24e92829b890bf7cd336f0e083bdb30fa6..d00dcf916b45904177614c6f19a5df02abdf42f7 100644
>> --- a/Documentation/devicetree/bindings/clock/brcm,kona-ccu.yaml
>> +++ b/Documentation/devicetree/bindings/clock/brcm,kona-ccu.yaml
>> @@ -40,7 +40,7 @@ properties:
>>   
>>     clock-output-names:
>>       minItems: 1
>> -    maxItems: 14
>> +    maxItems: 20
>>   
>>   required:
>>     - compatible
>> @@ -61,6 +61,8 @@ allOf:
>>               - const: hub_timer
>>               - const: pmu_bsc
>>               - const: pmu_bsc_var
>> +            - const: hub_timer_apb
>> +            - const: pmu_bsc_apb
>>     - if:
>>         properties:
>>           compatible:
>> @@ -86,6 +88,13 @@ allOf:
>>               - const: usb_ic
>>               - const: hsic2_48m
>>               - const: hsic2_12m
>> +            - const: sdio1_ahb
>> +            - const: sdio2_ahb
>> +            - const: sdio3_ahb
>> +            - const: sdio4_ahb
>> +            - const: usb_ic_ahb
>> +            - const: hsic2_ahb
>> +            - const: usb_otg_ahb
>>     - if:
>>         properties:
>>           compatible:
>> @@ -116,6 +125,16 @@ allOf:
>>               - const: bsc2
>>               - const: bsc3
>>               - const: pwm
>> +            - const: uartb_apb
>> +            - const: uartb2_apb
>> +            - const: uartb3_apb
>> +            - const: uartb4_apb
>> +            - const: ssp0_apb
>> +            - const: ssp2_apb
>> +            - const: bsc1_apb
>> +            - const: bsc2_apb
>> +            - const: bsc3_apb
>> +            - const: pwm_apb
> 
> Why pwm_apb cannot be after pwm? Any idea for sorting here?

I placed all bus clocks corresponding to peripheral clocks at the end of
the clock list (so as to not modify the IDs of previous clocks), in the
same order as their corresponding peripheral clocks. This applies both
to the dt-bindings/clock/bcm281xx.h header and to the clock binding
here (I kept the same order of clock names here as clock IDs in the
header).

The same reasoning applies to the BCM21664 bus clocks patch.

Best regards
Artur