From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Macpaul Lin" <macpaul.lin@mediatek.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Frank Wunderlich" <frank-w@public-files.de>,
"Bernhard Rosenkränzer" <bero@baylibre.com>,
"Sean Wang" <sean.wang@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Cc: Bear Wang <bear.wang@mediatek.com>,
Pablo Sun <pablo.sun@mediatek.com>,
Macpaul Lin <macpaul@gmail.com>, Ben Lok <ben.lok@mediatek.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: mediatek: add device-tree for Genio 1200 EVK board
Date: Wed, 6 Sep 2023 12:20:09 +0200 [thread overview]
Message-ID: <145f9a3e-af61-c62f-1752-2abb7663d7a3@linaro.org> (raw)
In-Reply-To: <951e34bc-dda3-f9d4-b251-7f0fd02052ee@mediatek.com>
On 06/09/2023 12:15, Macpaul Lin wrote:
>>> +
>>> +wifi_3v3: wifi-3v3-regulator {
>>
>> This is a friendly reminder during the review process.
>>
>> It seems my previous comments were not fully addressed. Maybe my
>> feedback got lost between the quotes, maybe you just forgot to apply it.
>> Please go back to the previous discussion and either implement all
>> requested changes or keep discussing them.
>
>
> This keeps a format with -regulator is because I've found some other use
> cases. It seems "-regulator" or "regulator-" could be arbitrary. I'm not
> sure if it is a new guideline for regulator's node. If there is in the
> devicetree document, maybe I just missed it?
What is the point to name in the same DTS some of the regulators
"regulator-foo" and some "foo-regulator"?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-06 10:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 9:20 [PATCH 1/2] dt-bindings: arm64: dts: mediatek: Add mt8395-evk board Macpaul Lin
2023-09-04 9:20 ` [PATCH 2/2] arm64: dts: mediatek: add device-tree for Genio 1200 EVK board Macpaul Lin
2023-09-04 9:37 ` Krzysztof Kozlowski
2023-09-04 9:33 ` [PATCH 1/2] dt-bindings: arm64: dts: mediatek: Add mt8395-evk board Krzysztof Kozlowski
2023-09-04 9:50 ` Macpaul Lin
2023-09-04 12:11 ` Krzysztof Kozlowski
2023-09-05 9:36 ` Macpaul Lin
2023-09-05 10:36 ` Krzysztof Kozlowski
2023-09-05 10:58 ` AngeloGioacchino Del Regno
2023-09-06 2:41 ` Macpaul Lin
2023-09-06 9:25 ` [PATCH v2 1/2] dt-bindings: arm64: dts: mediatek: add " Macpaul Lin
2023-09-06 9:25 ` [PATCH v2 2/2] arm64: dts: mediatek: add device-tree for Genio 1200 EVK board Macpaul Lin
2023-09-06 9:34 ` Krzysztof Kozlowski
2023-09-06 10:15 ` Macpaul Lin
2023-09-06 10:20 ` Krzysztof Kozlowski [this message]
2023-09-06 11:49 ` Macpaul Lin
2023-09-06 9:32 ` [PATCH v2 1/2] dt-bindings: arm64: dts: mediatek: add mt8395-evk board Krzysztof Kozlowski
2023-09-06 9:53 ` Macpaul Lin
2023-09-06 10:05 ` Krzysztof Kozlowski
2023-09-06 10:48 ` AngeloGioacchino Del Regno
2023-09-06 11:24 ` Krzysztof Kozlowski
2023-09-06 11:47 ` Macpaul Lin
2023-09-06 12:19 ` Frank Wunderlich
2023-09-07 4:07 ` Macpaul Lin
2023-09-07 5:58 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=145f9a3e-af61-c62f-1752-2abb7663d7a3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bear.wang@mediatek.com \
--cc=ben.lok@mediatek.com \
--cc=bero@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macpaul.lin@mediatek.com \
--cc=macpaul@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=pablo.sun@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).