From: David Lechner <david@lechnology.com>
Cc: petr@barix.com, sergei.shtylyov@cogentembedded.com,
khilman@kernel.org, nsekhar@ti.com,
David Lechner <david@lechnology.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>, Bin Liu <b-liu@ti.com>,
Lee Jones <lee.jones@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: [PATCH v4 3/7] phy: Add set_mode callback
Date: Thu, 14 Apr 2016 13:35:14 -0500 [thread overview]
Message-ID: <1460658919-4965-4-git-send-email-david@lechnology.com> (raw)
In-Reply-To: <1460658919-4965-1-git-send-email-david@lechnology.com>
The initial use for this is for PHYs that have a mode related to USB OTG.
There are several SoCs (e.g. TI OMAP and DA8xx) that have a mode setting
in the USB PHY to override OTG VBUS and ID signals.
Of course, the enum can be expaned in the future to include modes for
other types of PHYs as well.
Suggested-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: David Lechner <david@lechnology.com>
---
v4 changes:
* This is a new patch to avoid exporting a symbol from the phy-da8xx-usb driver.
drivers/phy/phy-core.c | 15 +++++++++++++++
include/linux/phy/phy.h | 15 +++++++++++++++
2 files changed, 30 insertions(+)
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
index e7e574d..fe0344c 100644
--- a/drivers/phy/phy-core.c
+++ b/drivers/phy/phy-core.c
@@ -342,6 +342,21 @@ int phy_power_off(struct phy *phy)
}
EXPORT_SYMBOL_GPL(phy_power_off);
+int phy_set_mode(struct phy *phy, enum phy_mode mode)
+{
+ int ret;
+
+ if (!phy || !phy->ops->set_mode)
+ return 0;
+
+ mutex_lock(&phy->mutex);
+ ret = phy->ops->set_mode(phy, mode);
+ mutex_unlock(&phy->mutex);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(phy_set_mode);
+
/**
* _of_phy_get() - lookup and obtain a reference to a phy by phandle
* @np: device_node for which to get the phy
diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
index 8cf05e3..d66f4d9 100644
--- a/include/linux/phy/phy.h
+++ b/include/linux/phy/phy.h
@@ -22,12 +22,20 @@
struct phy;
+enum phy_mode {
+ PHY_MODE_INVALID,
+ PHY_MODE_USB_HOST,
+ PHY_MODE_USB_DEVICE,
+ PHY_MODE_USB_OTG,
+};
+
/**
* struct phy_ops - set of function pointers for performing phy operations
* @init: operation to be performed for initializing phy
* @exit: operation to be performed while exiting
* @power_on: powering on the phy
* @power_off: powering off the phy
+ * @set_mode: set the mode of the phy
* @owner: the module owner containing the ops
*/
struct phy_ops {
@@ -35,6 +43,7 @@ struct phy_ops {
int (*exit)(struct phy *phy);
int (*power_on)(struct phy *phy);
int (*power_off)(struct phy *phy);
+ int (*set_mode)(struct phy *phy, enum phy_mode mode);
struct module *owner;
};
@@ -119,6 +128,7 @@ int phy_init(struct phy *phy);
int phy_exit(struct phy *phy);
int phy_power_on(struct phy *phy);
int phy_power_off(struct phy *phy);
+int phy_set_mode(struct phy *phy, enum phy_mode mode);
static inline int phy_get_bus_width(struct phy *phy)
{
return phy->attrs.bus_width;
@@ -224,6 +234,13 @@ static inline int phy_power_off(struct phy *phy)
return -ENOSYS;
}
+static inline int phy_set_mode(struct phy *phy, enum phy_mode mode)
+{
+ if (!phy)
+ return 0;
+ return -ENOSYS;
+}
+
static inline int phy_get_bus_width(struct phy *phy)
{
return -ENOSYS;
--
1.9.1
next prev parent reply other threads:[~2016-04-14 18:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 18:35 [PATCH v4 0/7] da8xx USB PHY (was da8xx USB clocks) David Lechner
2016-04-14 18:35 ` [PATCH v4 1/7] mfd: da8xx-cfgchip: New header file for CFGCHIP registers David Lechner
[not found] ` <1460658919-4965-2-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2016-04-25 14:08 ` Lee Jones
2016-04-14 18:35 ` [PATCH v4 2/7] dt-bindings: Add bindings for phy-da8xx-usb David Lechner
2016-04-15 10:48 ` Sergei Shtylyov
[not found] ` <5710C6E1.8010401-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-04-15 16:13 ` David Lechner
2016-04-15 17:05 ` Sergei Shtylyov
2016-04-14 18:35 ` David Lechner [this message]
[not found] ` <1460658919-4965-4-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2016-05-04 18:10 ` [PATCH v4 3/7] phy: Add set_mode callback Bin Liu
2016-05-04 18:20 ` David Lechner
[not found] ` <572A3D74.3080907-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2016-05-04 18:39 ` Bin Liu
2016-05-04 19:48 ` David Lechner
2016-05-09 22:47 ` David Lechner
2016-04-14 18:35 ` [PATCH v4 4/7] phy: da8xx-usb: new driver for DA8xx SoC USB PHY David Lechner
2016-04-19 8:03 ` Kishon Vijay Abraham I
2016-04-14 18:35 ` [PATCH v4 5/7] usb: ohci-da8xx: Remove code that references mach David Lechner
2016-04-14 18:35 ` [PATCH v4 6/7] usb: musb: da8xx: Use devm in probe David Lechner
2016-04-14 18:35 ` [PATCH v4 7/7] usb: musb: da8xx: Remove mach code David Lechner
[not found] ` <1460658919-4965-1-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2016-05-04 16:24 ` [PATCH v4 0/7] da8xx USB PHY (was da8xx USB clocks) David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460658919-4965-4-git-send-email-david@lechnology.com \
--to=david@lechnology.com \
--cc=b-liu@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=khilman@kernel.org \
--cc=kishon@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nsekhar@ti.com \
--cc=pawel.moll@arm.com \
--cc=petr@barix.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).