Re: [PATCH v10 5/5] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board

[tessolveupstream@gmail.com]

On 30-12-2025 20:21, Konrad Dybcio wrote:
> On 12/30/25 2:02 PM, Sudarshan Shetty wrote:
>> Add the device tree for the QCS615-based Talos EVK platform. The
>> platform is composed of a System-on-Module following the SMARC
>> standard, and a Carrier Board.
>>
>> The Carrier Board supports several display configurations, HDMI and
>> LVDS. Both configurations use the same base hardware, with the display
>> selection controlled by a DIP switch.
> 
> [...]
> 
>> +++ b/arch/arm64/boot/dts/qcom/talos-evk-lvds-auo,g133han01.dtso
>> @@ -0,0 +1,126 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>> + */
>> +/dts-v1/;
>> +/plugin/;
>> +
>> +#include <dt-bindings/gpio/gpio.h>
>> +
>> +&{/} {
>> +	backlight: backlight {
>> +		compatible = "gpio-backlight";
>> +		gpios = <&tlmm 59 GPIO_ACTIVE_HIGH>,
>> +			<&tlmm 115 GPIO_ACTIVE_HIGH>;
>> +		default-on;
>> +	};
>> +
>> +	hdmi_connector: hdmi-out {
>> +		status = "disabled";
>> +	};
> 
> This should be a &label_reference
>

Okay, will add it in the next patch.
> [...]
> 
>> +	wifi_1p8v: regulator-wifi-1p8v {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "wifi_1p8v";
>> +		regulator-min-microvolt = <1800000>;
>> +		regulator-max-microvolt = <1800000>;
>> +		gpio = <&tlmm 91 GPIO_ACTIVE_HIGH>;
>> +		enable-active-high;
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&wifi_reg_en_pins_state>;
> 
> property-n
> property-names
> 
> consistently, please
>

I didn’t fully understand your comment.
Could you please elaborate a bit more so I can make the
necessary changes correctly. >> +		regulator-boot-on;
>> +		regulator-always-on;
>> +	};
>> +
>> +	wifi_3p85v: regulator-wifi-3p85v {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "wifi_3p85v";
>> +		regulator-min-microvolt = <3850000>;
>> +		regulator-max-microvolt = <3850000>;
>> +		gpio = <&tlmm 91 GPIO_ACTIVE_HIGH>;
>> +		enable-active-high;
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&wifi_reg_en_pins_state>;
> 
> ditto
> 
> [...]
> 
>> +&tlmm {
>> +	bt_en_state: bt-en-state {
>> +		pins = "gpio85";
>> +		function = "gpio";
>> +		bias-pull-down;
>> +		output-low;
> 
> output-low/high should be unnecessary as these pins are governed
> by the kernel driver
> 

Okay,got it. Will make the necessary change in the next patch.
> lg otherwise
> 
> Konrad