[PATCH] arm64: tegra: fix compatible string for Tegra132 fuse node

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] arm64: tegra: fix compatible string for Tegra132 fuse node
@ 2016-05-03  9:09 Wei Ni
  2016-05-03 15:21 ` Thierry Reding
  0 siblings, 1 reply; 6+ messages in thread
From: Wei Ni @ 2016-05-03  9:09 UTC (permalink / raw)
  To: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A
  Cc: swarren-3lzwWm7+Weoh9ZMKESR00Q,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Wei Ni

This patch changes the compatible of Tegra132 fuse node
to "nvidia,tegra132-efuse", instead of "nvidia,tegra1124-efuse".
Because the CONFIG_ARCH_TEGRA_124_SOC will not be enabled for
Tegra132, the fuse driver can't find the corresponding node.

Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
 arch/arm64/boot/dts/nvidia/tegra132.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/nvidia/tegra132.dtsi b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
index 5d013809448b..ee101cb52f70 100644
--- a/arch/arm64/boot/dts/nvidia/tegra132.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
@@ -582,7 +582,7 @@
 	};
 
 	fuse@7000f800 {
-		compatible = "nvidia,tegra124-efuse";
+		compatible = "nvidia,tegra132-efuse";
 		reg = <0x0 0x7000f800 0x0 0x400>;
 		clocks = <&tegra_car TEGRA124_CLK_FUSE>;
 		clock-names = "fuse";
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: tegra: fix compatible string for Tegra132 fuse node
  2016-05-03  9:09 [PATCH] arm64: tegra: fix compatible string for Tegra132 fuse node Wei Ni
@ 2016-05-03 15:21 ` Thierry Reding
       [not found]   ` <20160503152111.GC19539-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: Thierry Reding @ 2016-05-03 15:21 UTC (permalink / raw)
  To: Wei Ni; +Cc: robh+dt, swarren, linux-tegra, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 652 bytes --]

On Tue, May 03, 2016 at 05:09:37PM +0800, Wei Ni wrote:
> This patch changes the compatible of Tegra132 fuse node
> to "nvidia,tegra132-efuse", instead of "nvidia,tegra1124-efuse".
> Because the CONFIG_ARCH_TEGRA_124_SOC will not be enabled for
> Tegra132, the fuse driver can't find the corresponding node.

Okay, that's not really a good reason to modify the DTS. What we should
do instead is make sure that the OF table contains the entry on Tegra132
builds. Unless the IP block really is different and Tegra124 and
Tegra132 aren't compatible in this regard after all.

In the latter case the commit message should reflect the real reason.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

[parent not found: <20160503152111.GC19539-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>]

* Re: [PATCH] arm64: tegra: fix compatible string for Tegra132 fuse node
       [not found]   ` <20160503152111.GC19539-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
@ 2016-05-04  2:25     ` Wei Ni
       [not found]       ` <57295DAF.1050800-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: Wei Ni @ 2016-05-04  2:25 UTC (permalink / raw)
  To: Thierry Reding
  Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, swarren-3lzwWm7+Weoh9ZMKESR00Q,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA



On 2016年05月03日 23:21, Thierry Reding wrote:
> * PGP Signed by an unknown key
> 
> On Tue, May 03, 2016 at 05:09:37PM +0800, Wei Ni wrote:
>> This patch changes the compatible of Tegra132 fuse node
>> to "nvidia,tegra132-efuse", instead of "nvidia,tegra1124-efuse".
>> Because the CONFIG_ARCH_TEGRA_124_SOC will not be enabled for
>> Tegra132, the fuse driver can't find the corresponding node.
> 
> Okay, that's not really a good reason to modify the DTS. What we should
> do instead is make sure that the OF table contains the entry on Tegra132
> builds. Unless the IP block really is different and Tegra124 and
> Tegra132 aren't compatible in this regard after all.
> 
> In the latter case the commit message should reflect the real reason.

Hi Thierry,

The fuse driver fuse-tegra.c has following OF table:
#ifdef CONFIG_ARCH_TEGRA_132_SOC
        { .compatible = "nvidia,tegra132-efuse", .data = &tegra124_fuse_soc },
#endif
#ifdef CONFIG_ARCH_TEGRA_124_SOC
        { .compatible = "nvidia,tegra124-efuse", .data = &tegra124_fuse_soc },
#endif

It defined "nvidia,tegra124-efuse" under CONFIG_ARCH_TEGRA_124_SOC, so if we
don't change the DTS file, we should change it as:
-#ifdef CONFIG_ARCH_TEGRA_132_SOC
-       { .compatible = "nvidia,tegra132-efuse", .data = &tegra124_fuse_soc },
-#endif
-#ifdef CONFIG_ARCH_TEGRA_124_SOC
+#if defined CONFIG_ARCH_TEGRA_124_SOC || defined CONFIG_ARCH_TEGRA_132_SOC
        { .compatible = "nvidia,tegra124-efuse", .data = &tegra124_fuse_soc },
 #endif
 #ifdef CONFIG_ARCH_TEGRA_114_SOC

I will send it out.

> 
> Thierry
> 
> * Unknown Key
> * 0x7F3EB3A1
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

[parent not found: <57295DAF.1050800-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]

* Re: [PATCH] arm64: tegra: fix compatible string for Tegra132 fuse node
       [not found]       ` <57295DAF.1050800-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
@ 2016-05-04  7:32         ` Wei Ni
  0 siblings, 0 replies; 6+ messages in thread
From: Wei Ni @ 2016-05-04  7:32 UTC (permalink / raw)
  To: Thierry Reding
  Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, swarren-3lzwWm7+Weoh9ZMKESR00Q,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA



On 2016年05月04日 10:25, Wei Ni wrote:
> 
> 
> On 2016年05月03日 23:21, Thierry Reding wrote:
>> * PGP Signed by an unknown key
>>
>> On Tue, May 03, 2016 at 05:09:37PM +0800, Wei Ni wrote:
>>> This patch changes the compatible of Tegra132 fuse node
>>> to "nvidia,tegra132-efuse", instead of "nvidia,tegra1124-efuse".
>>> Because the CONFIG_ARCH_TEGRA_124_SOC will not be enabled for
>>> Tegra132, the fuse driver can't find the corresponding node.
>>
>> Okay, that's not really a good reason to modify the DTS. What we should
>> do instead is make sure that the OF table contains the entry on Tegra132
>> builds. Unless the IP block really is different and Tegra124 and
>> Tegra132 aren't compatible in this regard after all.
>>
>> In the latter case the commit message should reflect the real reason.

Hi Thierry,
I read the Documentation/devicetree/bindings/fuse/nvidia,tegra20-fuse.txt, it
has description:
- compatible : For Tegra20, must contain "nvidia,tegra20-efuse".  For Tegra30,
  must contain "nvidia,tegra30-efuse".  For Tegra114, must contain
  "nvidia,tegra114-efuse".  For Tegra124, must contain "nvidia,tegra124-efuse".
  Otherwise, must contain "nvidia,<chip>-efuse", plus one of the above, where
  <chip> is tegra132.

It mean for Tegra132, it should use "nvidia,tegra132-efuse".

So if we don't change the DTS file, I need to fix the OF table in the driver and
update the of-bindings, is it right?


Wei.

> 
> Hi Thierry,
> 
> The fuse driver fuse-tegra.c has following OF table:
> #ifdef CONFIG_ARCH_TEGRA_132_SOC
>         { .compatible = "nvidia,tegra132-efuse", .data = &tegra124_fuse_soc },
> #endif
> #ifdef CONFIG_ARCH_TEGRA_124_SOC
>         { .compatible = "nvidia,tegra124-efuse", .data = &tegra124_fuse_soc },
> #endif
> 
> It defined "nvidia,tegra124-efuse" under CONFIG_ARCH_TEGRA_124_SOC, so if we
> don't change the DTS file, we should change it as:
> -#ifdef CONFIG_ARCH_TEGRA_132_SOC
> -       { .compatible = "nvidia,tegra132-efuse", .data = &tegra124_fuse_soc },
> -#endif
> -#ifdef CONFIG_ARCH_TEGRA_124_SOC
> +#if defined CONFIG_ARCH_TEGRA_124_SOC || defined CONFIG_ARCH_TEGRA_132_SOC
>         { .compatible = "nvidia,tegra124-efuse", .data = &tegra124_fuse_soc },
>  #endif
>  #ifdef CONFIG_ARCH_TEGRA_114_SOC
> 
> I will send it out.
> 
>>
>> Thierry
>>
>> * Unknown Key
>> * 0x7F3EB3A1
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] arm64: tegra: fix compatible string for Tegra132 fuse node
@ 2016-05-03  9:32 Wei Ni
  2016-05-03 10:11 ` Wei Ni
  0 siblings, 1 reply; 6+ messages in thread
From: Wei Ni @ 2016-05-03  9:32 UTC (permalink / raw)
  To: edubezval-Re5JQEeQqe8AvxtiuMwx3w,
	thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A, rui.zhang-ral2JQCrhuEAvxtiuMwx3w
  Cc: MLongnecker-DDmLM1+adcrQT0dZR+AlfA,
	swarren-3lzwWm7+Weoh9ZMKESR00Q, mikko.perttunen-/1wQRMveznE,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA,
	linux-pm-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Wei Ni

This patch changes the compatible of Tegra132 fuse node
to "nvidia,tegra132-efuse", instead of "nvidia,tegra1124-efuse".
Because the CONFIG_ARCH_TEGRA_124_SOC will not be enabled for
Tegra132, the fuse driver can't find the corresponding node.

Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
 arch/arm64/boot/dts/nvidia/tegra132.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/nvidia/tegra132.dtsi b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
index 5d013809448b..ee101cb52f70 100644
--- a/arch/arm64/boot/dts/nvidia/tegra132.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
@@ -582,7 +582,7 @@
 	};
 
 	fuse@7000f800 {
-		compatible = "nvidia,tegra124-efuse";
+		compatible = "nvidia,tegra132-efuse";
 		reg = <0x0 0x7000f800 0x0 0x400>;
 		clocks = <&tegra_car TEGRA124_CLK_FUSE>;
 		clock-names = "fuse";
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: tegra: fix compatible string for Tegra132 fuse node
  2016-05-03  9:32 Wei Ni
@ 2016-05-03 10:11 ` Wei Ni
  0 siblings, 0 replies; 6+ messages in thread
From: Wei Ni @ 2016-05-03 10:11 UTC (permalink / raw)
  To: edubezval, thierry.reding, robh+dt, rui.zhang
  Cc: MLongnecker, swarren, mikko.perttunen, linux-tegra, linux-pm,
	devicetree, linux-kernel

Sorry, please ignore this mail.

On 2016年05月03日 17:32, Wei Ni wrote:
> This patch changes the compatible of Tegra132 fuse node
> to "nvidia,tegra132-efuse", instead of "nvidia,tegra1124-efuse".
> Because the CONFIG_ARCH_TEGRA_124_SOC will not be enabled for
> Tegra132, the fuse driver can't find the corresponding node.
> 
> Signed-off-by: Wei Ni <wni@nvidia.com>
> ---
>  arch/arm64/boot/dts/nvidia/tegra132.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra132.dtsi b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
> index 5d013809448b..ee101cb52f70 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra132.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
> @@ -582,7 +582,7 @@
>  	};
>  
>  	fuse@7000f800 {
> -		compatible = "nvidia,tegra124-efuse";
> +		compatible = "nvidia,tegra132-efuse";
>  		reg = <0x0 0x7000f800 0x0 0x400>;
>  		clocks = <&tegra_car TEGRA124_CLK_FUSE>;
>  		clock-names = "fuse";
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-05-04  7:32 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-03  9:09 [PATCH] arm64: tegra: fix compatible string for Tegra132 fuse node Wei Ni
2016-05-03 15:21 ` Thierry Reding
     [not found]   ` <20160503152111.GC19539-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
2016-05-04  2:25     ` Wei Ni
     [not found]       ` <57295DAF.1050800-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-05-04  7:32         ` Wei Ni
  -- strict thread matches above, loose matches on Subject: below --
2016-05-03  9:32 Wei Ni
2016-05-03 10:11 ` Wei Ni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).