From mboxrd@z Thu Jan 1 00:00:00 1970 From: chunfeng yun Subject: Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode Date: Thu, 12 May 2016 09:41:22 +0800 Message-ID: <1463017282.11651.82.camel@mhfsdcap03> References: <1462868614-20602-1-git-send-email-chunfeng.yun@mediatek.com> <1462868614-20602-7-git-send-email-chunfeng.yun@mediatek.com> <1462991546.11623.3.camel@mussux00> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1462991546.11623.3.camel@mussux00> Sender: linux-kernel-owner@vger.kernel.org To: Hongzhou Yang Cc: Linus Walleij , Maoguang Meng , Yingjoe Chen , Greg Kroah-Hartman , Felipe Balbi , Mathias Nyman , Alan Stern , Rob Herring , Mark Rutland , Ian Campbell , Matthias Brugger , Sergei Shtylyov , Pawel Moll , Kumar Gala , Sascha Hauer , Biao Huang , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-arm-kernel@lists.infradead.or List-Id: devicetree@vger.kernel.org Hi, On Wed, 2016-05-11 at 11:32 -0700, Hongzhou Yang wrote: > On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote: > > On Tue, May 10, 2016 at 10:23 AM, Chunfeng Yun > > wrote: > > > > > the default mode of GPIO16 pin is gpio, when set EINT16 to > > > IRQ_TYPE_LEVEL_HIGH, no interrupt is triggered, it can be > > > fixed when set its default mode as usb iddig. > > > > > > Signed-off-by: Chunfeng Yun > > > > Chunfeng, GPIO16 can be used as EINT16 mode, but the pinmux should be 0. > If you want to set its default mode to iddig, you should set it in dts. > I set it in DTS, but it didn't work, because when usb driver requested IRQ, pinmux was switched back to default mode set by MTK_EINT_FUNCTION(). > Yours, > Hongzhou >