From: David Wu <david.wu@rock-chips.com>
To: heiko@sntech.de, wsa@the-dreams.de
Cc: robh+dt@kernel.org, dianders@chromium.org,
andy.shevchenko@gmail.com, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, briannorris@google.com,
davidriley@google.com, huangtao@rock-chips.com,
hl@rock-chips.com, xjq@rock-chips.com, zyw@rock-chips.com,
cf@rock-chips.com, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
David Wu <david.wu@rock-chips.com>
Subject: [PATCH v10 3/8] i2c: rk3x: Remove redundant rk3x_i2c_clean_ipd()
Date: Mon, 16 May 2016 21:57:38 +0800 [thread overview]
Message-ID: <1463407063-41218-4-git-send-email-david.wu@rock-chips.com> (raw)
In-Reply-To: <1463407063-41218-1-git-send-email-david.wu@rock-chips.com>
rk3x_i2c_setup() gets called directly before rk3x_i2c_start(),
and the last thing in setup was to clean the IPD, so no reason
to do it at the beginning of start.
Signed-off-by: David Wu <david.wu@rock-chips.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Heiko Stuebner <heiko@sntech.de>
---
Change in v10:
- none
Change in v9:
- modify commit message
Change in v8:
- none
drivers/i2c/busses/i2c-rk3x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
index 1e2677a..9eeb4e5 100644
--- a/drivers/i2c/busses/i2c-rk3x.c
+++ b/drivers/i2c/busses/i2c-rk3x.c
@@ -174,7 +174,6 @@ static void rk3x_i2c_start(struct rk3x_i2c *i2c)
{
u32 val;
- rk3x_i2c_clean_ipd(i2c);
i2c_writel(i2c, REG_INT_START, REG_IEN);
/* enable adapter with correct mode, send START condition */
--
1.9.1
next prev parent reply other threads:[~2016-05-16 13:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 13:57 [PATCH v10 0/8] add i2c driver supported for rk3399 David Wu
2016-05-16 13:57 ` [PATCH v10 1/8] i2c: rk3x: add documentation to fields in "struct rk3x_i2c" David Wu
2016-05-16 13:57 ` [PATCH v10 2/8] i2c: rk3x: use struct "rk3x_i2c_calced_timings" David Wu
2016-05-16 13:57 ` David Wu [this message]
2016-05-16 13:57 ` [PATCH v10 4/8] i2c: rk3x: Change SoC data to not use array David Wu
2016-05-16 14:03 ` [PATCH v10 5/8] i2c: rk3x: Move spec timing data to "static const" structs David Wu
[not found] ` <1463407063-41218-1-git-send-email-david.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-05-16 14:04 ` [PATCH v10 6/8] dt-bindings: i2c: rk3x: add support for rk3399 David Wu
2016-05-16 16:45 ` Rob Herring
2016-06-17 11:56 ` [PATCH v10 0/8] add i2c driver supported " Wolfram Sang
2016-06-20 2:18 ` David.Wu
2016-06-20 2:18 ` David.Wu
2016-05-16 14:05 ` [PATCH v10 7/8] i2c: rk3x: add i2c support for rk3399 soc David Wu
2016-05-16 17:22 ` Doug Anderson
2016-05-16 14:06 ` [PATCH v10 8/8] i2c: rk3x: support fast-mode plus for rk3399 David Wu
2016-05-16 20:17 ` [PATCH v10 0/8] add i2c driver supported " Doug Anderson
2016-06-08 15:47 ` Heiko Stübner
2016-06-09 7:47 ` Wolfram Sang
2016-06-09 14:12 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463407063-41218-4-git-send-email-david.wu@rock-chips.com \
--to=david.wu@rock-chips.com \
--cc=andy.shevchenko@gmail.com \
--cc=briannorris@google.com \
--cc=cf@rock-chips.com \
--cc=davidriley@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=hl@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
--cc=xjq@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).