From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: get_maintainer.pl and MAINTAINERS file Date: Thu, 19 May 2016 15:32:53 -0700 Message-ID: <1463697173.14098.46.camel@perches.com> References: <1463574199-21077-1-git-send-email-robin@protonic.nl> <20160518150924.GA3871@kroah.com> <20160519105418.5df3c8f7@erd979> <871t4yfbmy.fsf_-_@kamboji.qca.qualcomm.com> <573E19B5.1050800@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <573E19B5.1050800@suse.cz> Sender: linux-kernel-owner@vger.kernel.org To: Jiri Slaby , Kalle Valo , Robin van der Gracht Cc: Mark Rutland , Pawel Moll , Kumar Gala , "David S . Miller" , Miguel Ojeda Sandonis , Matt Ranostay , Ian Campbell , Jonathan Cameron , Rob Herring , Shawn Guo , Andrew Morton , Greg Kroah-Hartman , Thierry Reding , Mauro Carvalho Chehab , Guenter Roeck , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Thu, 2016-05-19 at 21:53 +0200, Jiri Slaby wrote: > Cc: joe >=20 > On 05/19/2016, 02:57 PM, Kalle Valo wrote: > >=20 > > (Changed the subject from "Re: [PATCH v6 0/3] auxdisplay: Introduce= ht16k33 driver") > >=20 > > Robin van der Gracht writes: > >=20 > > >=20 > > > >=20 > > > > And 4th, what is with the insane number of people on cc:?=A0=A0= Use > > > > get_maintainer.pl correctly please, and don't just hit everyone= you > > > > can possibly think of with a cc: for no good reason. > > > I did use the get_maintainer script. I solely passed the patch se= t as > > > command line argument. > > I think get_maintainer script should ignore MAINTAINERS file altoge= ther. Maybe, maybe not. The list of MAINTAINERS names returned by get_maintainer.pl is: Andrew Morton (commit_signer:39/504=3D8%) "David S. Miller" (commit_signer:38/504=3D8%) Greg Kroah-Hartman (commit_signer:36/504=3D= 7%) Kalle Valo (commit_signer:28/504=3D6%) Mauro Carvalho Chehab (added_lines:109/2073=3D= 5%,removed_lines:108/779=3D14%) Guenter Roeck (removed_lines:48/779=3D6%) Jiri Slaby (removed_lines:46/779=3D6%) > > After I did drivers/net/wireless reorganisation, and had to make > > numerous changes to MAINTAINERS in the process, I have been CCed to= all > > sorts of patchsets to which I have nothing to do with (this one > > included). I suspect get_maintainer.pl is to blame here. Doubtful but possible. I have no idea how many files were modified by whatever patch was checked, but more files, more maintainers. Unmaintained files have even more "not quite maintainers", but get_maintainer.pl lists the names of people that recently modified those specific files. > Last time I even tried to fix this up, but failed due to time > limitations as the code is a bit complex. >=20 > Joe, you seem to be the one who touched the script many times recentl= y. > May we ask you to fix this up? I'm not touching stuff right now. =A0Maybe next month.