From: Shawn Lin <shawn.lin@rock-chips.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Michal Simek <michal.simek@xilinx.com>,
soren.brinkmann@xilinx.com, Rob Herring <robh+dt@kernel.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Doug Anderson <dianders@chromium.org>,
Brian Norris <briannorris@chromium.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
Shawn Lin <shawn.lin@rock-chips.com>
Subject: [PATCH v6 2/5] mmc: core: add mmc-hs400-enhanced-strobe support
Date: Thu, 26 May 2016 09:56:12 +0800 [thread overview]
Message-ID: <1464227772-31255-1-git-send-email-shawn.lin@rock-chips.com> (raw)
In-Reply-To: <1464227707-30616-1-git-send-email-shawn.lin@rock-chips.com>
This patch introduce mmc-hs400-enhanced-strobe for platforms
which want to enable enhanced strobe function from DT if the
mmc host controller claims to support enhanced strobe.
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Jaehoon Chung <jh80.chung@samsung.com>
---
Changes in v6:
- add Doug's review-tag and Jaehoon's test-tag
Changes in v5:
- avoid to call hs400_enhanced+_strobe in mmc_set_initial_state
if no setting MMC_CAP2_HS400_ES.
- add Adrian's ack for patch[5/5]
Changes in v4:
- check avail_type with EXT_CSD_CARD_TYPE_HS400 instead of
card_type
- check if host support 8-bit when selecting hs400es
- some minor fix suggested by Douglas and add his review tag
Changes in v3:
- remove helper function and shorten cap2 to MMC_CAP2_HS400_ES
- rename callback to hs400_enhanced_strobe and make it return void
- add enhanced_strobe in mmc_ios and pass it to hs400_enhanced_strobe
- disable host's enhanced strobe in mmc_set_initial_state
- remove bus checking after switching hs400es
- add new function for hs400es timing selection
- fix wrong judgement of mmc_card_hs400es
Changes in v2:
- switch to HS400ES from Highspeed mode directly
drivers/mmc/core/host.c | 2 ++
include/linux/mmc/host.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index e0a3ee1..45773e4 100644
--- a/drivers/mmc/core/host.c
+++ b/drivers/mmc/core/host.c
@@ -289,6 +289,8 @@ int mmc_of_parse(struct mmc_host *host)
host->caps2 |= MMC_CAP2_HS400_1_8V | MMC_CAP2_HS200_1_8V_SDR;
if (of_property_read_bool(np, "mmc-hs400-1_2v"))
host->caps2 |= MMC_CAP2_HS400_1_2V | MMC_CAP2_HS200_1_2V_SDR;
+ if (of_property_read_bool(np, "mmc-hs400-enhanced-strobe"))
+ host->caps2 |= MMC_CAP2_HS400_ES;
host->dsr_req = !of_property_read_u32(np, "dsr", &host->dsr);
if (host->dsr_req && (host->dsr & ~0xffff)) {
diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
index 85800b4..2a06fb0 100644
--- a/include/linux/mmc/host.h
+++ b/include/linux/mmc/host.h
@@ -302,6 +302,7 @@ struct mmc_host {
#define MMC_CAP2_SDIO_IRQ_NOTHREAD (1 << 17)
#define MMC_CAP2_NO_WRITE_PROTECT (1 << 18) /* No physical write protect pin, assume that card is always read-write */
#define MMC_CAP2_NO_SDIO (1 << 19) /* Do not send SDIO commands during initialization */
+#define MMC_CAP2_HS400_ES (1 << 20) /* Host supports enhanced strobe */
mmc_pm_flag_t pm_caps; /* supported pm features */
--
2.3.7
next prev parent reply other threads:[~2016-05-26 1:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 1:55 [PATCH v6 0/5] Add enhanced strobe support for emmc version 5.1 or later Shawn Lin
2016-05-26 1:56 ` [PATCH v6 1/5] Documentation: mmc: add mmc-hs400-enhanced-strobe Shawn Lin
2016-05-26 1:56 ` Shawn Lin [this message]
[not found] ` <1464227707-30616-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-05-26 1:56 ` [PATCH v6 3/5] mmc: core: implement enhanced strobe support Shawn Lin
2016-05-26 11:04 ` Adrian Hunter
2016-05-27 6:45 ` Shawn Lin
2016-05-26 1:56 ` [PATCH v6 5/5] mmc: sdhci-of-arasan: implement enhanced strobe callback Shawn Lin
2016-05-26 1:56 ` [PATCH v6 4/5] mmc: debugfs: add HS400 enhanced strobe description Shawn Lin
2016-06-03 8:34 ` [PATCH v6 0/5] Add enhanced strobe support for emmc version 5.1 or later Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464227772-31255-1-git-send-email-shawn.lin@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=adrian.hunter@intel.com \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=soren.brinkmann@xilinx.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).