devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Songjun Wu <songjun.wu@atmel.com>
To: g.liakhovetski@gmx.de, laurent.pinchart@ideasonboard.com,
	nicolas.ferre@atmel.com, robh@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	Songjun Wu <songjun.wu@atmel.com>,
	devicetree@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
	linux-kernel@vger.kernel.org,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>
Subject: [PATCH v3 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver
Date: Tue, 31 May 2016 14:58:23 +0800	[thread overview]
Message-ID: <1464677903-28412-3-git-send-email-songjun.wu@atmel.com> (raw)
In-Reply-To: <1464677903-28412-1-git-send-email-songjun.wu@atmel.com>

DT binding documentation for ISC driver.

Signed-off-by: Songjun Wu <songjun.wu@atmel.com>
---

Changes in v3:
- Remove the 'atmel,sensor-preferred'.
- Modify the isc clock node according to the Rob's remarks.

Changes in v2:
- Remove the unit address of the endpoint.
- Add the unit address to the clock node.
- Avoid using underscores in node names.
- Drop the "0x" in the unit address of the i2c node.
- Modify the description of 'atmel,sensor-preferred'.
- Add the description for the ISC internal clock.

 .../devicetree/bindings/media/atmel-isc.txt        | 88 ++++++++++++++++++++++
 1 file changed, 88 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/atmel-isc.txt

diff --git a/Documentation/devicetree/bindings/media/atmel-isc.txt b/Documentation/devicetree/bindings/media/atmel-isc.txt
new file mode 100644
index 0000000..2ae1d60
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/atmel-isc.txt
@@ -0,0 +1,88 @@
+Atmel Image Sensor Controller (ISC)
+----------------------------------------------
+
+Required properties for ISC:
+- compatible
+	Must be "atmel,sama5d2-isc"
+- reg
+	Physical base address and length of the registers set for the device;
+- interrupts
+	Should contain IRQ line for the ISI;
+- clocks
+	List of clock specifiers, corresponding to entries in
+	the clock-names property;
+	Please refer to clock-bindings.txt.
+- clock-names
+	Required elements: "hclock", "ispck".
+- pinctrl-names, pinctrl-0
+	Please refer to pinctrl-bindings.txt.
+- isc-ispck
+	The clock for the ISC digital pipeline.
+	- compatible
+		Must be "atmel,sama5d2-isc-ispck".
+	- clock-cells
+		From common clock binding; should be set to 0.
+	- clocks
+		The clock source phandles.
+- isc-mck
+	The clock for the image sensor.
+	- compatible
+		Must be "atmel,sama5d2-isc-mck".
+	- clock-cells
+		From common clock binding; should be set to 0.
+	- clocks
+		The clock source phandles.
+
+ISC supports a single port node with parallel bus. It should contain one
+'port' child node with child 'endpoint' node. Please refer to the bindings
+defined in Documentation/devicetree/bindings/media/video-interfaces.txt.
+
+Example:
+isc: isc@f0008000 {
+	compatible = "atmel,sama5d2-isc";
+	reg = <0xf0008000 0x4000>;
+	interrupts = <46 IRQ_TYPE_LEVEL_HIGH 5>;
+	clocks = <&isc_clk>, <&isc_ispck>;
+	clock-names = "hclock", "ispck";
+
+	port {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		isc_0: endpoint {
+			remote-endpoint = <&ov7740_0>;
+			hsync-active = <1>;
+			vsync-active = <0>;
+			pclk-sample = <1>;
+		};
+	};
+
+	isc_ispck: isc-ispck@0 {
+		compatible = "atmel,sama5d2-isc-ispck";
+		#clock-cells = <0>;
+		clocks = <&isc_clk>, <&iscck>;
+	};
+
+	isc_mck: isc-mck@1 {
+		compatible = "atmel,sama5d2-isc-mck";
+		#clock-cells = <0>;
+		clocks = <&isc_clk>, <&iscck>, <&isc_gclk>;
+	};
+};
+
+i2c1: i2c@fc028000 {
+	ov7740: camera@21 {
+	compatible = "ovti,ov7740";
+	reg = <0x21>;
+
+	clocks = <&isc_mck>;
+	clock-names = "xvclk";
+	assigned-clocks = <&isc_mck>;
+	assigned-clock-rates = <24000000>;
+
+	port {
+		ov7740_0: endpoint {
+			remote-endpoint = <&isc_0>;
+		};
+	};
+};
-- 
2.7.4

  reply	other threads:[~2016-05-31  6:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31  6:58 [PATCH v3 0/2] [media] atmel-isc: add driver for Atmel ISC Songjun Wu
2016-05-31  6:58 ` Songjun Wu [this message]
2016-06-02 23:16   ` [PATCH v3 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver Rob Herring
2016-06-03 11:10     ` Boris Brezillon
2016-06-06  6:44       ` Wu, Songjun
2016-06-06  6:42     ` Wu, Songjun
     [not found] ` <1464677903-28412-1-git-send-email-songjun.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2016-05-31  7:17   ` [PATCH v3 0/2] [media] atmel-isc: add driver for Atmel ISC Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464677903-28412-3-git-send-email-songjun.wu@atmel.com \
    --to=songjun.wu@atmel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=g.liakhovetski@gmx.de \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).