From mboxrd@z Thu Jan  1 00:00:00 1970
From: weiqing kong <weiqing.kong@mediatek.com>
Subject: Re: [PATCH 1/3] dt-bindings: pwm: Add MediaTek display PWM bindings
Date: Fri, 3 Jun 2016 14:45:49 +0800
Message-ID: <1464936349.5209.9.camel@mhfsdcap03>
References: <1464597712-5399-1-git-send-email-weiqing.kong@mediatek.com>
	 <1464597712-5399-2-git-send-email-weiqing.kong@mediatek.com>
	 <20160602224550.GA19256@rob-hp-laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20160602224550.GA19256@rob-hp-laptop>
Sender: linux-kernel-owner@vger.kernel.org
To: Rob Herring <robh@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>, Mark Rutland <mark.rutland@arm.com>, Matthias Brugger <matthias.bgg@gmail.com>, Pawel Moll <pawel.moll@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Russell King <linux@arm.linux.org.uk>, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com, Sascha Hauer <kernel@pengutronix.de>, erin.lo@mediatek.com, yingjoe.chen@mediatek.com, eddie.huang@mediatek.com, yh.huang@mediatek.com, yt.shen@mediatek.com
List-Id: devicetree@vger.kernel.org

On Thu, 2016-06-02 at 17:45 -0500, Rob Herring wrote:
> On Mon, May 30, 2016 at 04:41:50PM +0800, Weiqing Kong wrote:
> > Add MT2701 compatible string.
> > 
> > Signed-off-by: Weiqing Kong <weiqing.kong@mediatek.com>
> > ---
> >  Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
> > index f8f59ba..f2f2fa9 100644
> > --- a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
> > +++ b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
> > @@ -1,9 +1,10 @@
> >  MediaTek display PWM controller
> >  
> >  Required properties:
> > - - compatible: should be "mediatek,<name>-disp-pwm":
> > -   - "mediatek,mt8173-disp-pwm": found on mt8173 SoC.
> > + - compatible: should be like these:
> > +   - "mediatek,mt2701-disp-bls": found on mt2701 SoC.
> 
> Why bls instead of pwm?

In mt6595/mt8173, we have a hardware module named pwm.
In mt2701, we have bls hardware module which includes disp pwm function,
so we named it mt2701-disp-bls rather than mt2701-disp-pwm in order to
match with hardware spec.
thanks.

> 
> >     - "mediatek,mt6595-disp-pwm": found on mt6595 SoC.
> > +   - "mediatek,mt8173-disp-pwm": found on mt8173 SoC.
> >   - reg: physical base address and length of the controller's registers.
> >   - #pwm-cells: must be 2. See pwm.txt in this directory for a description of
> >     the cell format.
> > -- 
> > 1.8.1.1.dirty
> >