[RESEND PATCH 0/2] arm64: dts: r8a7795: Add FCPF and FDP1 device nodes

[RESEND PATCH 0/2] arm64: dts: r8a7795: Add FCPF and FDP1 device nodes

[Kieran Bingham]

Appologies for the resend, I very cleverly sent this cover letter detailing the
dependencies only to my e-mail address. And I already know the dependencies!

Following two patches are the same, sorry for the noise.

These are dependent upon the FCP bindings from Laurent [0], and the FCPF
update to those bindings from me [1], and of course the bindings for the
FDP1 [2] which are all posted separately.

[0] http://www.spinics.net/lists/devicetree/msg123968.html
[1] https://lkml.org/lkml/2016/6/9/291
[2] https://lkml.org/lkml/2016/6/9/294

Kieran Bingham (2):
  arm64: dts: r8a7795: add FCPF device nodes
  arm64: dts: r8a7795: add FDP1 device nodes

 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 48 ++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

-- 
2.7.4

[PATCH 1/2] arm64: dts: r8a7795: add FCPF device nodes

[Kieran Bingham]

Provide nodes for the FCP devices dedicated to the FDP device channels.

Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 3285a9286786..e63e5f29cceb 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -1223,5 +1223,26 @@
 			power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
 			status = "disabled";
 		};
+
+		fcpf0: fcp@fe950000 {
+			compatible = "renesas,r8a7795-fcpf", "renesas,fcpf";
+			reg = <0 0xfe950000 0 0x200>;
+			clocks = <&cpg CPG_MOD 615>;
+			power-domains = <&sysc R8A7795_PD_A3VP>;
+		};
+
+		fcpf1: fcp@fe951000 {
+			compatible = "renesas,r8a7795-fcpf", "renesas,fcpf";
+			reg = <0 0xfe951000 0 0x200>;
+			clocks = <&cpg CPG_MOD 614>;
+			power-domains = <&sysc R8A7795_PD_A3VP>;
+		};
+
+		fcpf2: fcp@fe952000 {
+			compatible = "renesas,r8a7795-fcpf", "renesas,fcpf";
+			reg = <0 0xfe952000 0 0x200>;
+			clocks = <&cpg CPG_MOD 613>;
+			power-domains = <&sysc R8A7795_PD_A3VP>;
+		};
 	};
 };
-- 
2.7.4

Re: [PATCH 1/2] arm64: dts: r8a7795: add FCPF device nodes

[Geert Uytterhoeven]

On Thu, Jun 9, 2016 at 6:56 PM, Kieran Bingham <kieran-7hKh/agyDeatmTQ+vhA3Yw@public.gmane.org> wrote:
> Provide nodes for the FCP devices dedicated to the FDP device channels.
>
> Signed-off-by: Kieran Bingham <kieran-SI8QzZ7I9JUn3X9lZQuFcg@public.gmane.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] arm64: dts: r8a7795: add FDP1 device nodes

[Kieran Bingham]

Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index e63e5f29cceb..0c0aa14f7f4d 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -1244,5 +1244,32 @@
 			clocks = <&cpg CPG_MOD 613>;
 			power-domains = <&sysc R8A7795_PD_A3VP>;
 		};
+
+		fdp1ch1: fdp1@fe940000 {
+			compatible = "renesas,r8a7795-fdp1", "renesas,fdp1";
+			reg = <0 0xfe940000 0 0x2400>;
+			interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 119>;
+			power-domains = <&sysc R8A7795_PD_A3VP>;
+			renesas,fcp = <&fcpf0>;
+		};
+
+		fdp1ch2: fdp1@fe944000 {
+			compatible = "renesas,r8a7795-fdp1", "renesas,fdp1";
+			reg = <0 0xfe944000 0 0x2400>;
+			interrupts = <GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 118>;
+			power-domains = <&sysc R8A7795_PD_A3VP>;
+			renesas,fcp = <&fcpf1>;
+		};
+
+		fdp1ch3: fdp1@fe948000 {
+			compatible = "renesas,r8a7795-fdp1", "renesas,fdp1";
+			reg = <0 0xfe948000 0 0x2400>;
+			interrupts = <GIC_SPI 264 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 117>;
+			power-domains = <&sysc R8A7795_PD_A3VP>;
+			renesas,fcp = <&fcpf2>;
+		};
 	};
 };
-- 
2.7.4

Re: [PATCH 2/2] arm64: dts: r8a7795: add FDP1 device nodes

[Geert Uytterhoeven]

On Thu, Jun 9, 2016 at 6:56 PM, Kieran Bingham <kieran@ksquared.org.uk> wrote:
> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [RESEND PATCH 0/2] arm64: dts: r8a7795: Add FCPF and FDP1 device nodes

[Simon Horman]

On Thu, Jun 09, 2016 at 05:56:56PM +0100, Kieran Bingham wrote:
> Appologies for the resend, I very cleverly sent this cover letter detailing the
> dependencies only to my e-mail address. And I already know the dependencies!
> 
> Following two patches are the same, sorry for the noise.
> 
> These are dependent upon the FCP bindings from Laurent [0], and the FCPF
> update to those bindings from me [1], and of course the bindings for the
> FDP1 [2] which are all posted separately.
> 
> [0] http://www.spinics.net/lists/devicetree/msg123968.html
> [1] https://lkml.org/lkml/2016/6/9/291
> [2] https://lkml.org/lkml/2016/6/9/294

These patches look good to me. My assumption is that they
can be applied without causing any breakage and that the
relevant features will start working once driver support
shows up in the kernel.

If the above assumption is correct then please let me know when the
bindings have been accepted by the relevant subsystem maintainer(s).

If the patches need rebasing at that time then please repost them.
Otherwise you can either repost them or ping me as a response to this thread.

Thanks!

[PATCH v2 0/2] arm64: dts: r8a7795: FCPF and FDP1 device nodes

[Kieran Bingham]

Hi Simon,

Here is my updated series for the dts updates in relation to the RCar/FDP1.

The fcpf patch has collected a reviewed-by from Geert, whilst the fdp1
patch has collected a reviewed by from both Laurent and Geert, with a
small change to remove the labels, as they will not be referenced.

You responded to my previous set for these with the following comment:

> These patches look good to me. My assumption is that they
> can be applied without causing any breakage and that the
> relevant features will start working once driver support
> shows up in the kernel.
> 
> If the above assumption is correct then please let me know when the
> bindings have been accepted by the relevant subsystem maintainer(s).
> 
> If the patches need rebasing at that time then please repost them.
> Otherwise you can either repost them or ping me as a response to this thread.

Your assumption was correct, and they could be applied without breakage.

RobH has acked the binding for the RCar FCPF, but I have not seen an ack for
the FDP1 binding yet. I'll follow that up, and ping you on the fdp1 dts patch
when it resolved.

Regards

Kieran

--

Kieran Bingham (2):
  arm64: dts: r8a7795: add FCPF device nodes
  arm64: dts: r8a7795: add FDP1 device nodes

 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 48 ++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

-- 
2.7.4

[PATCH 2/2] arm64: dts: r8a7795: add FDP1 device nodes

[Kieran Bingham]

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
--
changes for v2
 - channel labels dropped

 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index a451bd217f05..8bc87e09efd7 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -1443,5 +1443,32 @@
 			clocks = <&cpg CPG_MOD 613>;
 			power-domains = <&sysc R8A7795_PD_A3VP>;
 		};
+
+		fdp1@fe940000 {
+			compatible = "renesas,fdp1";
+			reg = <0 0xfe940000 0 0x2400>;
+			interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 119>;
+			power-domains = <&sysc R8A7795_PD_A3VP>;
+			renesas,fcp = <&fcpf0>;
+		};
+
+		fdp1@fe944000 {
+			compatible = "renesas,fdp1";
+			reg = <0 0xfe944000 0 0x2400>;
+			interrupts = <GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 118>;
+			power-domains = <&sysc R8A7795_PD_A3VP>;
+			renesas,fcp = <&fcpf1>;
+		};
+
+		fdp1@fe948000 {
+			compatible = "renesas,fdp1";
+			reg = <0 0xfe948000 0 0x2400>;
+			interrupts = <GIC_SPI 264 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 117>;
+			power-domains = <&sysc R8A7795_PD_A3VP>;
+			renesas,fcp = <&fcpf2>;
+		};
 	};
 };
-- 
2.7.4

Re: [PATCH 2/2] arm64: dts: r8a7795: add FDP1 device nodes

[Kieran Bingham]

Hi Simon,

The bindings for this have now been acked by RobH.

--
Cheers

Kieran

On 30/06/16 14:32, Kieran Bingham wrote:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
> --
> changes for v2
>  - channel labels dropped
> 
>  arch/arm64/boot/dts/renesas/r8a7795.dtsi | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> index a451bd217f05..8bc87e09efd7 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -1443,5 +1443,32 @@
>  			clocks = <&cpg CPG_MOD 613>;
>  			power-domains = <&sysc R8A7795_PD_A3VP>;
>  		};
> +
> +		fdp1@fe940000 {
> +			compatible = "renesas,fdp1";
> +			reg = <0 0xfe940000 0 0x2400>;
> +			interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 119>;
> +			power-domains = <&sysc R8A7795_PD_A3VP>;
> +			renesas,fcp = <&fcpf0>;
> +		};
> +
> +		fdp1@fe944000 {
> +			compatible = "renesas,fdp1";
> +			reg = <0 0xfe944000 0 0x2400>;
> +			interrupts = <GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 118>;
> +			power-domains = <&sysc R8A7795_PD_A3VP>;
> +			renesas,fcp = <&fcpf1>;
> +		};
> +
> +		fdp1@fe948000 {
> +			compatible = "renesas,fdp1";
> +			reg = <0 0xfe948000 0 0x2400>;
> +			interrupts = <GIC_SPI 264 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 117>;
> +			power-domains = <&sysc R8A7795_PD_A3VP>;
> +			renesas,fcp = <&fcpf2>;
> +		};
>  	};
>  };
> 

Re: [PATCH 2/2] arm64: dts: r8a7795: add FDP1 device nodes

[Simon Horman]

On Fri, Jul 01, 2016 at 03:37:23PM +0100, Kieran Bingham wrote:
> Hi Simon,
> 
> The bindings for this have now been acked by RobH.

Thanks, I have queued these up for v4.9.

There was a small amount of fuzz when applying the first patch,
please check to make sure it has been applied correctly once
it hits the devel branch of the renesas tree.

[PATCH 2/2] arm64: dts: r8a7795: add FDP1 device nodes

[Kieran Bingham]

Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index e63e5f29cceb..0c0aa14f7f4d 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -1244,5 +1244,32 @@
 			clocks = <&cpg CPG_MOD 613>;
 			power-domains = <&sysc R8A7795_PD_A3VP>;
 		};
+
+		fdp1ch1: fdp1@fe940000 {
+			compatible = "renesas,r8a7795-fdp1", "renesas,fdp1";
+			reg = <0 0xfe940000 0 0x2400>;
+			interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 119>;
+			power-domains = <&sysc R8A7795_PD_A3VP>;
+			renesas,fcp = <&fcpf0>;
+		};
+
+		fdp1ch2: fdp1@fe944000 {
+			compatible = "renesas,r8a7795-fdp1", "renesas,fdp1";
+			reg = <0 0xfe944000 0 0x2400>;
+			interrupts = <GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 118>;
+			power-domains = <&sysc R8A7795_PD_A3VP>;
+			renesas,fcp = <&fcpf1>;
+		};
+
+		fdp1ch3: fdp1@fe948000 {
+			compatible = "renesas,r8a7795-fdp1", "renesas,fdp1";
+			reg = <0 0xfe948000 0 0x2400>;
+			interrupts = <GIC_SPI 264 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 117>;
+			power-domains = <&sysc R8A7795_PD_A3VP>;
+			renesas,fcp = <&fcpf2>;
+		};
 	};
 };
-- 
2.7.4