From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Ianovich Subject: Re: [PATCH v2 1/2] rtc: ds1302: add register access abstraction layer Date: Mon, 27 Jun 2016 14:50:49 +0300 Message-ID: <1467028249.3182.11.camel@gmail.com> References: <1467026362-29446-1-git-send-email-akinobu.mita@gmail.com> <1467026362-29446-2-git-send-email-akinobu.mita@gmail.com> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <1467026362-29446-2-git-send-email-akinobu.mita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Akinobu Mita , rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Alessandro Zummo , Alexandre Belloni List-Id: devicetree@vger.kernel.org On Mon, 2016-06-27 at 20:19 +0900, Akinobu Mita wrote: > The rtc-ds1302 driver now implemented using SPI 3wire mode. > But I would like to access it with using three wires connected to > GPIO > lines. >=20 > This adds abstraction layer for DS1302 register access in order to > prepare to support for using GPIO lines.=C2=A0=C2=A0This enables to share > common > code between SPI driver and GPIO driver. I don't think this is the right way. DS-1302 is an SPI device, not a GPIO one. It can be connected to a hardware SPI controller or a software one (on top of GPIO or memory). Your patch re-adds Microwire SPI control logic to RTC subsystem, which was cleared by my rewrite of drivers/rtc/rtc-ds1302.c. The logic is already present in=C2=A0bitbang_txrx_be_cpha0_lsb() in=C2=A0drivers/spi/spi= - lp8841-rtc.c. I still think you need to implement=C2=A0spi-gpio-3wire with LSB-first support in SPI subsystem instead. It wasn't done when I was adding LP8841 support, because LP8841 was the only use case of Microwire SPI control logic. If you add it, drivers/spi/spi-lp8841-rtc.c can be removed and replaced by a GPIO driver to host a new spi-gpio-3wire device. --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.