* [PATCH] ARM: dts: imx: ventana: add RS485 txen gpio support
@ 2016-06-29 13:38 Tim Harvey
[not found] ` <1467207504-5218-1-git-send-email-tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Tim Harvey @ 2016-06-29 13:38 UTC (permalink / raw)
To: shawnguo-DgEjT+Ai2ygdnm+yROfE0A
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA
The GW54xx, GW53xx, and GW52xx all have an RS485 transceiver that uses an
IMX GPIO for the TX enable of the transceiver. Declare this properly.
Signed-off-by: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
---
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 3 +++
arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 3 +++
arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 3 +++
3 files changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
index 8bf1020..25ed57d 100644
--- a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
@@ -315,6 +315,8 @@
&uart1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart1>;
+ fsl,uart-has-rtscts;
+ rts-gpio = <&gpio7 1 GPIO_ACTIVE_HIGH>;
status = "okay";
};
@@ -493,6 +495,7 @@
fsl,pins = <
MX6QDL_PAD_SD3_DAT7__UART1_TX_DATA 0x1b0b1
MX6QDL_PAD_SD3_DAT6__UART1_RX_DATA 0x1b0b1
+ MX6QDL_PAD_SD3_DAT4__GPIO7_IO01 0x4001b0b1 /* TEN */
>;
};
diff --git a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
index e5f4b6c..69e21b9 100644
--- a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
@@ -311,6 +311,8 @@
&uart1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart1>;
+ fsl,uart-has-rtscts;
+ rts-gpio = <&gpio7 1 GPIO_ACTIVE_HIGH>;
status = "okay";
};
@@ -481,6 +483,7 @@
fsl,pins = <
MX6QDL_PAD_SD3_DAT7__UART1_TX_DATA 0x1b0b1
MX6QDL_PAD_SD3_DAT6__UART1_RX_DATA 0x1b0b1
+ MX6QDL_PAD_SD3_DAT4__GPIO7_IO01 0x4001b0b1 /* TEN */
>;
};
diff --git a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
index 5a8dbab..b602e2a 100644
--- a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
@@ -414,6 +414,8 @@
&uart1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart1>;
+ fsl,uart-has-rtscts;
+ rts-gpio = <&gpio7 1 GPIO_ACTIVE_HIGH>;
status = "okay";
};
@@ -603,6 +605,7 @@
fsl,pins = <
MX6QDL_PAD_SD3_DAT7__UART1_TX_DATA 0x1b0b1
MX6QDL_PAD_SD3_DAT6__UART1_RX_DATA 0x1b0b1
+ MX6QDL_PAD_SD3_DAT4__GPIO7_IO01 0x4001b0b1 /* TEN */
>;
};
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread[parent not found: <1467207504-5218-1-git-send-email-tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>]
* Re: [PATCH] ARM: dts: imx: ventana: add RS485 txen gpio support [not found] ` <1467207504-5218-1-git-send-email-tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org> @ 2016-08-08 8:40 ` Shawn Guo 2016-08-09 19:08 ` Tim Harvey 2016-08-09 19:18 ` [PATCH v2] " Tim Harvey 1 sibling, 1 reply; 5+ messages in thread From: Shawn Guo @ 2016-08-08 8:40 UTC (permalink / raw) To: Tim Harvey Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Wed, Jun 29, 2016 at 06:38:24AM -0700, Tim Harvey wrote: > The GW54xx, GW53xx, and GW52xx all have an RS485 transceiver that uses an > IMX GPIO for the TX enable of the transceiver. Declare this properly. > > Signed-off-by: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org> > --- > arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 3 +++ > arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 3 +++ > arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 3 +++ > 3 files changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi > index 8bf1020..25ed57d 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi > @@ -315,6 +315,8 @@ > &uart1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_uart1>; > + fsl,uart-has-rtscts; This vendor specific property is deprecated. Please use generic uart-has-rtscts instead. > + rts-gpio = <&gpio7 1 GPIO_ACTIVE_HIGH>; I cannot find this property in any bindings doc. What I found is rts-gpios in bindings/serial/serial.txt. Also, I'm not sure how this property is supported by IMX driver. Shawn > status = "okay"; > }; > > @@ -493,6 +495,7 @@ > fsl,pins = < > MX6QDL_PAD_SD3_DAT7__UART1_TX_DATA 0x1b0b1 > MX6QDL_PAD_SD3_DAT6__UART1_RX_DATA 0x1b0b1 > + MX6QDL_PAD_SD3_DAT4__GPIO7_IO01 0x4001b0b1 /* TEN */ > >; > }; > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: imx: ventana: add RS485 txen gpio support 2016-08-08 8:40 ` Shawn Guo @ 2016-08-09 19:08 ` Tim Harvey 0 siblings, 0 replies; 5+ messages in thread From: Tim Harvey @ 2016-08-09 19:08 UTC (permalink / raw) To: Shawn Guo Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org On Mon, Aug 8, 2016 at 1:40 AM, Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > On Wed, Jun 29, 2016 at 06:38:24AM -0700, Tim Harvey wrote: >> The GW54xx, GW53xx, and GW52xx all have an RS485 transceiver that uses an >> IMX GPIO for the TX enable of the transceiver. Declare this properly. >> >> Signed-off-by: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org> >> --- >> arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 3 +++ >> arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 3 +++ >> arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 3 +++ >> 3 files changed, 9 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi >> index 8bf1020..25ed57d 100644 >> --- a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi >> +++ b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi >> @@ -315,6 +315,8 @@ >> &uart1 { >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_uart1>; >> + fsl,uart-has-rtscts; > > This vendor specific property is deprecated. Please use generic > uart-has-rtscts instead. > ok - will do for v2 >> + rts-gpio = <&gpio7 1 GPIO_ACTIVE_HIGH>; > > I cannot find this property in any bindings doc. What I found is > rts-gpios in bindings/serial/serial.txt. Also, I'm not sure how this > property is supported by IMX driver. > This is supported by serial_mctrl_gpio (drivers/tty/serial/serial_mctrl_gpio.c) and the IMX serial driver does support mctrl-gpio. The serial_mctrl_gpio driver calls devm_gpiod_get_index_optional for pin names of cts,dsr,dcd,rng,rts, and dtr. This ends up calling 'of_find_gpio' for these names which looks for them based on 'gpio_suffixes' which is defined as { "gpios", "gpio" } so that plural or singular is supported. Its not documented that gpio specifies can be singular in Documentation/devicetree/bindings/serial/serial.txt but I always hate seeing gpio properties named '*-gpios' that only specify a single gpio so I figured I would use the singular representation. Because this is not clear in the documentation and there is only one other board using 'rts-gpio' (am335x-nano.dts) vs 'rts-gpios' I will go ahead and change it for v2 to be more consistent. Regards, Tim -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ARM: dts: imx: ventana: add RS485 txen gpio support [not found] ` <1467207504-5218-1-git-send-email-tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org> 2016-08-08 8:40 ` Shawn Guo @ 2016-08-09 19:18 ` Tim Harvey [not found] ` <1470770329-25395-1-git-send-email-tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org> 1 sibling, 1 reply; 5+ messages in thread From: Tim Harvey @ 2016-08-09 19:18 UTC (permalink / raw) To: shawnguo-DgEjT+Ai2ygdnm+yROfE0A Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA Signed-off-by: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org> --- v2: - replace remove vendor specific property with generic property - replace rts-gpio with rts-gpios to match devicetree binding documentation (although both suffixes are supported) Signed-off-by: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org> --- arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 3 +++ arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 3 +++ arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 3 +++ 3 files changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi index 208e3c2..a7100f9 100644 --- a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi +++ b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi @@ -315,6 +315,8 @@ &uart1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart1>; + uart-has-rtscts; + rts-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>; status = "okay"; }; @@ -493,6 +495,7 @@ fsl,pins = < MX6QDL_PAD_SD3_DAT7__UART1_TX_DATA 0x1b0b1 MX6QDL_PAD_SD3_DAT6__UART1_RX_DATA 0x1b0b1 + MX6QDL_PAD_SD3_DAT4__GPIO7_IO01 0x4001b0b1 /* TEN */ >; }; diff --git a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi index 35b9e80..8953eba 100644 --- a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi +++ b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi @@ -312,6 +312,8 @@ &uart1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart1>; + uart-has-rtscts; + rts-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>; status = "okay"; }; @@ -482,6 +484,7 @@ fsl,pins = < MX6QDL_PAD_SD3_DAT7__UART1_TX_DATA 0x1b0b1 MX6QDL_PAD_SD3_DAT6__UART1_RX_DATA 0x1b0b1 + MX6QDL_PAD_SD3_DAT4__GPIO7_IO01 0x4001b0b1 /* TEN */ >; }; diff --git a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi index 5f8f1ea..6ac41c7 100644 --- a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi +++ b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi @@ -414,6 +414,8 @@ &uart1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart1>; + uart-has-rtscts; + rts-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>; status = "okay"; }; @@ -603,6 +605,7 @@ fsl,pins = < MX6QDL_PAD_SD3_DAT7__UART1_TX_DATA 0x1b0b1 MX6QDL_PAD_SD3_DAT6__UART1_RX_DATA 0x1b0b1 + MX6QDL_PAD_SD3_DAT4__GPIO7_IO01 0x4001b0b1 /* TEN */ >; }; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 5+ messages in thread
[parent not found: <1470770329-25395-1-git-send-email-tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>]
* Re: [PATCH v2] ARM: dts: imx: ventana: add RS485 txen gpio support [not found] ` <1470770329-25395-1-git-send-email-tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org> @ 2016-08-15 12:16 ` Shawn Guo 0 siblings, 0 replies; 5+ messages in thread From: Shawn Guo @ 2016-08-15 12:16 UTC (permalink / raw) To: Tim Harvey Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Tue, Aug 09, 2016 at 12:18:49PM -0700, Tim Harvey wrote: > Signed-off-by: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org> > --- > v2: > - replace remove vendor specific property with generic property > - replace rts-gpio with rts-gpios to match devicetree binding documentation > (although both suffixes are supported) > > Signed-off-by: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-15 12:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-29 13:38 [PATCH] ARM: dts: imx: ventana: add RS485 txen gpio support Tim Harvey
[not found] ` <1467207504-5218-1-git-send-email-tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
2016-08-08 8:40 ` Shawn Guo
2016-08-09 19:08 ` Tim Harvey
2016-08-09 19:18 ` [PATCH v2] " Tim Harvey
[not found] ` <1470770329-25395-1-git-send-email-tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
2016-08-15 12:16 ` Shawn Guo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).