Re: [PATCH net-next v13 0/3] add hisilicon hip04 ethernet driver

Arnd Bergmann
2015-01-15T09:42:17Z

On Thursday 15 January 2015 16:37:23 Ding Tianhong wrote:
> On 2015/1/14 18:19, Alexander Graf wrote:
> >
> >>From a 10000 feet perspective it looks like two problems to me
> >
> > 1) Allocation failure doesn't get handled properly somewhere

This is the bug that Eric pointed out as well.

> > 2) We fail to allocate with order=0 - I don't see why

GFP_ATOMIC. When allocating from a the napi poll function in softirq
context, you have to use nonblocking allocations, which occasionally
fail. This should not cause any harm other than dropped packets.

> is it easy to repetition this bug? how big is your memory on your board,
> is it happened in your previous hip04 driver?

It should be independent of memory size, but may be more likely if you
don't have swap space configured.

Arnd