Re: [PATCH 1/2] dt-bindings: tc358767: add DT documentation

[Philipp Zabel <p.zabel@pengutronix.de>]

Hi Archit,

thank you for the comments.

Am Dienstag, den 05.07.2016, 08:53 +0530 schrieb Archit Taneja:
[...]
> > +Required properties:
> > + - compatible: "toshiba,tc358767"
> > + - reg: i2c address of the bridge, 0x68 or 0x0f, depending on bootstrap pins
> > + - clock-names: should be "ref"
> > + - clocks: OF device-tree clock specification for refclk input. The reference
> 
> Should we have this as an optional property? There could be platforms
> where an oscillator output on the board connects directly to the refclk
> pin, without any option to gate it.

As you said in the other mail, we need to know the refclk frequency. A
fixed-clock should be used to describe the oscillator in this case.

> > +   clock rate must be 13 MHz, 19.2 MHz, 26 MHz, or 38.4 MHz.
> > +
> > +Optional properties:
> > + - shutdown-gpios: OF device-tree gpio specification for SD pin
> > +                   (active high shutdown input)
> > + - reset-gpios: OF device-tree gpio specification for RSTX pin
> > +                (active low system reset)
> > + - ports: the ports node can contain video interface port nodes to connect
> > +   to a DPI/DSI source and to an eDP/DP sink according to [1][2].
> 
> Just wondering about the future when DSI is implemented. Would we have
> different port numbers for DSI and DPI? And figure whether the input
> is DSI or DPI based on input the port number? If we go with that
> approach, it might make sense to have the bridge output port number
> as 2.

Good point, these are physically two separate ports and it should be
possible to switch between them at runtime in theory. Since the DSI is
listed first in the documentation, I'll change it to
 - port@0: MIPI DSI Rx
 - port@1: DPI Rx
 - port@2: (e)DP Tx

regards
Philipp

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel