From mboxrd@z Thu Jan 1 00:00:00 1970 From: stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Subject: Re: [PATCH v11 4/6] ARM: dts: imx6q-evi: support altera-ps-spi Date: Fri, 02 Jun 2017 14:10:17 -0700 Message-ID: <14677930.o4g43KgmZP@jclayton-pc> References: <20170525172911.11467-1-stillcompiling@gmail.com> <6513199.IxvCuS6eYj@jclayton-pc> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andreas =?ISO-8859-1?Q?F=E4rber?= Cc: stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Rob Herring , Alan Tull , Moritz Fischer , Anatolij Gustschin , Bastian Stender , Shawn Guo , Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sascha Hauer , Fabio Estevam , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Friday, June 2, 2017 9:54:22 PM PDT Andreas F=E4rber wrote: > Am 02.06.2017 um 21:39 schrieb stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org: > > On Friday, June 2, 2017 6:30:12 PM PDT Andreas F=E4rber wrote: > >> Am 25.05.2017 um 19:29 schrieb Joshua Clayton: > >>> diff --git a/arch/arm/boot/dts/imx6q-evi.dts > >>> b/arch/arm/boot/dts/imx6q-evi.dts index 24fe093a66db..a0cbb2d84803 > >>> 100644 > >>> --- a/arch/arm/boot/dts/imx6q-evi.dts > >>> +++ b/arch/arm/boot/dts/imx6q-evi.dts > >>> @@ -82,6 +82,15 @@ > >>>=20 > >>> pinctrl-names =3D "default"; > >>> pinctrl-0 =3D <&pinctrl_ecspi1 &pinctrl_ecspi1cs>; > >>> status =3D "okay"; > >>>=20 > >>> + > >>> + fpga_spi: cyclonespi@0 { > >>=20 > >> "cyclonespi" does not strike me as the best node name. > >>=20 > >> I am guessing this is a sub-node of a SPI controller node, so no need = to > >> repeat "spi", and Cyclone seems more or less implied by "altr,fpga-". > >=20 > > True. > >=20 > >> Note that the example in the bindings doc uses "evi-fpga-spi". Nodes > >> don't need to be (shouldn't be?) prefixed with the board. Note that > >> bindings examples tend to get copied a lot. > >>=20 > >> Any reason not to just use "fpga@0" in both places for simplicity? > >=20 > > Sure. fpga: fpga@0 is probably better. >=20 > Note that I was only commenting on the node name, the latter part. >=20 > I'm not aware of any rules for the label, so that could remain unchanged > or adopt cyclone_spi from the old node name or whatever is unique and > syntactically valid. Too late! Patches posted. Oh, well, I'm not changing it back. >=20 > > I'll change it in both the dts and the binding doc. >=20 > Thanks. Maybe double-check if there's any conventions Xilinx/Lattice DTs > are using. >=20 Of the conventions I found, fpga seemed the most "hardware descriptive" for a plain FPGA. The other one several binding doc examples are using is "fpga-mgr". > Cheers, > Andreas =2D-=20 ~Joshua A Clayton -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html