From: Philipp Zabel <p.zabel@pengutronix.de>
To: Archit Taneja <architt@codeaurora.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Andrey Gusakov <andrey.gusakov@cogentembedded.com>,
dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>,
Chris Healy <Chris.Healy@zii.aero>,
Kumar Gala <galak@codeaurora.org>,
Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH 2/2] drm/bridge: tc358767: Add DPI to eDP bridge driver
Date: Mon, 11 Jul 2016 10:44:15 +0200 [thread overview]
Message-ID: <1468226655.3048.2.camel@pengutronix.de> (raw)
In-Reply-To: <57835993.4020709@codeaurora.org>
Am Montag, den 11.07.2016, 14:02 +0530 schrieb Archit Taneja:
[...]
> >>> + /* PXL PLL setup */
> >>> + if (tc->test_pattern) {
> >>
> >> I couldn't find out who is setting tc->test_pattern. Is it always
> >> 0?
> >
> > Hm, you are right. I wonder what a good mechanism would be to enable a
> > test pattern for a bridge driver. Module parameters? We don't have
> > anyhting like V4L2_CID_TEST_PATTERN in drm. I could also drop test
> > pattern support from the initial patch and submit it separately.
>
> Module parameter sounds like a good option.
Ok.
> Although, it seems like the pll is enabled only when test_pattern is
> set. How does the bridge work if the pll isn't enabled?
The PXL PLL is only necessary regenerate the pixel clock from the DSI HS
clock, or to create the test pattern. In DPI mode the pixel clock from
the parallel interface is used directly.
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-07-11 8:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 14:50 [PATCH 0/2] Toshiba TC358767 eDP bridge driver Philipp Zabel
[not found] ` <1467384610-29908-1-git-send-email-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-07-01 14:50 ` [PATCH 1/2] dt-bindings: tc358767: add DT documentation Philipp Zabel
2016-07-05 3:23 ` Archit Taneja
2016-07-05 7:59 ` Philipp Zabel
2016-07-01 14:50 ` [PATCH 2/2] drm/bridge: tc358767: Add DPI to eDP bridge driver Philipp Zabel
2016-07-05 4:38 ` Archit Taneja
2016-07-05 8:00 ` Philipp Zabel
2016-07-11 8:32 ` Archit Taneja
2016-07-11 8:44 ` Philipp Zabel [this message]
2016-07-11 8:46 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468226655.3048.2.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=Chris.Healy@zii.aero \
--cc=andrey.gusakov@cogentembedded.com \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).