From: zhiyong tao <zhiyong.tao@mediatek.com>
To: robh+dt@kernel.org
Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, srv_heupstream@mediatek.com,
liguo.zhang@mediatek.com, yingjoe.chen@mediatek.com,
eddie.huang@mediatek.com, erin.lo@mediatek.com,
dawei.chien@mediatek.com, matthias.bgg@gmail.com,
s.hauer@pengutronix.de, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v4 1/3] dt-bindings: auxadc: Add binding document for Mediatek auxadc.
Date: Tue, 12 Jul 2016 10:43:16 +0800 [thread overview]
Message-ID: <1468291396.419.15.camel@mhfsdcap03> (raw)
In-Reply-To: <1468219197-9572-2-git-send-email-zhiyong.tao@mediatek.com>
On Mon, 2016-07-11 at 14:39 +0800, Zhiyong Tao wrote:
> The commit adds the device tree binding documentation for the mediatek
> auxadc found on Mediatek MT2701.
> Thermal gets auxadc sample data by iio device.
> So the commit changes auxadc device tree binding documentation from
> /soc/mediatek/auxadc.txt to /iio/adc/mt6577_auxadc.txt.
>
> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> ---
I forgot that I should use the command 'git format-patch -M' to submit
this patch. The follow information is the patch after executing the
above command. If the patch needs to be resent, please help to notify
me. I will resend the patch quickly.
The follow information:
.../auxadc.txt => iio/adc/mt6577_auxadc.txt} | 16
+++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
rename Documentation/devicetree/bindings/{soc/mediatek/auxadc.txt =>
iio/adc/mt6577_auxadc.txt} (50%)
diff --git a/Documentation/devicetree/bindings/soc/mediatek/auxadc.txt
b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
similarity index 50%
rename from Documentation/devicetree/bindings/soc/mediatek/auxadc.txt
rename to Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
index bdb7829..bc23792 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/auxadc.txt
+++ b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
@@ -1,4 +1,4 @@
-MediaTek AUXADC
+* Mediatek AUXADC - Analog to Digital Converter on Mediatek mobile soc
(mt65xx/mt81xx/mt27xx)
===============
The Auxiliary Analog/Digital Converter (AUXADC) is an ADC found
@@ -10,12 +10,18 @@
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
for the Thermal Controller which holds a phandle to the AUXADC.
Required properties:
-- compatible: Must be "mediatek,mt8173-auxadc"
-- reg: Address range of the AUXADC unit
+ - compatible: "mediatek,mt2701-auxadc" or "mediatek,mt8173-auxadc"
+ - reg: Address range of the AUXADC unit.
+ - clocks: Should contain a clock specifier for each entry in
clock-names
+ - clock-names: Should contain "main".
+ - #io-channel-cells: Should be 1, see ../iio-bindings.txt
Example:
-auxadc: auxadc@11001000 {
- compatible = "mediatek,mt8173-auxadc";
+auxadc: adc@11001000 {
+ compatible = "mediatek,mt2701-auxadc";
reg = <0 0x11001000 0 0x1000>;
+ clocks = <&pericfg CLK_PERI_AUXADC>;
+ clock-names = "main";
+ #io-channel-cells = <1>;
};
--
1.7.9.5
> .../devicetree/bindings/iio/adc/mt6577_auxadc.txt | 27 ++++++++++++++++++++
> .../devicetree/bindings/soc/mediatek/auxadc.txt | 21 ---------------
> 2 files changed, 27 insertions(+), 21 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> delete mode 100644 Documentation/devicetree/bindings/soc/mediatek/auxadc.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> new file mode 100644
> index 0000000..bc23792
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> @@ -0,0 +1,27 @@
> +* Mediatek AUXADC - Analog to Digital Converter on Mediatek mobile soc (mt65xx/mt81xx/mt27xx)
> +===============
> +
> +The Auxiliary Analog/Digital Converter (AUXADC) is an ADC found
> +in some Mediatek SoCs which among other things measures the temperatures
> +in the SoC. It can be used directly with register accesses, but it is also
> +used by thermal controller which reads the temperatures from the AUXADC
> +directly via its own bus interface. See
> +Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> +for the Thermal Controller which holds a phandle to the AUXADC.
> +
> +Required properties:
> + - compatible: "mediatek,mt2701-auxadc" or "mediatek,mt8173-auxadc"
> + - reg: Address range of the AUXADC unit.
> + - clocks: Should contain a clock specifier for each entry in clock-names
> + - clock-names: Should contain "main".
> + - #io-channel-cells: Should be 1, see ../iio-bindings.txt
> +
> +Example:
> +
> +auxadc: adc@11001000 {
> + compatible = "mediatek,mt2701-auxadc";
> + reg = <0 0x11001000 0 0x1000>;
> + clocks = <&pericfg CLK_PERI_AUXADC>;
> + clock-names = "main";
> + #io-channel-cells = <1>;
> +};
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/auxadc.txt b/Documentation/devicetree/bindings/soc/mediatek/auxadc.txt
> deleted file mode 100644
> index bdb7829..0000000
> --- a/Documentation/devicetree/bindings/soc/mediatek/auxadc.txt
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -MediaTek AUXADC
> -===============
> -
> -The Auxiliary Analog/Digital Converter (AUXADC) is an ADC found
> -in some Mediatek SoCs which among other things measures the temperatures
> -in the SoC. It can be used directly with register accesses, but it is also
> -used by thermal controller which reads the temperatures from the AUXADC
> -directly via its own bus interface. See
> -Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> -for the Thermal Controller which holds a phandle to the AUXADC.
> -
> -Required properties:
> -- compatible: Must be "mediatek,mt8173-auxadc"
> -- reg: Address range of the AUXADC unit
> -
> -Example:
> -
> -auxadc: auxadc@11001000 {
> - compatible = "mediatek,mt8173-auxadc";
> - reg = <0 0x11001000 0 0x1000>;
> -};
next prev parent reply other threads:[~2016-07-12 2:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 6:39 [PATCH v4 0/3] AUXADC: Mediatek auxadc driver Zhiyong Tao
2016-07-11 6:39 ` [PATCH v4 1/3] dt-bindings: auxadc: Add binding document for Mediatek auxadc Zhiyong Tao
2016-07-12 2:43 ` zhiyong tao [this message]
2016-07-16 19:31 ` Rob Herring
[not found] ` <1468219197-9572-1-git-send-email-zhiyong.tao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2016-07-11 6:39 ` [PATCH v4 2/3] iio: adc: mt2701: Add Mediatek auxadc driver for mt2701 Zhiyong Tao
2016-07-18 17:12 ` Jonathan Cameron
[not found] ` <82fa5ffa-52be-e1ec-83dd-dd92b3f3ef5d-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-07-20 6:02 ` zhiyong tao
2016-07-20 6:24 ` zhiyong tao
2016-07-11 6:39 ` [PATCH v4 3/3] arm: dts: mt2701: Add auxadc node Zhiyong Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468291396.419.15.camel@mhfsdcap03 \
--to=zhiyong.tao@mediatek.com \
--cc=dawei.chien@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=erin.lo@mediatek.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=liguo.zhang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).