From: Andrew Duggan <aduggan@synaptics.com>
To: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Andrew Duggan <aduggan@synaptics.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Vincent Huang <vincent.huang@tw.synaptics.com>,
Nick Dyer <nick@shmanahar.org>, Chris Healy <cphealy@gmail.com>,
devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh@kernel.org>
Subject: [PATCH v3 3/8] Input: synaptics-rmi4: Add dribble and palm gesture parameters to device tree
Date: Wed, 13 Jul 2016 23:08:42 -0700 [thread overview]
Message-ID: <1468476522-8032-1-git-send-email-aduggan@synaptics.com> (raw)
Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
---
This version includes Nick's suggestion of adding force to the device tree
parameters so make it obvious that these parameters overwrite the
default values set in the firware config.
.../devicetree/bindings/input/rmi4/rmi_2d_sensor.txt | 10 ++++++++++
drivers/input/rmi4/rmi_2d_sensor.c | 13 +++++++++++++
2 files changed, 23 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt b/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
index f2c30c8..c00665d 100644
--- a/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
+++ b/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
@@ -37,6 +37,16 @@ Optional Properties:
disable reporing absolute position data.
- syna,rezero-wait-ms: Time in miliseconds to wait after issuing a rezero
command.
+- syna,dribble-force-enable: Enable reporting of dribble packets in the firmware
+ (overwrites default value in firmware config).
+- syna,dribble-force-disable: Disable reporting of dribble packets in the firmware.
+ (overwrites default value in firmware config).
+- syna,palm-detect-force-enable: Enable reporting the palm detect gesture in the
+ firmware. (overwrites default value in firmware
+ config).
+- syna,palm-detect-force-disable: Disable reporting the palm detect gesture in
+ the firmware. (overwrites default value in
+ firmware config).
Example of a RMI4 I2C device with F11:
diff --git a/drivers/input/rmi4/rmi_2d_sensor.c b/drivers/input/rmi4/rmi_2d_sensor.c
index e97bd7f..a092f6a 100644
--- a/drivers/input/rmi4/rmi_2d_sensor.c
+++ b/drivers/input/rmi4/rmi_2d_sensor.c
@@ -317,6 +317,19 @@ int rmi_2d_sensor_of_probe(struct device *dev,
pdata->rezero_wait = val;
+ if (of_property_read_bool(dev->of_node, "syna,dribble-force-enable"))
+ pdata->dribble = RMI_REG_STATE_ON;
+ else if (of_property_read_bool(dev->of_node,
+ "syna,dribble-force-disable"))
+ pdata->dribble = RMI_REG_STATE_OFF;
+
+ if (of_property_read_bool(dev->of_node,
+ "syna,palm-detect-force-enable"))
+ pdata->palm_detect = RMI_REG_STATE_ON;
+ else if (of_property_read_bool(dev->of_node,
+ "syna,palm-detect-force-disable"))
+ pdata->palm_detect = RMI_REG_STATE_OFF;
+
return 0;
}
#else
--
2.5.0
next reply other threads:[~2016-07-14 6:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 6:08 Andrew Duggan [this message]
[not found] ` <1468476522-8032-1-git-send-email-aduggan-Gq53QDLGkWKakBO8gow8eQ@public.gmane.org>
2016-07-16 22:49 ` [PATCH v3 3/8] Input: synaptics-rmi4: Add dribble and palm gesture parameters to device tree Rob Herring
2016-07-22 15:08 ` Linus Walleij
2016-07-22 16:52 ` Dmitry Torokhov
2016-07-22 18:32 ` Andrew Duggan
2016-07-24 14:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468476522-8032-1-git-send-email-aduggan@synaptics.com \
--to=aduggan@synaptics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=cphealy@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nick@shmanahar.org \
--cc=robh@kernel.org \
--cc=vincent.huang@tw.synaptics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).