From: Philipp Zabel <p.zabel@pengutronix.de>
To: Archit Taneja <architt@codeaurora.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Andrey Gusakov <andrey.gusakov@cogentembedded.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
Chris Healy <Chris.Healy@zii.aero>,
Kumar Gala <galak@codeaurora.org>,
Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: tc358767: add DT documentation
Date: Mon, 18 Jul 2016 10:36:50 +0200 [thread overview]
Message-ID: <1468831010.2994.7.camel@pengutronix.de> (raw)
In-Reply-To: <578B40F5.6070309@codeaurora.org>
Am Sonntag, den 17.07.2016, 13:55 +0530 schrieb Archit Taneja:
>
> On 7/17/2016 4:04 AM, Rob Herring wrote:
> > On Wed, Jul 13, 2016 at 09:07:10AM +0200, Philipp Zabel wrote:
> >> Add DT binding documentation for the Toshiba TC358767 eDP bridge.
> >>
> >> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> >> ---
> >> .../bindings/display/bridge/toshiba,tc358767.txt | 51 ++++++++++++++++++++++
> >> 1 file changed, 51 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.txt b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.txt
> >> new file mode 100644
> >> index 0000000..05ada28
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.txt
> >> @@ -0,0 +1,51 @@
> >> +Toshiba TC358767 eDP bridge bindings
> >> +
> >> +Required properties:
> >> + - compatible: "toshiba,tc358767"
> >> + - reg: i2c address of the bridge, 0x68 or 0x0f, depending on bootstrap pins
> >> + - clock-names: should be "ref"
> >> + - clocks: OF device-tree clock specification for refclk input. The reference
> >> + clock rate must be 13 MHz, 19.2 MHz, 26 MHz, or 38.4 MHz.
> >> +
> >> +Optional properties:
> >> + - shutdown-gpios: OF device-tree gpio specification for SD pin
> >> + (active high shutdown input)
> >> + - reset-gpios: OF device-tree gpio specification for RSTX pin
> >> + (active low system reset)
> >> + - ports: the ports node can contain video interface port nodes to connect
> >> + to a DPI/DSI source and to an eDP/DP sink according to [1][2]:
> >> + - port@0: DSI input port
> >> + - port@1: DPI input port
> >> + - port@2: eDP/DP output port
> >> +
> >> +[1]: Documentation/devicetree/bindings/graph.txt
> >> +[2]: Documentation/devicetree/bindings/media/video-interfaces.txt
> >> +
> >> +Example:
> >> + edp-bridge@68 {
> >> + compatible = "toshiba,tc358767";
> >> + reg = <0x68>;
> >> + shutdown-gpios = <&gpio3 23 GPIO_ACTIVE_HIGH>;
> >> + reset-gpios = <&gpio3 24 GPIO_ACTIVE_LOW>;
> >> + clock-names = "ref";
> >> + clocks = <&edp_refclk>;
> >> +
> >> + ports {
> >
> > You are missing #size-cells and #address-cells here, otherwise:
> >
> > Acked-by: Rob Herring <robh@kernel.org>
>
> Thanks, I'll fix it up before sending a pull request.
Thank you for the fixup.
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-07-18 8:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 7:07 [PATCH v3 0/2] Toshiba TC358767 eDP bridge driver Philipp Zabel
2016-07-13 7:07 ` [PATCH v3 1/2] dt-bindings: tc358767: add DT documentation Philipp Zabel
2016-07-16 22:34 ` Rob Herring
2016-07-17 8:25 ` Archit Taneja
2016-07-18 8:36 ` Philipp Zabel [this message]
2016-07-13 7:07 ` [PATCH v3 2/2] drm/bridge: tc358767: Add DPI to eDP bridge driver Philipp Zabel
2016-07-13 8:21 ` [PATCH v3 0/2] Toshiba TC358767 " Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468831010.2994.7.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=Chris.Healy@zii.aero \
--cc=andrey.gusakov@cogentembedded.com \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).