From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 2/3] clk: shmobile: Add MSTP clock support Date: Wed, 06 Nov 2013 13:13:06 +0100 Message-ID: <1469822.fWgxvRAPOn@avalon> References: <1383058511-26046-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1383058511-26046-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-sh-owner@vger.kernel.org To: Magnus Damm Cc: Laurent Pinchart , SH-Linux , "linux-arm-kernel@lists.infradead.org" , devicetree@vger.kernel.org, Mike Turquette List-Id: devicetree@vger.kernel.org Hi Magnus, On Wednesday 06 November 2013 17:33:39 Magnus Damm wrote: > On Tue, Oct 29, 2013 at 11:55 PM, Laurent Pinchart wrote: > > MSTP clocks are gate clocks controlled through a register that handles > > up to 32 clocks. The register is often sparsely populated. > > > > Those clocks are found on Renesas ARM SoCs. > > > > Signed-off-by: Laurent Pinchart > > > > --- > > > > .../bindings/clock/renesas,cpg-mstp-clocks.txt | 47 +++++ > > drivers/clk/shmobile/Makefile | 1 + > > drivers/clk/shmobile/clk-mstp.c | 229 ++++++++++++++++ > > include/dt-bindings/clock/r8a7790-clock.h | 56 +++++ > > 4 files changed, 333 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt > > create mode 100644 drivers/clk/shmobile/clk-mstp.c > > Thanks for this. The MSTP driver looks fine to me, but.. > > > create mode 100644 include/dt-bindings/clock/r8a7790-clock.h > > .. why do you bundle r8a7790-specific bits with the generic MSTP > driver in this patch? > > It looks to me that you want these r8a7790 bits included with the > r8a7790 support code. My mistake, I'll fix that. -- Regards, Laurent Pinchart