From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minghsiu Tsai Subject: Re: [PATCH v2 2/4] dt-bindings: Add a binding for Mediatek MDP Date: Tue, 2 Aug 2016 13:49:46 +0800 Message-ID: <1470116986.16982.5.camel@mtksdaap41> References: <1469176383-35210-1-git-send-email-minghsiu.tsai@mediatek.com> <1469176383-35210-3-git-send-email-minghsiu.tsai@mediatek.com> <20160726185433.GA14609@rob-hp-laptop> <1469583886.27630.18.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Rob Herring Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Daniel Thompson , srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Mauro Carvalho Chehab , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Hans Verkuil , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Matthias Brugger , Yingjoe Chen , Eddie Huang , Pawel Osciak , "linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Thu, 2016-07-28 at 10:55 -0500, Rob Herring wrote: > On Tue, Jul 26, 2016 at 8:44 PM, Minghsiu Tsai > wrote: > > On Tue, 2016-07-26 at 13:54 -0500, Rob Herring wrote: > >> On Fri, Jul 22, 2016 at 04:33:01PM +0800, Minghsiu Tsai wrote: > >> > Add a DT binding documentation of MDP for the MT8173 SoC > >> > from Mediatek > >> > > >> > Signed-off-by: Minghsiu Tsai > >> > --- > >> > .../devicetree/bindings/media/mediatek-mdp.txt | 96 ++++++++++++++++++++ > >> > 1 file changed, 96 insertions(+) > >> > create mode 100644 Documentation/devicetree/bindings/media/mediatek-mdp.txt > >> > > >> > diff --git a/Documentation/devicetree/bindings/media/mediatek-mdp.txt b/Documentation/devicetree/bindings/media/mediatek-mdp.txt > >> > new file mode 100644 > >> > index 0000000..2dad031 > >> > --- /dev/null > >> > +++ b/Documentation/devicetree/bindings/media/mediatek-mdp.txt > >> > @@ -0,0 +1,96 @@ > >> > +* Mediatek Media Data Path > >> > + > >> > +Media Data Path is used for scaling and color space conversion. > >> > + > >> > +Required properties (all function blocks): > >> > +- compatible: "mediatek,-mdp" > >> > >> What is this, ... > >> > > > > It is used to match platform driver. > > Would structuring things like this work instead: > > { > compatible = "mediatek,-mdp"; > ranges = ...; > { > compatible = "mediatek,-mdp-rdma"; > ... > }; > { > compatible = "mediatek,-mdp-wdma"; > ... > }; > ... > }; > I am trying to modify it as structured node. But mdp failed to convert image. Under debugging. > > > > > >> > + "mediatek,-mdp-", one of > >> > >> and this? > >> > > > > It is string format of HW block. could be "mt8173", and > > are "rdma", "rsz", "wdma", and "wrot". > > > > > >> > + "mediatek,-mdp-rdma" - read DMA > >> > + "mediatek,-mdp-rsz" - resizer > >> > + "mediatek,-mdp-wdma" - write DMA > >> > + "mediatek,-mdp-wrot" - write DMA with rotation > >> > >> List what are valid values of . > >> > > > > - mt8173. There should be other chip added in future. > > I will change the property as blow: > > > > - compatible: "mediatek,-mdp" > > Should be one of > > "mediatek,-mdp-rdma" - read DMA > > "mediatek,-mdp-rsz" - resizer > > "mediatek,-mdp-wdma" - write DMA > > "mediatek,-mdp-wrot" - write DMA with rotation > > - could be 8173 > > > > > > If don't need , I also can change it as below. It is more clear. > > Up to you. Depends on how many different chips you will have. > I will replace "" with "mt8173" > > - compatible: "mediatek,mt8173-mdp" > > Should be one of > > "mediatek,mt8173-mdp-rdma" - read DMA > > "mediatek,mt8173-mdp-rsz" - resizer > > "mediatek,mt8173-mdp-wdma" - write DMA > > "mediatek,mt8173-mdp-wrot" - write DMA with rotation > > > > > >> > +- reg: Physical base address and length of the function block register space > >> > +- clocks: device clocks > >> > +- power-domains: a phandle to the power domain. > >> > +- mediatek,vpu: the node of video processor unit > >> > + > >> > +Required properties (DMA function blocks): > >> > +- compatible: Should be one of > >> > + "mediatek,-mdp-rdma" > >> > + "mediatek,-mdp-wdma" > >> > + "mediatek,-mdp-wrot" > >> > +- iommus: should point to the respective IOMMU block with master port as > >> > + argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > >> > + for details. > >> > +- mediatek,larb: must contain the local arbiters in the current Socs. > >> > >> It is still not clear which properties apply to which compatible > >> strings. > >> > > > > I found out the document for larb. > > I will change the property as below: > > > > - mediatek,larb: must contain the local arbiters in the current Socs, > > see > > Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt > > for details. > > That's good, but not what I meant. You still have properties which > only apply to certain blocks, but are listed for all blocks like > mediatek,vpu for example. > > Rob I find out other properties' document. - clocks: device clocks, see Documentation/devicetree/bindings/clock/clock-bindings.txt for details. - power-domains: a phandle to the power domain, see Documentation/devicetree/bindings/power/power_domain.txt for details. - mediatek,vpu: the node of video processor unit, see Documentation/devicetree/bindings/media/mediatek-vpu.txt for details.