From: Ian Campbell <ijc@hellion.org.uk>
To: Mark Rutland <mark.rutland@arm.com>, Rob Herring <robh+dt@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Lee Jones <lee@kernel.org>, Will Deacon <will.deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Eric Anholt <eric@anholt.net>, "arm@kernel.org" <arm@kernel.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Frank Rowand <frowand.list@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM64: dts: bcm: Use a symlink to R-Pi dtsi files from arch=arm
Date: Wed, 03 Aug 2016 14:45:59 +0100 [thread overview]
Message-ID: <1470231959.4745.11.camel@hellion.org.uk> (raw)
In-Reply-To: <20160803133041.GA12499@leverpostej>
On Wed, 2016-08-03 at 14:30 +0100, Mark Rutland wrote:
> On Wed, Aug 03, 2016 at 08:13:51AM -0500, Rob Herring wrote:
> >
> > > > On Wed, Aug 3, 2016 at 3:40 AM, Ian Campbell <ijc@hellion.org.uk> wrote:
> > >
> > > These includes in turn require a skeleton.dtsi to be present, so add one as
> > > a real file (with the same contents as arch/arm) rather than a symlink.
> >
> > I don't follow why skeleton.dtsi is needed. The 32-bit RPi dts files
> > are including it?
Exactly.
> > If so, can we just remove it. We decided
> > skeleton.dtsi was a bad idea.
>
> Yup. I don't want to see skeleton.dtsi reappear, and the necessary
> fixups to source files are relatively simple.
>
> Ian, see commit 3ebee5a2e141496b ("arm64: dts: kill skeleton.dtsi") for
> the rationale, and hints as to what needs to be fixed up (e.g. if empty
> > memory nodes are required, there should be a comment as to why).
Understood.
I can make the mechanical fix to arch/arm/boot/dts/bcm283x.dtsi (which
is linked here as arch/arm64/boot/dts/broadcom/bcm283x.dtsi which
causes the need for skeleton.dtsi) but I don't have any R-Pi hardware
with which to verify the need (or not) for empty memory nodes etc.
> Perhaps this is a good time to attack the remaining 32-bit skeleton.dtsi
> > users. I'll take another look come -rc1.
linux.git$ git grep skeleton.dtsi -- arch/arm | wc -l
148
linux.git$
Good luck ;-)
Ian.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2016-08-03 13:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 8:40 [PATCH] ARM64: dts: bcm: Use a symlink to R-Pi dtsi files from arch=arm Ian Campbell
[not found] ` <1470213635-6934-1-git-send-email-ijc-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
2016-08-03 13:13 ` Rob Herring
[not found] ` <CAL_JsqKs+9UxKa=_PZWM-AO8b+MqbxypO_3h6ZGQtYjHcB1Drg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-03 13:30 ` Mark Rutland
2016-08-03 13:45 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470231959.4745.11.camel@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=arm@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=frowand.list@gmail.com \
--cc=kraxel@redhat.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).