devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhen Lei <thunder.leizhen@huawei.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	devicetree <devicetree@vger.kernel.org>
Cc: Zefan Li <lizefan@huawei.com>, Xinwei Hu <huxinwei@huawei.com>,
	Tianhong Ding <dingtianhong@huawei.com>,
	Hanjun Guo <guohanjun@huawei.com>,
	Zhen Lei <thunder.leizhen@huawei.com>
Subject: [PATCH v6 06/14] of_numa: Use of_get_next_parent to simplify code
Date: Thu, 11 Aug 2016 17:33:40 +0800	[thread overview]
Message-ID: <1470908028-8596-7-git-send-email-thunder.leizhen@huawei.com> (raw)
In-Reply-To: <1470908028-8596-1-git-send-email-thunder.leizhen@huawei.com>

From: Kefeng Wang <wangkefeng.wang@huawei.com>

Use of_get_next_parent() instead of open-code.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 drivers/of/of_numa.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c
index 8723f64..ed103e6 100644
--- a/drivers/of/of_numa.c
+++ b/drivers/of/of_numa.c
@@ -158,8 +158,6 @@ int of_node_to_nid(struct device_node *device)
 	np = of_node_get(device);

 	while (np) {
-		struct device_node *parent;
-
 		r = of_property_read_u32(np, "numa-node-id", &nid);
 		/*
 		 * -EINVAL indicates the property was not found, and
@@ -170,9 +168,7 @@ int of_node_to_nid(struct device_node *device)
 		if (r != -EINVAL)
 			break;

-		parent = of_get_parent(np);
-		of_node_put(np);
-		np = parent;
+		np = of_get_next_parent(np);
 	}
 	if (np && r)
 		pr_warn("NUMA: Invalid \"numa-node-id\" property in node %s\n",
--
2.5.0

  parent reply	other threads:[~2016-08-11  9:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-11  9:33 [PATCH v6 00/14] fix some type infos and bugs for arm64/of numa Zhen Lei
2016-08-11  9:33 ` [PATCH v6 01/14] of/numa: remove a duplicated pr_debug information Zhen Lei
2016-08-11  9:33 ` [PATCH v6 02/14] of/numa: fix a memory@ node can only contains one memory block Zhen Lei
2016-08-11  9:33 ` [PATCH v6 03/14] arm64/numa: add nid check for " Zhen Lei
2016-08-11  9:33 ` [PATCH v6 04/14] of/numa: remove a duplicated warning Zhen Lei
2016-08-11  9:33 ` [PATCH v6 05/14] arm64/numa: avoid inconsistent information to be printed Zhen Lei
2016-08-11  9:33 ` Zhen Lei [this message]
2016-08-11  9:33 ` [PATCH v6 07/14] of_numa: Use pr_fmt() Zhen Lei
     [not found] ` <1470908028-8596-1-git-send-email-thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-08-11  9:33   ` [PATCH v6 08/14] arm64: numa: " Zhen Lei
2016-08-11  9:33   ` [PATCH v6 09/14] arm64/numa: support HAVE_SETUP_PER_CPU_AREA Zhen Lei
2016-08-11  9:33   ` [PATCH v6 10/14] arm64/numa: define numa_distance as array to simplify code Zhen Lei
2016-08-11  9:33   ` [PATCH v6 11/14] arm64/numa: support HAVE_MEMORYLESS_NODES Zhen Lei
2016-08-11  9:33   ` [PATCH v6 12/14] arm64/numa: remove some useless code Zhen Lei
2016-08-22  7:47   ` [PATCH v6 00/14] fix some type infos and bugs for arm64/of numa Leizhen (ThunderTown)
2016-08-11  9:33 ` [PATCH v6 13/14] of/numa: remove the constraint on the distances of node pairs Zhen Lei
2016-08-11  9:33 ` [PATCH v6 14/14] Documentation: " Zhen Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470908028-8596-7-git-send-email-thunder.leizhen@huawei.com \
    --to=thunder.leizhen@huawei.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dingtianhong@huawei.com \
    --cc=frowand.list@gmail.com \
    --cc=guohanjun@huawei.com \
    --cc=huxinwei@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).