From: Joshua Clayton <stillcompiling@gmail.com>
To: Peter Chen <hzpeterchen@gmail.com>, Shawn Guo <shawnguo@kernel.org>
Cc: Joshua Clayton <stillcompiling@gmail.com>,
gregkh@linuxfoundation.org, stern@rowland.harvard.edu,
ulf.hansson@linaro.org, broonie@kernel.org, sre@kernel.org,
robh+dt@kernel.org, dbaryshkov@gmail.com, dwmw3@infradead.org,
k.kozlowski@samsung.com, linux-arm-kernel@lists.infradead.org,
p.zabel@pengutronix.de, devicetree@vger.kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
linux-usb@vger.kernel.org, arnd@arndb.de, s.hauer@pengutronix.de,
mail@maciej.szmigiero.name, troy.kisky@boundarydevices.com,
festevam@gmail.com, oscar@naiandei.net, stephen.boyd@linaro.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
mka@chromium.org, Peter Chen <peter.chen@nxp.com>
Subject: [PATCH 2/3] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property
Date: Thu, 11 Aug 2016 09:40:31 -0700 [thread overview]
Message-ID: <1470933632-22133-3-git-send-email-stillcompiling@gmail.com> (raw)
In-Reply-To: <1470933632-22133-1-git-send-email-stillcompiling@gmail.com>
From: Peter Chen <peter.chen@nxp.com>
The current dts describes USB HUB's property at USB controller's
entry, it is improper. The USB HUB should be the child node
under USB controller, and power sequence properties are under
it.
Signed-off-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
arch/arm/boot/dts/imx6qdl-udoo.dtsi | 24 +++++++++++-------------
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
index 3bee2f9..44b2a24 100644
--- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
@@ -9,6 +9,8 @@
*
*/
+#include <dt-bindings/gpio/gpio.h>
+
/ {
aliases {
backlight = &backlight;
@@ -58,17 +60,6 @@
#address-cells = <1>;
#size-cells = <0>;
- reg_usb_h1_vbus: regulator@0 {
- compatible = "regulator-fixed";
- reg = <0>;
- regulator-name = "usb_h1_vbus";
- regulator-min-microvolt = <5000000>;
- regulator-max-microvolt = <5000000>;
- enable-active-high;
- startup-delay-us = <2>; /* USB2415 requires a POR of 1 us minimum */
- gpio = <&gpio7 12 0>;
- };
-
reg_panel: regulator@1 {
compatible = "regulator-fixed";
reg = <1>;
@@ -259,9 +250,16 @@
&usbh1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_usbh>;
- vbus-supply = <®_usb_h1_vbus>;
- clocks = <&clks IMX6QDL_CLK_CKO>;
status = "okay";
+
+ usb2415: hub@1 {
+ compatible = "usb424,2514";
+ reg = <1>;
+
+ clocks = <&clks IMX6QDL_CLK_CKO>;
+ reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>;
+ reset-duration-us = <3000>;
+ };
};
&usdhc3 {
--
2.7.4
next prev parent reply other threads:[~2016-08-11 16:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 8:52 [PATCH v5 0/6] power: add power sequence library Peter Chen
2016-08-08 8:52 ` [PATCH v5 1/6] binding-doc: power: pwrseq-generic: add binding doc for generic " Peter Chen
2016-08-08 8:52 ` [PATCH v5 2/6] power: add " Peter Chen
[not found] ` <1470646331-23227-3-git-send-email-peter.chen-3arQi8VN3Tc@public.gmane.org>
2016-08-09 0:25 ` Matthias Kaehlcke
2016-08-08 8:52 ` [PATCH v5 3/6] binding-doc: usb: usb-device: add optional properties for power sequence Peter Chen
2016-08-08 8:52 ` [PATCH v5 4/6] usb: core: add power sequence handling for USB devices Peter Chen
2016-08-08 8:52 ` [PATCH v5 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node Peter Chen
2016-08-10 0:15 ` Stephen Boyd
2016-08-10 3:11 ` Peter Chen
2016-08-10 9:00 ` Jun Li
2016-08-10 9:19 ` Peter Chen
2016-08-08 8:52 ` [PATCH v5 6/6] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property Peter Chen
2016-08-09 23:33 ` Joshua Clayton
[not found] ` <57AA684F.4020004-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-10 3:02 ` Peter Chen
2016-08-11 16:40 ` [PATCHES] ARM: dts: update udoo and evi hubs to use pwrseq Joshua Clayton
[not found] ` <1470933632-22133-1-git-send-email-stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-11 16:40 ` [PATCH 1/3] ARM: dts: imx6qdl: Enable usb node children with <reg> Joshua Clayton
2016-08-11 16:40 ` [PATCH 3/3] ARM: dts: imx6q-evi: Fix onboard hub reset line Joshua Clayton
2016-08-12 3:11 ` Peter Chen
2016-08-12 15:20 ` Joshua Clayton
2016-08-11 16:40 ` Joshua Clayton [this message]
2016-08-12 3:09 ` [PATCHES] ARM: dts: update udoo and evi hubs to use pwrseq Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470933632-22133-3-git-send-email-stillcompiling@gmail.com \
--to=stillcompiling@gmail.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw3@infradead.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hzpeterchen@gmail.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=oscar@naiandei.net \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=peter.chen@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sre@kernel.org \
--cc=stephen.boyd@linaro.org \
--cc=stern@rowland.harvard.edu \
--cc=troy.kisky@boundarydevices.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).