[PATCH v3 0/5] dts patches for qcom tsens support

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH v3 0/5] dts patches for qcom tsens support
@ 2016-08-17  5:18 Rajendra Nayak
  2016-08-17  5:18 ` [PATCH v3 1/5] arm: dts: msm8974: Add thermal zones, tsens and qfprom nodes Rajendra Nayak
                   ` (5 more replies)
  0 siblings, 6 replies; 13+ messages in thread
From: Rajendra Nayak @ 2016-08-17  5:18 UTC (permalink / raw)
  To: andy.gross; +Cc: linux-arm-msm, devicetree, linux-kernel, Rajendra Nayak

Hey Andy,

This is a respin of v2 with some minor fixes pointed out by Rob.
Please pull these in for 4.9

Thanks,
Rajendra

Rajendra Nayak (5):
  arm: dts: msm8974: Add thermal zones, tsens and qfprom nodes
  arm: dts: apq8064: Add thermal zones, tsens and qfprom nodes
  arm: dts: apq8084: Add thermal zones, tsens and qfprom nodes
  arm64: dts: msm8916: Add thermal zones, tsens and qfprom nodes
  arm64: dts: msm8996: Add thermal zones, tsens and qfprom nodes

 .../devicetree/bindings/clock/qcom,gcc.txt         |  16 ++++
 arch/arm/boot/dts/qcom-apq8064.dtsi                | 103 +++++++++++++++++++++
 arch/arm/boot/dts/qcom-apq8084.dtsi                | 103 +++++++++++++++++++++
 arch/arm/boot/dts/qcom-msm8974.dtsi                | 103 +++++++++++++++++++++
 arch/arm64/boot/dts/qcom/msm8916.dtsi              |  64 +++++++++++++
 arch/arm64/boot/dts/qcom/msm8996.dtsi              |  92 ++++++++++++++++++
 6 files changed, 481 insertions(+)

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v3 1/5] arm: dts: msm8974: Add thermal zones, tsens and qfprom nodes
  2016-08-17  5:18 [PATCH v3 0/5] dts patches for qcom tsens support Rajendra Nayak
@ 2016-08-17  5:18 ` Rajendra Nayak
  2016-08-17  5:18 ` [PATCH v3 2/5] arm: dts: apq8064: " Rajendra Nayak
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 13+ messages in thread
From: Rajendra Nayak @ 2016-08-17  5:18 UTC (permalink / raw)
  To: andy.gross; +Cc: linux-arm-msm, devicetree, linux-kernel, Rajendra Nayak

Add thermal zones, tsens and qfprom nodes

Acked-by: Eduardo Valentin <edubezval@gmail.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
---
 arch/arm/boot/dts/qcom-msm8974.dtsi | 103 ++++++++++++++++++++++++++++++++++++
 1 file changed, 103 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
index 561d4d1..255c61a 100644
--- a/arch/arm/boot/dts/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
@@ -131,6 +131,88 @@
 		};
 	};
 
+	thermal-zones {
+		cpu-thermal0 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens 5>;
+
+			trips {
+				cpu_alert0: trip0 {
+					temperature = <75000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+				cpu_crit0: trip1 {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+
+		cpu-thermal1 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens 6>;
+
+			trips {
+				cpu_alert1: trip0 {
+					temperature = <75000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+				cpu_crit1: trip1 {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+
+		cpu-thermal2 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens 7>;
+
+			trips {
+				cpu_alert2: trip0 {
+					temperature = <75000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+				cpu_crit2: trip1 {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+
+		cpu-thermal3 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens 8>;
+
+			trips {
+				cpu_alert3: trip0 {
+					temperature = <75000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+				cpu_crit3: trip1 {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+	};
+
 	cpu-pmu {
 		compatible = "qcom,krait-pmu";
 		interrupts = <1 7 0xf04>;
@@ -287,6 +369,27 @@
 			reg = <0xf9011000 0x1000>;
 		};
 
+		qfprom: qfprom@fc4bc000 {
+			#address-cells = <1>;
+			#size-cells = <1>;
+			compatible = "qcom,qfprom";
+			reg = <0xfc4bc000 0x1000>;
+			tsens_calib: calib@d0 {
+				reg = <0xd0 0x18>;
+			};
+			tsens_backup: backup@440 {
+				reg = <0x440 0x10>;
+			};
+		};
+
+		tsens: thermal-sensor@fc4a8000 {
+			compatible = "qcom,msm8974-tsens";
+			reg = <0xfc4a8000 0x2000>;
+			nvmem-cells = <&tsens_calib>, <&tsens_backup>;
+			nvmem-cell-names = "calib", "calib_backup";
+			#thermal-sensor-cells = <1>;
+		};
+
 		timer@f9020000 {
 			#address-cells = <1>;
 			#size-cells = <1>;
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v3 2/5] arm: dts: apq8064: Add thermal zones, tsens and qfprom nodes
  2016-08-17  5:18 [PATCH v3 0/5] dts patches for qcom tsens support Rajendra Nayak
  2016-08-17  5:18 ` [PATCH v3 1/5] arm: dts: msm8974: Add thermal zones, tsens and qfprom nodes Rajendra Nayak
@ 2016-08-17  5:18 ` Rajendra Nayak
  2016-08-17  5:18 ` [PATCH v3 3/5] arm: dts: apq8084: " Rajendra Nayak
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 13+ messages in thread
From: Rajendra Nayak @ 2016-08-17  5:18 UTC (permalink / raw)
  To: andy.gross; +Cc: linux-arm-msm, devicetree, linux-kernel, Rajendra Nayak

TSENS is part of GCC, hence add TSENS properties as part of GCC node.
Also add thermal zones and qfprom nodes.
Update GCC bindings doc to mention the possibility of optional TSENS
properties that can be part of GCC node.

Acked-by: Eduardo Valentin <edubezval@gmail.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
---
 .../devicetree/bindings/clock/qcom,gcc.txt         |  16 ++++
 arch/arm/boot/dts/qcom-apq8064.dtsi                | 103 +++++++++++++++++++++
 2 files changed, 119 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.txt b/Documentation/devicetree/bindings/clock/qcom,gcc.txt
index 9a60fde..ea893cb 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc.txt
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc.txt
@@ -22,6 +22,11 @@ Required properties :
 
 Optional properties :
 - #power-domain-cells : shall contain 1
+- Qualcomm TSENS (thermal sensor device) on some devices can
+be part of GCC and hence the TSENS properties can also be
+part of the GCC/clock-controller node.
+For more details on the TSENS properties please refer
+Documentation/devicetree/bindings/thermal/qcom-tsens.txt
 
 Example:
 	clock-controller@900000 {
@@ -31,3 +36,14 @@ Example:
 		#reset-cells = <1>;
 		#power-domain-cells = <1>;
 	};
+
+Example of GCC with TSENS properties:
+	clock-controller@900000 {
+		compatible = "qcom,gcc-apq8064";
+		reg = <0x00900000 0x4000>;
+		nvmem-cells = <&tsens_calib>, <&tsens_backup>;
+		nvmem-cell-names = "calib", "calib_backup";
+		#clock-cells = <1>;
+		#reset-cells = <1>;
+		#thermal-sensor-cells = <1>;
+	};
diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
index 74a9b6c..0313da3 100644
--- a/arch/arm/boot/dts/qcom-apq8064.dtsi
+++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
@@ -86,6 +86,92 @@
 		};
 	};
 
+	thermal-zones {
+		cpu-thermal0 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&gcc 7>;
+			coefficients = <1199 0>;
+
+			trips {
+				cpu_alert0: trip0 {
+					temperature = <75000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+				cpu_crit0: trip1 {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+
+		cpu-thermal1 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&gcc 8>;
+			coefficients = <1132 0>;
+
+			trips {
+				cpu_alert1: trip0 {
+					temperature = <75000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+				cpu_crit1: trip1 {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+
+		cpu-thermal2 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&gcc 9>;
+			coefficients = <1199 0>;
+
+			trips {
+				cpu_alert2: trip0 {
+					temperature = <75000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+				cpu_crit2: trip1 {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+
+		cpu-thermal3 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&gcc 10>;
+			coefficients = <1132 0>;
+
+			trips {
+				cpu_alert3: trip0 {
+					temperature = <75000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+				cpu_crit3: trip1 {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+	};
+
 	cpu-pmu {
 		compatible = "qcom,krait-pmu";
 		interrupts = <1 10 0x304>;
@@ -611,11 +697,28 @@
 			};
 		};
 
+		qfprom: qfprom@700000 {
+			compatible	= "qcom,qfprom";
+			reg		= <0x00700000 0x1000>;
+			#address-cells	= <1>;
+			#size-cells	= <1>;
+			ranges;
+			tsens_calib: calib {
+				reg = <0x404 0x10>;
+			};
+			tsens_backup: backup_calib {
+				reg = <0x414 0x10>;
+			};
+		};
+
 		gcc: clock-controller@900000 {
 			compatible = "qcom,gcc-apq8064";
 			reg = <0x00900000 0x4000>;
+			nvmem-cells = <&tsens_calib>, <&tsens_backup>;
+			nvmem-cell-names = "calib", "calib_backup";
 			#clock-cells = <1>;
 			#reset-cells = <1>;
+			#thermal-sensor-cells = <1>;
 		};
 
 		lcc: clock-controller@28000000 {
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v3 3/5] arm: dts: apq8084: Add thermal zones, tsens and qfprom nodes
  2016-08-17  5:18 [PATCH v3 0/5] dts patches for qcom tsens support Rajendra Nayak
  2016-08-17  5:18 ` [PATCH v3 1/5] arm: dts: msm8974: Add thermal zones, tsens and qfprom nodes Rajendra Nayak
  2016-08-17  5:18 ` [PATCH v3 2/5] arm: dts: apq8064: " Rajendra Nayak
@ 2016-08-17  5:18 ` Rajendra Nayak
  2016-08-17  5:18 ` [PATCH v3 4/5] arm64: dts: msm8916: " Rajendra Nayak
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 13+ messages in thread
From: Rajendra Nayak @ 2016-08-17  5:18 UTC (permalink / raw)
  To: andy.gross; +Cc: linux-arm-msm, devicetree, linux-kernel, Rajendra Nayak

Add thermal zones, tsens and qfprom nodes

Acked-by: Eduardo Valentin <edubezval@gmail.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
---
 arch/arm/boot/dts/qcom-apq8084.dtsi | 103 ++++++++++++++++++++++++++++++++++++
 1 file changed, 103 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-apq8084.dtsi b/arch/arm/boot/dts/qcom-apq8084.dtsi
index 7c2df06..39eb7a4 100644
--- a/arch/arm/boot/dts/qcom-apq8084.dtsi
+++ b/arch/arm/boot/dts/qcom-apq8084.dtsi
@@ -94,6 +94,88 @@
 		};
 	};
 
+	thermal-zones {
+		cpu-thermal0 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens 5>;
+
+			trips {
+				cpu_alert0: trip0 {
+					temperature = <75000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+				cpu_crit0: trip1 {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+
+		cpu-thermal1 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens 6>;
+
+			trips {
+				cpu_alert1: trip0 {
+					temperature = <75000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+				cpu_crit1: trip1 {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+
+		cpu-thermal2 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens 7>;
+
+			trips {
+				cpu_alert2: trip0 {
+					temperature = <75000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+				cpu_crit2: trip1 {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+
+		cpu-thermal3 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens 8>;
+
+			trips {
+				cpu_alert3: trip0 {
+					temperature = <75000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+				cpu_crit3: trip1 {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+	};
+
 	cpu-pmu {
 		compatible = "qcom,krait-pmu";
 		interrupts = <1 7 0xf04>;
@@ -150,6 +232,27 @@
 			reg = <0xf9011000 0x1000>;
 		};
 
+		qfprom: qfprom@fc4bc000 {
+			#address-cells = <1>;
+			#size-cells = <1>;
+			compatible = "qcom,qfprom";
+			reg = <0xfc4bc000 0x1000>;
+			tsens_calib: calib@d0 {
+				reg = <0xd0 0x18>;
+			};
+			tsens_backup: backup@440 {
+				reg = <0x440 0x10>;
+			};
+		};
+
+		tsens: thermal-sensor@fc4a8000 {
+			compatible = "qcom,msm8974-tsens";
+			reg = <0xfc4a8000 0x2000>;
+			nvmem-cells = <&tsens_calib>, <&tsens_backup>;
+			nvmem-cell-names = "calib", "calib_backup";
+			#thermal-sensor-cells = <1>;
+		};
+
 		timer@f9020000 {
 			#address-cells = <1>;
 			#size-cells = <1>;
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v3 4/5] arm64: dts: msm8916: Add thermal zones, tsens and qfprom nodes
  2016-08-17  5:18 [PATCH v3 0/5] dts patches for qcom tsens support Rajendra Nayak
                   ` (2 preceding siblings ...)
  2016-08-17  5:18 ` [PATCH v3 3/5] arm: dts: apq8084: " Rajendra Nayak
@ 2016-08-17  5:18 ` Rajendra Nayak
  2016-08-17  5:18 ` [PATCH v3 5/5] arm64: dts: msm8996: " Rajendra Nayak
  2016-08-17 19:33 ` [PATCH v3 0/5] dts patches for qcom tsens support Andy Gross
  5 siblings, 0 replies; 13+ messages in thread
From: Rajendra Nayak @ 2016-08-17  5:18 UTC (permalink / raw)
  To: andy.gross; +Cc: linux-arm-msm, devicetree, linux-kernel, Rajendra Nayak

Add thermal zones, tsens and qfprom nodes

Acked-by: Eduardo Valentin <edubezval@gmail.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 64 +++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 11bdc24..4bc047b 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -155,6 +155,49 @@
 		interrupts = <GIC_PPI 7 GIC_CPU_MASK_SIMPLE(4)>;
 	};
 
+	thermal-zones {
+		cpu-thermal0 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens 4>;
+
+			trips {
+				cpu_alert0: trip0 {
+					temperature = <75000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+				cpu_crit0: trip1 {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+
+		cpu-thermal1 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens 3>;
+
+			trips {
+				cpu_alert1: trip0 {
+					temperature = <75000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+				cpu_crit1: trip1 {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+
+	};
+
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
@@ -609,6 +652,27 @@
 			clocks = <&gcc GCC_PRNG_AHB_CLK>;
 			clock-names = "core";
 		};
+
+		qfprom: qfprom@5c000 {
+			compatible = "qcom,qfprom";
+			reg = <0x5c000 0x1000>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			tsens_caldata: caldata@d0 {
+				reg = <0xd0 0x8>;
+			};
+			tsens_calsel: calsel@ec {
+				reg = <0xec 0x4>;
+			};
+		};
+
+		tsens: thermal-sensor@4a8000 {
+			compatible = "qcom,msm8916-tsens";
+			reg = <0x4a8000 0x2000>;
+			nvmem-cells = <&tsens_caldata>, <&tsens_calsel>;
+			nvmem-cell-names = "calib", "calib_sel";
+			#thermal-sensor-cells = <1>;
+		};
 	};
 
 	smd {
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v3 5/5] arm64: dts: msm8996: Add thermal zones, tsens and qfprom nodes
  2016-08-17  5:18 [PATCH v3 0/5] dts patches for qcom tsens support Rajendra Nayak
                   ` (3 preceding siblings ...)
  2016-08-17  5:18 ` [PATCH v3 4/5] arm64: dts: msm8916: " Rajendra Nayak
@ 2016-08-17  5:18 ` Rajendra Nayak
  2016-08-17 19:33 ` [PATCH v3 0/5] dts patches for qcom tsens support Andy Gross
  5 siblings, 0 replies; 13+ messages in thread
From: Rajendra Nayak @ 2016-08-17  5:18 UTC (permalink / raw)
  To: andy.gross; +Cc: linux-arm-msm, devicetree, linux-kernel, Rajendra Nayak

Add thermal zones and tsens node

Acked-by: Eduardo Valentin <edubezval@gmail.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
---
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 92 +++++++++++++++++++++++++++++++++++
 1 file changed, 92 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 55ec3e8..f52cba3 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -97,6 +97,92 @@
 		};
 	};
 
+	thermal-zones {
+		cpu-thermal0 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens0 3>;
+
+			trips {
+				cpu_alert0: trip0 {
+					temperature = <75000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+
+				cpu_crit0: trip1 {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+
+		cpu-thermal1 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens0 5>;
+
+			trips {
+				cpu_alert1: trip0 {
+					temperature = <75000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+
+				cpu_crit1: trip1 {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+
+		cpu-thermal2 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens0 8>;
+
+			trips {
+				cpu_alert2: trip0 {
+					temperature = <75000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+
+				cpu_crit2: trip1 {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+
+		cpu-thermal3 {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens0 10>;
+
+			trips {
+				cpu_alert3: trip0 {
+					temperature = <75000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+
+				cpu_crit3: trip1 {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+	};
+
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
@@ -181,6 +267,12 @@
 			status = "disabled";
 		};
 
+		tsens0: thermal-sensor@4a8000 {
+			compatible = "qcom,msm8996-tsens";
+			reg = <0x4a8000 0x2000>;
+			#thermal-sensor-cells = <1>;
+		};
+
 		blsp2_uart1: serial@75b0000 {
 			compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm";
 			reg = <0x75b0000 0x1000>;
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 0/5] dts patches for qcom tsens support
  2016-08-17  5:18 [PATCH v3 0/5] dts patches for qcom tsens support Rajendra Nayak
                   ` (4 preceding siblings ...)
  2016-08-17  5:18 ` [PATCH v3 5/5] arm64: dts: msm8996: " Rajendra Nayak
@ 2016-08-17 19:33 ` Andy Gross
       [not found]   ` <20160817193340.GA18215-3KkwrOJo9xYlRp7syxWybdHuzzzSOjJt@public.gmane.org>
  5 siblings, 1 reply; 13+ messages in thread
From: Andy Gross @ 2016-08-17 19:33 UTC (permalink / raw)
  To: Rajendra Nayak; +Cc: linux-arm-msm, devicetree, linux-kernel

On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
> Hey Andy,
> 
> This is a respin of v2 with some minor fixes pointed out by Rob.
> Please pull these in for 4.9
> 
> Thanks,
> Rajendra

I pulled these in.

Andy

^ permalink raw reply	[flat|nested] 13+ messages in thread

[parent not found: <20160817193340.GA18215-3KkwrOJo9xYlRp7syxWybdHuzzzSOjJt@public.gmane.org>]

* Re: [PATCH v3 0/5] dts patches for qcom tsens support
       [not found]   ` <20160817193340.GA18215-3KkwrOJo9xYlRp7syxWybdHuzzzSOjJt@public.gmane.org>
@ 2016-08-24 10:22     ` Paolo Pisati
  2016-08-24 12:18       ` Nayak, Rajendra
  2016-08-25  3:13       ` Bjorn Andersson
  0 siblings, 2 replies; 13+ messages in thread
From: Paolo Pisati @ 2016-08-24 10:22 UTC (permalink / raw)
  To: Andy Gross
  Cc: Rajendra Nayak, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:
> On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
> > Hey Andy,
> > 
> > This is a respin of v2 with some minor fixes pointed out by Rob.
> > Please pull these in for 4.9
> > 
> > Thanks,
> > Rajendra
> 
> I pulled these in.

Did you try to read the content of the qfprom from userspace?

$ uname -a
Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016 aarch64
aarch64 aarch64 GNU/Linux
$ lsmod 
Module                  Size  Used by
nvmem_qfprom           16384  0
nvmem_core             24576  1 nvmem_qfprom
$ ls -la /sys/bus/nvmem/devices/                                                                             
total 0
drwxr-xr-x 2 root root 0 Aug 24 10:17 .
drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
../../../devices/platform/soc/5c000.qfprom/qfprom0
$ cat /sys/bus/nvmem/devices/qfprom0/nvmem 

[spontaneous reboot]

This using agross's for-next tree as of today ("54ba896 Merge branch
'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.
-- 
bye,
p.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 0/5] dts patches for qcom tsens support
  2016-08-24 10:22     ` Paolo Pisati
@ 2016-08-24 12:18       ` Nayak, Rajendra
       [not found]         ` <57BD90A3.3000106-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
  2016-08-25  3:13       ` Bjorn Andersson
  1 sibling, 1 reply; 13+ messages in thread
From: Nayak, Rajendra @ 2016-08-24 12:18 UTC (permalink / raw)
  To: Paolo Pisati, Andy Gross
  Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA


On 8/24/2016 3:52 PM, Paolo Pisati wrote:
> On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:
>> On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
>>> Hey Andy,
>>>
>>> This is a respin of v2 with some minor fixes pointed out by Rob.
>>> Please pull these in for 4.9
>>>
>>> Thanks,
>>> Rajendra
>>
>> I pulled these in.
>
> Did you try to read the content of the qfprom from userspace?

Hi, no I haven't tried it, I can give it a try tomorrow when I
have access to my board and see whats going wrong, but I did
look at Andys for-next and the defconfig still does not have
either nvmem or qcom-qfprom drivers enabled.
Did you manually enable them? or are you seeing this with the drivers 
still disabled?

>
> $ uname -a
> Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016 aarch64
> aarch64 aarch64 GNU/Linux
> $ lsmod
> Module                  Size  Used by
> nvmem_qfprom           16384  0
> nvmem_core             24576  1 nvmem_qfprom
> $ ls -la /sys/bus/nvmem/devices/
> total 0
> drwxr-xr-x 2 root root 0 Aug 24 10:17 .
> drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
> lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
> ../../../devices/platform/soc/5c000.qfprom/qfprom0
> $ cat /sys/bus/nvmem/devices/qfprom0/nvmem
>
> [spontaneous reboot]
>
> This using agross's for-next tree as of today ("54ba896 Merge branch
> 'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 13+ messages in thread

[parent not found: <57BD90A3.3000106-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>]

* Re: [PATCH v3 0/5] dts patches for qcom tsens support
       [not found]         ` <57BD90A3.3000106-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
@ 2016-08-24 22:03           ` Andy Gross
  0 siblings, 0 replies; 13+ messages in thread
From: Andy Gross @ 2016-08-24 22:03 UTC (permalink / raw)
  To: Nayak, Rajendra
  Cc: Paolo Pisati, linux-arm-msm, devicetree, Linux Kernel list

On 24 August 2016 at 07:18, Nayak, Rajendra <rnayak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> wrote:
>
> On 8/24/2016 3:52 PM, Paolo Pisati wrote:
>>
>> On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:
>>>
>>> On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
>>>>
>>>> Hey Andy,
>>>>
>>>> This is a respin of v2 with some minor fixes pointed out by Rob.
>>>> Please pull these in for 4.9
>>>>
>>>> Thanks,
>>>> Rajendra
>>>
>>>
>>> I pulled these in.
>>
>>
>> Did you try to read the content of the qfprom from userspace?
>
>
> Hi, no I haven't tried it, I can give it a try tomorrow when I
> have access to my board and see whats going wrong, but I did
> look at Andys for-next and the defconfig still does not have
> either nvmem or qcom-qfprom drivers enabled.
> Did you manually enable them? or are you seeing this with the drivers still
> disabled?

I merged my for-next with the current next and enabled the options.  I
reproduced Paolo's problem.  It feels like either an access issue,
alignment issue (i tried ioread32 which didnt work).  It fails
regardless of the TSENS being enabled.

>
>
>>
>> $ uname -a
>> Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016
>> aarch64
>> aarch64 aarch64 GNU/Linux
>> $ lsmod
>> Module                  Size  Used by
>> nvmem_qfprom           16384  0
>> nvmem_core             24576  1 nvmem_qfprom
>> $ ls -la /sys/bus/nvmem/devices/
>> total 0
>> drwxr-xr-x 2 root root 0 Aug 24 10:17 .
>> drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
>> lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
>> ../../../devices/platform/soc/5c000.qfprom/qfprom0
>> $ cat /sys/bus/nvmem/devices/qfprom0/nvmem
>>
>> [spontaneous reboot]
>>
>> This using agross's for-next tree as of today ("54ba896 Merge branch
>> 'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.
>>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 0/5] dts patches for qcom tsens support
  2016-08-24 10:22     ` Paolo Pisati
  2016-08-24 12:18       ` Nayak, Rajendra
@ 2016-08-25  3:13       ` Bjorn Andersson
  2016-08-25  3:21         ` Andy Gross
  1 sibling, 1 reply; 13+ messages in thread
From: Bjorn Andersson @ 2016-08-25  3:13 UTC (permalink / raw)
  To: Paolo Pisati
  Cc: Andy Gross, Rajendra Nayak, linux-arm-msm, devicetree,
	linux-kernel

On Wed 24 Aug 03:22 PDT 2016, Paolo Pisati wrote:

> On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:
> > On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
> > > Hey Andy,
> > > 
> > > This is a respin of v2 with some minor fixes pointed out by Rob.
> > > Please pull these in for 4.9
> > > 
> > > Thanks,
> > > Rajendra
> > 
> > I pulled these in.
> 
> Did you try to read the content of the qfprom from userspace?
> 
> $ uname -a
> Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016 aarch64
> aarch64 aarch64 GNU/Linux
> $ lsmod 
> Module                  Size  Used by
> nvmem_qfprom           16384  0
> nvmem_core             24576  1 nvmem_qfprom
> $ ls -la /sys/bus/nvmem/devices/                                                                             
> total 0
> drwxr-xr-x 2 root root 0 Aug 24 10:17 .
> drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
> lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
> ../../../devices/platform/soc/5c000.qfprom/qfprom0
> $ cat /sys/bus/nvmem/devices/qfprom0/nvmem 
> 
> [spontaneous reboot]
> 
> This using agross's for-next tree as of today ("54ba896 Merge branch
> 'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.

This was reported in some other forum as well, after some investigation
we concluded that it looks like one of the entries are locked down -
probably from some security reason.

I'm not aware of any way to query this configuration. But the main use
case for the qfprom is in-kernel access to certain elements and that we
do get from the driver as is...

Regards,
Bjorn

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 0/5] dts patches for qcom tsens support
  2016-08-25  3:13       ` Bjorn Andersson
@ 2016-08-25  3:21         ` Andy Gross
  2016-08-25 12:21           ` Paolo Pisati
  0 siblings, 1 reply; 13+ messages in thread
From: Andy Gross @ 2016-08-25  3:21 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Paolo Pisati, Rajendra Nayak, linux-arm-msm, devicetree,
	Linux Kernel list

On 24 August 2016 at 22:13, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> On Wed 24 Aug 03:22 PDT 2016, Paolo Pisati wrote:
>
>> On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:
>> > On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
>> > > Hey Andy,
>> > >
>> > > This is a respin of v2 with some minor fixes pointed out by Rob.
>> > > Please pull these in for 4.9
>> > >
>> > > Thanks,
>> > > Rajendra
>> >
>> > I pulled these in.
>>
>> Did you try to read the content of the qfprom from userspace?
>>
>> $ uname -a
>> Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016 aarch64
>> aarch64 aarch64 GNU/Linux
>> $ lsmod
>> Module                  Size  Used by
>> nvmem_qfprom           16384  0
>> nvmem_core             24576  1 nvmem_qfprom
>> $ ls -la /sys/bus/nvmem/devices/
>> total 0
>> drwxr-xr-x 2 root root 0 Aug 24 10:17 .
>> drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
>> lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
>> ../../../devices/platform/soc/5c000.qfprom/qfprom0
>> $ cat /sys/bus/nvmem/devices/qfprom0/nvmem
>>
>> [spontaneous reboot]
>>
>> This using agross's for-next tree as of today ("54ba896 Merge branch
>> 'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.
>
> This was reported in some other forum as well, after some investigation
> we concluded that it looks like one of the entries are locked down -
> probably from some security reason.
>
> I'm not aware of any way to query this configuration. But the main use
> case for the qfprom is in-kernel access to certain elements and that we
> do get from the driver as is...

Yeah this appears to be the case.  So I guess the response is 'don't
do that'.  At least don't cat or od the file.  You need to seek and
read.

Andy

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 0/5] dts patches for qcom tsens support
  2016-08-25  3:21         ` Andy Gross
@ 2016-08-25 12:21           ` Paolo Pisati
  0 siblings, 0 replies; 13+ messages in thread
From: Paolo Pisati @ 2016-08-25 12:21 UTC (permalink / raw)
  To: Andy Gross
  Cc: Bjorn Andersson, Paolo Pisati, Rajendra Nayak, linux-arm-msm,
	devicetree, Linux Kernel list

On Wed, Aug 24, 2016 at 10:21:17PM -0500, Andy Gross wrote:
> 
> Yeah this appears to be the case.  So I guess the response is 'don't
> do that'.  At least don't cat or od the file.  You need to seek and
> read.

True, but the dev file is user readable and any user can trigger it (or
any regression test that rummage among dev files looking for bugs).
-- 
bye,
p.

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2016-08-25 12:21 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-17  5:18 [PATCH v3 0/5] dts patches for qcom tsens support Rajendra Nayak
2016-08-17  5:18 ` [PATCH v3 1/5] arm: dts: msm8974: Add thermal zones, tsens and qfprom nodes Rajendra Nayak
2016-08-17  5:18 ` [PATCH v3 2/5] arm: dts: apq8064: " Rajendra Nayak
2016-08-17  5:18 ` [PATCH v3 3/5] arm: dts: apq8084: " Rajendra Nayak
2016-08-17  5:18 ` [PATCH v3 4/5] arm64: dts: msm8916: " Rajendra Nayak
2016-08-17  5:18 ` [PATCH v3 5/5] arm64: dts: msm8996: " Rajendra Nayak
2016-08-17 19:33 ` [PATCH v3 0/5] dts patches for qcom tsens support Andy Gross
     [not found]   ` <20160817193340.GA18215-3KkwrOJo9xYlRp7syxWybdHuzzzSOjJt@public.gmane.org>
2016-08-24 10:22     ` Paolo Pisati
2016-08-24 12:18       ` Nayak, Rajendra
     [not found]         ` <57BD90A3.3000106-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-08-24 22:03           ` Andy Gross
2016-08-25  3:13       ` Bjorn Andersson
2016-08-25  3:21         ` Andy Gross
2016-08-25 12:21           ` Paolo Pisati

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).