From: Scott Wood <oss-fOR+EgIDQEHk1uMJSBkQmQ@public.gmane.org>
To: Bhaskar Upadhaya <Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: stuart.yoder-3arQi8VN3Tc@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 05/10] dt-bindings: pci: Update bindings for LS1012A
Date: Fri, 26 Aug 2016 17:30:28 -0500 [thread overview]
Message-ID: <1472250628.13245.6.camel@buserror.net> (raw)
In-Reply-To: <1472207269-18499-5-git-send-email-Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org>
On Fri, 2016-08-26 at 15:57 +0530, Bhaskar Upadhaya wrote:
> Signed-off-by: Bhaskar Upadhaya <Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org>
> ---
> Documentation/devicetree/bindings/pci/layerscape-pci.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> index 41e9f55..5755697 100644
> --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> @@ -15,6 +15,7 @@ Required properties:
> - compatible: should contain the platform identifier such as:
> "fsl,ls1021a-pcie", "snps,dw-pcie"
> "fsl,ls2080a-pcie", "fsl,ls2085a-pcie", "snps,dw-pcie"
> + "fsl,ls1012a-pcie", "fsl,ls1043a-pcie" ,"snps,dw-pcie"
Whitespace doesn't match.
Why are you listing both ls1012a and ls1043a together? Are they 100%
compatible?
Why are we updating all these bindings every time we come out with a new chip,
rather than having a <chip> pattern like we did in other bindings?
-Scott
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-08-26 22:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 10:27 [PATCH 01/10] dt-bindings: Add compatible property for LS1012A Bhaskar Upadhaya
2016-08-26 10:27 ` [PATCH 02/10] dt-bindings: esdhc: Update bindings " Bhaskar Upadhaya
2016-08-26 16:08 ` [linux-devel] " Yang-Leo Li
2016-08-26 10:27 ` [PATCH 03/10] dt-bindings: quadspi: " Bhaskar Upadhaya
[not found] ` <1472207269-18499-3-git-send-email-Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org>
2016-08-31 15:54 ` Rob Herring
2016-08-26 10:27 ` [PATCH 04/10] dt-bindings: spi-nor: " Bhaskar Upadhaya
[not found] ` <1472207269-18499-4-git-send-email-Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org>
2016-08-26 22:26 ` Scott Wood
2016-08-30 23:09 ` Rob Herring
2016-08-26 10:27 ` [PATCH 05/10] dt-bindings: pci: " Bhaskar Upadhaya
[not found] ` <1472207269-18499-5-git-send-email-Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org>
2016-08-26 22:30 ` Scott Wood [this message]
2016-08-26 10:27 ` [PATCH 06/10] dt-bindings: dspi: " Bhaskar Upadhaya
[not found] ` <1472207269-18499-6-git-send-email-Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org>
2016-08-31 16:05 ` Rob Herring
2016-08-26 10:27 ` [PATCH 07/10] dt-bindings: thermal: " Bhaskar Upadhaya
[not found] ` <1472207269-18499-7-git-send-email-Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org>
2016-08-26 22:37 ` Scott Wood
2016-08-26 10:27 ` [PATCH 08/10] dt-bindings: usb: " Bhaskar Upadhaya
[not found] ` <1472207269-18499-8-git-send-email-Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org>
2016-08-26 22:38 ` Scott Wood
2016-08-29 13:18 ` Shawn Guo
2016-08-26 10:27 ` [PATCH 09/10] dt-bindings: Update bindings with additional vendor " Bhaskar Upadhaya
[not found] ` <1472207269-18499-9-git-send-email-Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org>
2016-08-26 22:42 ` Scott Wood
2016-08-26 10:27 ` [PATCH 10/10] dt-bindings: sec: Update bindings " Bhaskar Upadhaya
[not found] ` <1472207269-18499-10-git-send-email-Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org>
2016-08-26 22:57 ` Scott Wood
2016-09-06 9:43 ` [linux-devel] " Horia Geanta Neag
[not found] ` <1472207269-18499-1-git-send-email-Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org>
2016-08-31 15:51 ` [PATCH 01/10] dt-bindings: Add compatible property " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472250628.13245.6.camel@buserror.net \
--to=oss-for+egidqehk1umjsbkqmq@public.gmane.org \
--cc=Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=stuart.yoder-3arQi8VN3Tc@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).