From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH 05/10] dt-bindings: pci: Update bindings for LS1012A Date: Fri, 26 Aug 2016 17:30:28 -0500 Message-ID: <1472250628.13245.6.camel@buserror.net> References: <1472207269-18499-1-git-send-email-Bhaskar.Upadhaya@nxp.com> <1472207269-18499-5-git-send-email-Bhaskar.Upadhaya@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1472207269-18499-5-git-send-email-Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bhaskar Upadhaya , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: stuart.yoder-3arQi8VN3Tc@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, 2016-08-26 at 15:57 +0530, Bhaskar Upadhaya wrote: > Signed-off-by: Bhaskar Upadhaya > --- >  Documentation/devicetree/bindings/pci/layerscape-pci.txt | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > index 41e9f55..5755697 100644 > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > @@ -15,6 +15,7 @@ Required properties: >  - compatible: should contain the platform identifier such as: >          "fsl,ls1021a-pcie", "snps,dw-pcie" >          "fsl,ls2080a-pcie", "fsl,ls2085a-pcie", "snps,dw-pcie" > + "fsl,ls1012a-pcie", "fsl,ls1043a-pcie" ,"snps,dw-pcie" Whitespace doesn't match. Why are you listing both ls1012a and ls1043a together?  Are they 100% compatible? Why are we updating all these bindings every time we come out with a new chip, rather than having a pattern like we did in other bindings? -Scott -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html