* [RESEND PATCH 0/4] Support the rk3399 gmac pd function
@ 2016-08-31 6:13 Caesar Wang
[not found] ` <1472624028-7082-1-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Caesar Wang @ 2016-08-31 6:13 UTC (permalink / raw)
To: Heiko Stuebner, netdev-u79uwXL29TY76Z2rM5mHXA
Cc: Mark Rutland, Catalin Marinas, Will Deacon,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Masahiro Yamada, Xing Zheng,
Brian Norris, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Shunqian Zheng, Caesar Wang, devicetree-u79uwXL29TY76Z2rM5mHXA,
Elaine Zhang, Alexandre Torgue, Arnd Bergmann, Frank Wang,
dbasehore-F7+t8E8rja9g9hUCZPvPmw, Rob Herring, Giuseppe Cavallaro,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Jianqun Xu,
Douglas Anderson, David Wu
This patch add to handle the gmac pd issue, and support
the rk3399 gmac for devicetree.
Caesar Wang (2):
arm64: dts: rockchip: support gmac for rk3399
arm64: dts: rockchip: enable the gmac for rk3399 evb board
David Wu (1):
net: stmmac: dwmac-rk: add pd_gmac support for rk3399
Roger Chen (1):
net: stmmac: dwmac-rk: fixes the gmac resume after PD on/off
arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 31 +++++++++
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 90 ++++++++++++++++++++++++++
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 28 +++++---
3 files changed, 140 insertions(+), 9 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <1472624028-7082-1-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>]
* [RESEND PATCH 3/4] arm64: dts: rockchip: support gmac for rk3399 [not found] ` <1472624028-7082-1-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org> @ 2016-08-31 6:13 ` Caesar Wang [not found] ` <1472624028-7082-4-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org> 2016-08-31 6:13 ` [RESEND PATCH 4/4] arm64: dts: rockchip: enable the gmac for rk3399 evb board Caesar Wang 1 sibling, 1 reply; 6+ messages in thread From: Caesar Wang @ 2016-08-31 6:13 UTC (permalink / raw) To: Heiko Stuebner, netdev-u79uwXL29TY76Z2rM5mHXA Cc: Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA, Brian Norris, Xing Zheng, Masahiro Yamada, Catalin Marinas, dbasehore-F7+t8E8rja9g9hUCZPvPmw, Will Deacon, Douglas Anderson, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Rob Herring, Roger Chen, David Wu, Shunqian Zheng, Jianqun Xu, Elaine Zhang, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Caesar Wang This patch adds needed gamc information for rk3399, also support the gmac pd. Signed-off-by: Roger Chen <roger.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Signed-off-by: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org> --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 90 ++++++++++++++++++++++++++++++++ 1 file changed, 90 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 32aebc8..abf27a4 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi @@ -200,6 +200,26 @@ }; }; + gmac: eth@fe300000 { + compatible = "rockchip,rk3399-gmac"; + reg = <0x0 0xfe300000 0x0 0x10000>; + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "macirq"; + clocks = <&cru SCLK_MAC>, <&cru SCLK_MAC_RX>, + <&cru SCLK_MAC_TX>, <&cru SCLK_MACREF>, + <&cru SCLK_MACREF_OUT>, <&cru ACLK_GMAC>, + <&cru PCLK_GMAC>; + clock-names = "stmmaceth", "mac_clk_rx", + "mac_clk_tx", "clk_mac_ref", + "clk_mac_refout", "aclk_mac", + "pclk_mac"; + power-domains = <&power RK3399_PD_GMAC>; + resets = <&cru SRST_A_GMAC>; + reset-names = "stmmaceth"; + rockchip,grf = <&grf>; + status = "disabled"; + }; + sdio0: dwmmc@fe310000 { compatible = "rockchip,rk3399-dw-mshc", "rockchip,rk3288-dw-mshc"; @@ -611,6 +631,11 @@ status = "disabled"; }; + qos_gmac: qos@ffa5c000 { + compatible = "syscon"; + reg = <0x0 0xffa5c000 0x0 0x20>; + }; + qos_hdcp: qos@ffa90000 { compatible = "syscon"; reg = <0x0 0xffa90000 0x0 0x20>; @@ -704,6 +729,11 @@ #size-cells = <0>; /* These power domains are grouped by VD_CENTER */ + pd_gmac@RK3399_PD_GMAC { + reg = <RK3399_PD_GMAC>; + clocks = <&cru ACLK_GMAC>; + pm_qos = <&qos_gmac>; + }; pd_iep@RK3399_PD_IEP { reg = <RK3399_PD_IEP>; clocks = <&cru ACLK_IEP>, @@ -1183,6 +1213,66 @@ drive-strength = <13>; }; + gmac { + rgmii_pins: rgmii-pins { + rockchip,pins = + /* mac_txclk */ + <3 17 RK_FUNC_1 &pcfg_pull_none_13ma>, + /* mac_rxclk */ + <3 14 RK_FUNC_1 &pcfg_pull_none>, + /* mac_mdio */ + <3 13 RK_FUNC_1 &pcfg_pull_none>, + /* mac_txen */ + <3 12 RK_FUNC_1 &pcfg_pull_none_13ma>, + /* mac_clk */ + <3 11 RK_FUNC_1 &pcfg_pull_none>, + /* mac_rxdv */ + <3 9 RK_FUNC_1 &pcfg_pull_none>, + /* mac_mdc */ + <3 8 RK_FUNC_1 &pcfg_pull_none>, + /* mac_rxd1 */ + <3 7 RK_FUNC_1 &pcfg_pull_none>, + /* mac_rxd0 */ + <3 6 RK_FUNC_1 &pcfg_pull_none>, + /* mac_txd1 */ + <3 5 RK_FUNC_1 &pcfg_pull_none_13ma>, + /* mac_txd0 */ + <3 4 RK_FUNC_1 &pcfg_pull_none_13ma>, + /* mac_rxd3 */ + <3 3 RK_FUNC_1 &pcfg_pull_none>, + /* mac_rxd2 */ + <3 2 RK_FUNC_1 &pcfg_pull_none>, + /* mac_txd3 */ + <3 1 RK_FUNC_1 &pcfg_pull_none_13ma>, + /* mac_txd2 */ + <3 0 RK_FUNC_1 &pcfg_pull_none_13ma>; + }; + + rmii_pins: rmii-pins { + rockchip,pins = + /* mac_mdio */ + <3 13 RK_FUNC_1 &pcfg_pull_none>, + /* mac_txen */ + <3 12 RK_FUNC_1 &pcfg_pull_none_13ma>, + /* mac_clk */ + <3 11 RK_FUNC_1 &pcfg_pull_none>, + /* mac_rxer */ + <3 10 RK_FUNC_1 &pcfg_pull_none>, + /* mac_rxdv */ + <3 9 RK_FUNC_1 &pcfg_pull_none>, + /* mac_mdc */ + <3 8 RK_FUNC_1 &pcfg_pull_none>, + /* mac_rxd1 */ + <3 7 RK_FUNC_1 &pcfg_pull_none>, + /* mac_rxd0 */ + <3 6 RK_FUNC_1 &pcfg_pull_none>, + /* mac_txd1 */ + <3 5 RK_FUNC_1 &pcfg_pull_none_13ma>, + /* mac_txd0 */ + <3 4 RK_FUNC_1 &pcfg_pull_none_13ma>; + }; + }; + i2c0 { i2c0_xfer: i2c0-xfer { rockchip,pins = -- 1.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <1472624028-7082-4-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>]
* Re: [RESEND PATCH 3/4] arm64: dts: rockchip: support gmac for rk3399 [not found] ` <1472624028-7082-4-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org> @ 2016-08-31 20:42 ` Doug Anderson [not found] ` <CAD=FV=XQX__rFqGLY2U5mPT8WR4P4aW5tbCqFmA+3rZunbzUZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Doug Anderson @ 2016-08-31 20:42 UTC (permalink / raw) To: Caesar Wang Cc: Heiko Stuebner, netdev-u79uwXL29TY76Z2rM5mHXA, open list:ARM/Rockchip SoC..., Brian Norris, Derek Basehore, Roger Chen, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Xing Zheng, Masahiro Yamada, Jianqun Xu, Elaine Zhang, David Wu, Shunqian Zheng, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Caesar, On Tue, Aug 30, 2016 at 11:13 PM, Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org> wrote: > This patch adds needed gamc information for rk3399, > also support the gmac pd. > > Signed-off-by: Roger Chen <roger.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org> > Signed-off-by: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org> > --- > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 90 ++++++++++++++++++++++++++++++++ > 1 file changed, 90 insertions(+) I noticed that your subject for this patch contains "RESEND" and not "v2" event though there are changes between this version and the last one. That's really confusing. This should have been "v2" and the next version should be "v3". > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 32aebc8..abf27a4 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -200,6 +200,26 @@ > }; > }; > > + gmac: eth@fe300000 { nit: on rk3288 the node was "ethernet@" instead of "eth@". Presumably "ethernet" is more correct? > + compatible = "rockchip,rk3399-gmac"; > + reg = <0x0 0xfe300000 0x0 0x10000>; > + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "macirq"; > + clocks = <&cru SCLK_MAC>, <&cru SCLK_MAC_RX>, > + <&cru SCLK_MAC_TX>, <&cru SCLK_MACREF>, > + <&cru SCLK_MACREF_OUT>, <&cru ACLK_GMAC>, > + <&cru PCLK_GMAC>; > + clock-names = "stmmaceth", "mac_clk_rx", > + "mac_clk_tx", "clk_mac_ref", > + "clk_mac_refout", "aclk_mac", > + "pclk_mac"; > + power-domains = <&power RK3399_PD_GMAC>; > + resets = <&cru SRST_A_GMAC>; > + reset-names = "stmmaceth"; > + rockchip,grf = <&grf>; > + status = "disabled"; > + }; > + > sdio0: dwmmc@fe310000 { > compatible = "rockchip,rk3399-dw-mshc", > "rockchip,rk3288-dw-mshc"; > @@ -611,6 +631,11 @@ > status = "disabled"; > }; > > + qos_gmac: qos@ffa5c000 { > + compatible = "syscon"; > + reg = <0x0 0xffa5c000 0x0 0x20>; > + }; > + > qos_hdcp: qos@ffa90000 { > compatible = "syscon"; > reg = <0x0 0xffa90000 0x0 0x20>; > @@ -704,6 +729,11 @@ > #size-cells = <0>; > > /* These power domains are grouped by VD_CENTER */ > + pd_gmac@RK3399_PD_GMAC { RK3399_PD_GMAC is not in VD_CENTER but in VD_LOGIC, right? ...so this should move. > + reg = <RK3399_PD_GMAC>; > + clocks = <&cru ACLK_GMAC>; > + pm_qos = <&qos_gmac>; > + }; IMHO it would be nice if this were broken into two patches. 1. First patch would be the power domain patch and that could land any time. You wouldn't actually be able to use the gmac but at least you'd be able to turn off its power. This would be a handy patch to be able to backport if you happened to not need Ethernet support but wanted to save power. 2. Second patch would actually add the gmac. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CAD=FV=XQX__rFqGLY2U5mPT8WR4P4aW5tbCqFmA+3rZunbzUZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [RESEND PATCH 3/4] arm64: dts: rockchip: support gmac for rk3399 [not found] ` <CAD=FV=XQX__rFqGLY2U5mPT8WR4P4aW5tbCqFmA+3rZunbzUZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2016-08-31 21:29 ` Heiko Stübner 2016-08-31 21:45 ` Doug Anderson 0 siblings, 1 reply; 6+ messages in thread From: Heiko Stübner @ 2016-08-31 21:29 UTC (permalink / raw) To: Doug Anderson Cc: Caesar Wang, netdev-u79uwXL29TY76Z2rM5mHXA, open list:ARM/Rockchip SoC..., Brian Norris, Derek Basehore, Roger Chen, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Xing Zheng, Masahiro Yamada, Jianqun Xu, Elaine Zhang, David Wu, Shunqian Zheng, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Am Mittwoch, 31. August 2016, 13:42:17 schrieb Doug Anderson: > Caesar, > > On Tue, Aug 30, 2016 at 11:13 PM, Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org> wrote: > > This patch adds needed gamc information for rk3399, > > also support the gmac pd. > > > > Signed-off-by: Roger Chen <roger.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org> > > Signed-off-by: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org> > > --- > > > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 90 > > ++++++++++++++++++++++++++++++++ 1 file changed, 90 insertions(+) > > I noticed that your subject for this patch contains "RESEND" and not > "v2" event though there are changes between this version and the last > one. That's really confusing. This should have been "v2" and the > next version should be "v3". > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 32aebc8..abf27a4 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > @@ -200,6 +200,26 @@ > > > > }; > > > > }; > > > > + gmac: eth@fe300000 { > > nit: on rk3288 the node was "ethernet@" instead of "eth@". Presumably > "ethernet" is more correct? > > > + compatible = "rockchip,rk3399-gmac"; > > + reg = <0x0 0xfe300000 0x0 0x10000>; > > + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>; > > + interrupt-names = "macirq"; > > + clocks = <&cru SCLK_MAC>, <&cru SCLK_MAC_RX>, > > + <&cru SCLK_MAC_TX>, <&cru SCLK_MACREF>, > > + <&cru SCLK_MACREF_OUT>, <&cru ACLK_GMAC>, > > + <&cru PCLK_GMAC>; > > + clock-names = "stmmaceth", "mac_clk_rx", > > + "mac_clk_tx", "clk_mac_ref", > > + "clk_mac_refout", "aclk_mac", > > + "pclk_mac"; > > + power-domains = <&power RK3399_PD_GMAC>; > > + resets = <&cru SRST_A_GMAC>; > > + reset-names = "stmmaceth"; > > + rockchip,grf = <&grf>; > > + status = "disabled"; > > + }; > > + > > > > sdio0: dwmmc@fe310000 { > > > > compatible = "rockchip,rk3399-dw-mshc", > > > > "rockchip,rk3288-dw-mshc"; > > > > @@ -611,6 +631,11 @@ > > > > status = "disabled"; > > > > }; > > > > + qos_gmac: qos@ffa5c000 { > > + compatible = "syscon"; > > + reg = <0x0 0xffa5c000 0x0 0x20>; > > + }; > > + > > > > qos_hdcp: qos@ffa90000 { > > > > compatible = "syscon"; > > reg = <0x0 0xffa90000 0x0 0x20>; > > > > @@ -704,6 +729,11 @@ > > > > #size-cells = <0>; > > > > /* These power domains are grouped by VD_CENTER */ > > > > + pd_gmac@RK3399_PD_GMAC { > > RK3399_PD_GMAC is not in VD_CENTER but in VD_LOGIC, right? ...so this > should move. > > > + reg = <RK3399_PD_GMAC>; > > + clocks = <&cru ACLK_GMAC>; > > + pm_qos = <&qos_gmac>; > > + }; > > IMHO it would be nice if this were broken into two patches. > > 1. First patch would be the power domain patch and that could land any > time. You wouldn't actually be able to use the gmac but at least > you'd be able to turn off its power. This would be a handy patch to > be able to backport if you happened to not need Ethernet support but > wanted to save power. > > 2. Second patch would actually add the gmac. according to my talk with Caesar in the real v1, the gmac even with power- domains should work just nicely even without the dts patches, as the driver core takes care of powering up the pd before probe. But I may miss some peculiarity of the dwmac? Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND PATCH 3/4] arm64: dts: rockchip: support gmac for rk3399 2016-08-31 21:29 ` Heiko Stübner @ 2016-08-31 21:45 ` Doug Anderson 0 siblings, 0 replies; 6+ messages in thread From: Doug Anderson @ 2016-08-31 21:45 UTC (permalink / raw) To: Heiko Stübner Cc: Caesar Wang, netdev, open list:ARM/Rockchip SoC..., Brian Norris, Derek Basehore, Roger Chen, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Xing Zheng, Masahiro Yamada, Jianqun Xu, Elaine Zhang, David Wu, Shunqian Zheng, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Hi, On Wed, Aug 31, 2016 at 2:29 PM, Heiko Stübner <heiko@sntech.de> wrote: >> IMHO it would be nice if this were broken into two patches. >> >> 1. First patch would be the power domain patch and that could land any >> time. You wouldn't actually be able to use the gmac but at least >> you'd be able to turn off its power. This would be a handy patch to >> be able to backport if you happened to not need Ethernet support but >> wanted to save power. >> >> 2. Second patch would actually add the gmac. > > according to my talk with Caesar in the real v1, the gmac even with power- > domains should work just nicely even without the dts patches, as the driver > core takes care of powering up the pd before probe. > > But I may miss some peculiarity of the dwmac? Nothing that I'm terribly aware of. I was just being selfish because: 1. I'm on a board where I don't need Ethernet. 2. I'm running a semi old kernel (4.4) 3. I don't want to pick back the various fixes that might be needed to make gmac work on rk3399 to that old kernel. 4. I want it very obvious that gmac isn't really supported on this old kernel on rk3399 (and having stmmac not in the device tree would make it very obvious) 5. I do want the power savings of turning the power domains off for the gmac. If this patch is broken in two then I can pick back just the power domain patch. :-P -Doug ^ permalink raw reply [flat|nested] 6+ messages in thread
* [RESEND PATCH 4/4] arm64: dts: rockchip: enable the gmac for rk3399 evb board [not found] ` <1472624028-7082-1-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org> 2016-08-31 6:13 ` [RESEND PATCH 3/4] arm64: dts: rockchip: support gmac for rk3399 Caesar Wang @ 2016-08-31 6:13 ` Caesar Wang 1 sibling, 0 replies; 6+ messages in thread From: Caesar Wang @ 2016-08-31 6:13 UTC (permalink / raw) To: Heiko Stuebner, netdev-u79uwXL29TY76Z2rM5mHXA Cc: Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA, Brian Norris, Arnd Bergmann, Masahiro Yamada, Frank Wang, Catalin Marinas, dbasehore-F7+t8E8rja9g9hUCZPvPmw, Will Deacon, Douglas Anderson, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Rob Herring, Roger Chen, Jianqun Xu, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Caesar Wang We add the required and optional properties for evb board. See the [0] to get the detail information. [0]: Documentation/devicetree/bindings/net/rockchip-dwmac.txt Signed-off-by: Roger Chen <roger.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Signed-off-by: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org> --- arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 31 +++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts index d47b4e9..ed6f2e8 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts @@ -94,12 +94,43 @@ regulator-always-on; regulator-boot-on; }; + + clkin_gmac: external-gmac-clock { + compatible = "fixed-clock"; + clock-frequency = <125000000>; + clock-output-names = "clkin_gmac"; + #clock-cells = <0>; + }; + + vcc_phy: vcc-phy-regulator { + compatible = "regulator-fixed"; + regulator-name = "vcc_phy"; + regulator-always-on; + regulator-boot-on; + }; + }; &emmc_phy { status = "okay"; }; +&gmac { + phy-supply = <&vcc_phy>; + phy-mode = "rgmii"; + clock_in_out = "input"; + snps,reset-gpio = <&gpio3 15 GPIO_ACTIVE_LOW>; + snps,reset-active-low; + snps,reset-delays-us = <0 10000 50000>; + assigned-clocks = <&cru SCLK_RMII_SRC>; + assigned-clock-parents = <&clkin_gmac>; + pinctrl-names = "default"; + pinctrl-0 = <&rgmii_pins>; + tx_delay = <0x28>; + rx_delay = <0x11>; + status = "okay"; +}; + &pwm0 { status = "okay"; }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-31 21:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-31 6:13 [RESEND PATCH 0/4] Support the rk3399 gmac pd function Caesar Wang
[not found] ` <1472624028-7082-1-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-31 6:13 ` [RESEND PATCH 3/4] arm64: dts: rockchip: support gmac for rk3399 Caesar Wang
[not found] ` <1472624028-7082-4-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-31 20:42 ` Doug Anderson
[not found] ` <CAD=FV=XQX__rFqGLY2U5mPT8WR4P4aW5tbCqFmA+3rZunbzUZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-31 21:29 ` Heiko Stübner
2016-08-31 21:45 ` Doug Anderson
2016-08-31 6:13 ` [RESEND PATCH 4/4] arm64: dts: rockchip: enable the gmac for rk3399 evb board Caesar Wang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).