From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Fritz Subject: Re: [PATCH] iio: sx9500: add final devicetree support Date: Fri, 02 Sep 2016 17:23:39 +0200 Message-ID: <1472829819.12668.3.camel@googlemail.com> References: <1472827740.1929.26.camel@googlemail.com> <1472828671.1929.32.camel@googlemail.com> Reply-To: chf.fritz-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Fabio Estevam Cc: Jonathan Cameron , Vlad Dogaru , Hartmut Knaack , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Fri, 2016-09-02 at 12:12 -0300, Fabio Estevam wrote: > On Fri, Sep 2, 2016 at 12:04 PM, Christoph Fritz > wrote: > > > Here on my board I'm using the reset pin as an open-drain with external > > pullup, so GPIO_ACTIVE_HIGH is valid. > > > > As this is an example, I don't care if it says _HIGH or _LOW. > > Then probably it is better to remove "reset-gpios" from the example. > > The driver does not parse this dt property and the reset is being done > via software command as far as I can see. What do you mean by "software command", to send a reset command by i2c? The reset GPIO is fetched in sx9500 here: See sx9500_gpio_probe(): ... data->gpiod_rst = devm_gpiod_get_index(dev, SX9500_GPIO_RESET, 0, GPIOD_OUT_HIGH); ...