devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Fritz <chf.fritz-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
To: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Vlad Dogaru <ddvlad-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>,
	linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] iio: sx9500: add final devicetree support
Date: Fri, 02 Sep 2016 18:47:13 +0200	[thread overview]
Message-ID: <1472834833.12668.11.camel@googlemail.com> (raw)
In-Reply-To: <CAOMZO5DbJLnH1wm2KuML+O36O-eSYWeGwrxE5pdKSRtB-Js-yA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Fri, 2016-09-02 at 13:16 -0300, Fabio Estevam wrote:
> On Fri, Sep 2, 2016 at 12:23 PM, Christoph Fritz
> <chf.fritz-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> wrote:
> 
> > What do you mean by "software command", to send a reset command by i2c?
> 
> Yes, by writing 0xDE into RegReset register.
> 
> >
> > The reset GPIO is fetched in sx9500 here:
> >
> > See sx9500_gpio_probe():
> > ...
> >         data->gpiod_rst = devm_gpiod_get_index(dev, SX9500_GPIO_RESET,
> >                                                0, GPIOD_OUT_HIGH);
> 
> but there is no code that actually reads the "reset-gpios" dt property.

But there is: devm_gpiod_get_index() calls gpiod_get_index() which calls
of_find_gpio() for of-string "reset-gpios".

> 
> Does your board work well without passing "reset-gpios" property?

I don't know, the driver looks that way. I'll check that. If so, I'll
fix the docu and add the reset-gpios property as optional. Okay?

Thanks
 -- Christoph

  parent reply	other threads:[~2016-09-02 16:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02 14:49 [PATCH] iio: sx9500: add final devicetree support Christoph Fritz
     [not found] ` <1472827740.1929.26.camel-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-09-02 14:53   ` Fabio Estevam
     [not found]     ` <CAOMZO5BeL1EKOQvZQoXXObttHSKxL7UQ1s2r8H4EOuROOb_YnQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-02 15:04       ` Christoph Fritz
     [not found]         ` <1472828671.1929.32.camel-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-09-02 15:12           ` Fabio Estevam
     [not found]             ` <CAOMZO5BVDS=AaSyRS0ELBiEKx3RxdstXgA_xJ6ANUzKDxdyBxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-02 15:23               ` Christoph Fritz
     [not found]                 ` <1472829819.12668.3.camel-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-09-02 16:16                   ` Fabio Estevam
     [not found]                     ` <CAOMZO5DbJLnH1wm2KuML+O36O-eSYWeGwrxE5pdKSRtB-Js-yA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-02 16:47                       ` Christoph Fritz [this message]
     [not found]                         ` <1472834833.12668.11.camel-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-09-02 18:25                           ` Fabio Estevam
     [not found]                             ` <CAOMZO5B8ttBvf-zimO5R_kgpzR2bxF73Ur0vZpBKUX8Ytbs8uQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-03 10:30                               ` [PATCH v2] " Christoph Fritz
     [not found]                                 ` <1472898600.1918.4.camel-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-09-03 11:15                                   ` Fabio Estevam
2016-09-03 11:19                                   ` Vlad Dogaru
     [not found]                                     ` <CAA+rx9Th84nt8RQpXX8MhcN9ghhdJN1KBuGfd2oY59_77BiBGA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-03 14:27                                       ` Jonathan Cameron
2016-09-12 15:44                                   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472834833.12668.11.camel@googlemail.com \
    --to=chf.fritz-gm/ye1e23mwn+bqq9rbeug@public.gmane.org \
    --cc=ddvlad-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \
    --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).