From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Fritz Subject: Re: [PATCH] iio: sx9500: add final devicetree support Date: Fri, 02 Sep 2016 18:47:13 +0200 Message-ID: <1472834833.12668.11.camel@googlemail.com> References: <1472827740.1929.26.camel@googlemail.com> <1472828671.1929.32.camel@googlemail.com> <1472829819.12668.3.camel@googlemail.com> Reply-To: chf.fritz-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Fabio Estevam Cc: Jonathan Cameron , Vlad Dogaru , Hartmut Knaack , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Fri, 2016-09-02 at 13:16 -0300, Fabio Estevam wrote: > On Fri, Sep 2, 2016 at 12:23 PM, Christoph Fritz > wrote: > > > What do you mean by "software command", to send a reset command by i2c? > > Yes, by writing 0xDE into RegReset register. > > > > > The reset GPIO is fetched in sx9500 here: > > > > See sx9500_gpio_probe(): > > ... > > data->gpiod_rst = devm_gpiod_get_index(dev, SX9500_GPIO_RESET, > > 0, GPIOD_OUT_HIGH); > > but there is no code that actually reads the "reset-gpios" dt property. But there is: devm_gpiod_get_index() calls gpiod_get_index() which calls of_find_gpio() for of-string "reset-gpios". > > Does your board work well without passing "reset-gpios" property? I don't know, the driver looks that way. I'll check that. If so, I'll fix the docu and add the reset-gpios property as optional. Okay? Thanks -- Christoph