* [PATCH v2] mfd: arizona: Add DT options for max_channels_clocked and PDM speaker config
@ 2016-08-31 9:25 Richard Fitzgerald
2016-08-31 12:15 ` Lee Jones
[not found] ` <1472635543-21577-1-git-send-email-rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
0 siblings, 2 replies; 6+ messages in thread
From: Richard Fitzgerald @ 2016-08-31 9:25 UTC (permalink / raw)
To: lee.jones-QSEj5FYQhm4dnm+yROfE0A
Cc: patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
This patch adds DT settings for the max_channels_clocked, spk_fmt and
spk_mute pdata.
Signed-off-by: Richard Fitzgerald <rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
---
Documentation/devicetree/bindings/mfd/arizona.txt | 11 ++++++++
drivers/mfd/arizona-core.c | 31 +++++++++++++++++++++++
2 files changed, 42 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
index a6e2ea41..6eaf006 100644
--- a/Documentation/devicetree/bindings/mfd/arizona.txt
+++ b/Documentation/devicetree/bindings/mfd/arizona.txt
@@ -85,6 +85,17 @@ Optional properties:
present, the number of values should be less than or equal to the
number of inputs, unspecified inputs will use the chip default.
+ - wlf,max-channels-clocked : The maximum number of channels to be clocked on
+ each AIF, useful for I2S systems with multiple data lines being mastered.
+ Specify one cell for each AIF, specify zero for AIFs that should be handled
+ normally.
+
+ - wlf,spk-fmt : PDM speaker data format, must contain 2 cells (OUT5 and OUT6).
+ See the datasheet for values.
+
+ - wlf,spk-mute : PDM speaker mute setting, must contain 2 cells (OUT5 and OUT6).
+ See the datasheet for values.
+
- DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
they are being externally supplied. As covered in
Documentation/devicetree/bindings/regulator/regulator.txt
diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index b95ff2d..36a9633 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -816,6 +816,37 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
count++;
}
+ count = 0;
+ of_property_for_each_u32(arizona->dev->of_node,
+ "wlf,max-channels-clocked",
+ prop, cur, val) {
+ if (count == ARRAY_SIZE(pdata->max_channels_clocked))
+ break;
+
+ pdata->max_channels_clocked[count] = val;
+ count++;
+ }
+
+ count = 0;
+ of_property_for_each_u32(arizona->dev->of_node, "wlf,spk-fmt", prop,
+ cur, val) {
+ if (count == ARRAY_SIZE(pdata->spk_fmt))
+ break;
+
+ pdata->spk_fmt[count] = val;
+ count++;
+ }
+
+ count = 0;
+ of_property_for_each_u32(arizona->dev->of_node, "wlf,spk-mute", prop,
+ cur, val) {
+ if (count == ARRAY_SIZE(pdata->spk_mute))
+ break;
+
+ pdata->spk_mute[count] = val;
+ count++;
+ }
+
return 0;
}
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] mfd: arizona: Add DT options for max_channels_clocked and PDM speaker config
2016-08-31 9:25 [PATCH v2] mfd: arizona: Add DT options for max_channels_clocked and PDM speaker config Richard Fitzgerald
@ 2016-08-31 12:15 ` Lee Jones
[not found] ` <1472635543-21577-1-git-send-email-rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
1 sibling, 0 replies; 6+ messages in thread
From: Lee Jones @ 2016-08-31 12:15 UTC (permalink / raw)
To: Richard Fitzgerald; +Cc: patches, devicetree, linux-kernel
Requires a DT Ack.
On Wed, 31 Aug 2016, Richard Fitzgerald wrote:
> This patch adds DT settings for the max_channels_clocked, spk_fmt and
> spk_mute pdata.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> ---
> Documentation/devicetree/bindings/mfd/arizona.txt | 11 ++++++++
> drivers/mfd/arizona-core.c | 31 +++++++++++++++++++++++
> 2 files changed, 42 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index a6e2ea41..6eaf006 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -85,6 +85,17 @@ Optional properties:
> present, the number of values should be less than or equal to the
> number of inputs, unspecified inputs will use the chip default.
>
> + - wlf,max-channels-clocked : The maximum number of channels to be clocked on
> + each AIF, useful for I2S systems with multiple data lines being mastered.
> + Specify one cell for each AIF, specify zero for AIFs that should be handled
> + normally.
> +
> + - wlf,spk-fmt : PDM speaker data format, must contain 2 cells (OUT5 and OUT6).
> + See the datasheet for values.
> +
> + - wlf,spk-mute : PDM speaker mute setting, must contain 2 cells (OUT5 and OUT6).
> + See the datasheet for values.
> +
> - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
> they are being externally supplied. As covered in
> Documentation/devicetree/bindings/regulator/regulator.txt
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index b95ff2d..36a9633 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -816,6 +816,37 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
> count++;
> }
>
> + count = 0;
> + of_property_for_each_u32(arizona->dev->of_node,
> + "wlf,max-channels-clocked",
> + prop, cur, val) {
> + if (count == ARRAY_SIZE(pdata->max_channels_clocked))
> + break;
> +
> + pdata->max_channels_clocked[count] = val;
> + count++;
> + }
> +
> + count = 0;
> + of_property_for_each_u32(arizona->dev->of_node, "wlf,spk-fmt", prop,
> + cur, val) {
> + if (count == ARRAY_SIZE(pdata->spk_fmt))
> + break;
> +
> + pdata->spk_fmt[count] = val;
> + count++;
> + }
> +
> + count = 0;
> + of_property_for_each_u32(arizona->dev->of_node, "wlf,spk-mute", prop,
> + cur, val) {
> + if (count == ARRAY_SIZE(pdata->spk_mute))
> + break;
> +
> + pdata->spk_mute[count] = val;
> + count++;
> + }
> +
> return 0;
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <1472635543-21577-1-git-send-email-rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>]
* Re: [PATCH v2] mfd: arizona: Add DT options for max_channels_clocked and PDM speaker config
[not found] ` <1472635543-21577-1-git-send-email-rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
@ 2016-09-02 15:34 ` Rob Herring
2016-09-02 15:56 ` Richard Fitzgerald
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2016-09-02 15:34 UTC (permalink / raw)
To: Richard Fitzgerald
Cc: lee.jones-QSEj5FYQhm4dnm+yROfE0A,
patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Wed, Aug 31, 2016 at 10:25:43AM +0100, Richard Fitzgerald wrote:
> This patch adds DT settings for the max_channels_clocked, spk_fmt and
> spk_mute pdata.
>
> Signed-off-by: Richard Fitzgerald <rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
> ---
> Documentation/devicetree/bindings/mfd/arizona.txt | 11 ++++++++
Binding looks fine, but...
> drivers/mfd/arizona-core.c | 31 +++++++++++++++++++++++
> 2 files changed, 42 insertions(+)
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index b95ff2d..36a9633 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -816,6 +816,37 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
> count++;
> }
>
> + count = 0;
> + of_property_for_each_u32(arizona->dev->of_node,
> + "wlf,max-channels-clocked",
> + prop, cur, val) {
> + if (count == ARRAY_SIZE(pdata->max_channels_clocked))
> + break;
> +
> + pdata->max_channels_clocked[count] = val;
> + count++;
> + }
of_property_read_u32_array doesn't work for you?
> +
> + count = 0;
> + of_property_for_each_u32(arizona->dev->of_node, "wlf,spk-fmt", prop,
> + cur, val) {
> + if (count == ARRAY_SIZE(pdata->spk_fmt))
> + break;
> +
> + pdata->spk_fmt[count] = val;
> + count++;
> + }
> +
> + count = 0;
> + of_property_for_each_u32(arizona->dev->of_node, "wlf,spk-mute", prop,
> + cur, val) {
> + if (count == ARRAY_SIZE(pdata->spk_mute))
> + break;
> +
> + pdata->spk_mute[count] = val;
> + count++;
> + }
> +
> return 0;
> }
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] mfd: arizona: Add DT options for max_channels_clocked and PDM speaker config
2016-09-02 15:34 ` Rob Herring
@ 2016-09-02 15:56 ` Richard Fitzgerald
[not found] ` <1472831784.4359.6.camel-WeElTRBN8n0bEPBeyYQi64iQ8/zYDDdY1BehtkLrGTY@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Richard Fitzgerald @ 2016-09-02 15:56 UTC (permalink / raw)
To: Rob Herring; +Cc: lee.jones, patches, devicetree, linux-kernel
On Fri, 2016-09-02 at 10:34 -0500, Rob Herring wrote:
> On Wed, Aug 31, 2016 at 10:25:43AM +0100, Richard Fitzgerald wrote:
> > This patch adds DT settings for the max_channels_clocked, spk_fmt and
> > spk_mute pdata.
> >
> > Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> > ---
> > Documentation/devicetree/bindings/mfd/arizona.txt | 11 ++++++++
>
> Binding looks fine, but...
>
> > drivers/mfd/arizona-core.c | 31 +++++++++++++++++++++++
> > 2 files changed, 42 insertions(+)
>
> > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> > index b95ff2d..36a9633 100644
> > --- a/drivers/mfd/arizona-core.c
> > +++ b/drivers/mfd/arizona-core.c
> > @@ -816,6 +816,37 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
> > count++;
> > }
> >
> > + count = 0;
> > + of_property_for_each_u32(arizona->dev->of_node,
> > + "wlf,max-channels-clocked",
> > + prop, cur, val) {
> > + if (count == ARRAY_SIZE(pdata->max_channels_clocked))
> > + break;
> > +
> > + pdata->max_channels_clocked[count] = val;
> > + count++;
> > + }
>
> of_property_read_u32_array doesn't work for you?
No, it doesn't, because it doesn't read a variable-sized array.
>
> > +
> > + count = 0;
> > + of_property_for_each_u32(arizona->dev->of_node, "wlf,spk-fmt", prop,
> > + cur, val) {
> > + if (count == ARRAY_SIZE(pdata->spk_fmt))
> > + break;
> > +
> > + pdata->spk_fmt[count] = val;
> > + count++;
> > + }
> > +
> > + count = 0;
> > + of_property_for_each_u32(arizona->dev->of_node, "wlf,spk-mute", prop,
> > + cur, val) {
> > + if (count == ARRAY_SIZE(pdata->spk_mute))
> > + break;
> > +
> > + pdata->spk_mute[count] = val;
> > + count++;
> > + }
> > +
> > return 0;
> > }
> >
> > --
> > 1.9.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-05 9:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-31 9:25 [PATCH v2] mfd: arizona: Add DT options for max_channels_clocked and PDM speaker config Richard Fitzgerald
2016-08-31 12:15 ` Lee Jones
[not found] ` <1472635543-21577-1-git-send-email-rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2016-09-02 15:34 ` Rob Herring
2016-09-02 15:56 ` Richard Fitzgerald
[not found] ` <1472831784.4359.6.camel-WeElTRBN8n0bEPBeyYQi64iQ8/zYDDdY1BehtkLrGTY@public.gmane.org>
2016-09-02 17:51 ` Rob Herring
[not found] ` <CAL_JsqJpO0U3KggMddM4HB5ZNN4V2RW1ih9iQYUuvFihhS_jkA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-05 9:22 ` Richard Fitzgerald
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).