From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasanthakumar Thiagarajan Subject: Re: [PATCH 31/49] ath11k: add mac.c Date: Tue, 27 Aug 2019 16:13:35 +0530 Message-ID: <14737343f1925a771ddd8dadf0f2b5a3@codeaurora.org> References: <1566316095-27507-1-git-send-email-kvalo@codeaurora.org> <1566316095-27507-32-git-send-email-kvalo@codeaurora.org> <8736hvu6e6.fsf@toke.dk> <875zmqsudn.fsf@toke.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <875zmqsudn.fsf-LJ9M9ZcSy1A@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: Kalle Valo , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ath11k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 2019-08-21 15:38, Toke Høiland-Jørgensen wrote: > Vasanthakumar Thiagarajan writes: > >> On 2019-08-20 22:21, Toke Høiland-Jørgensen wrote: >>> [... snip ... ] >>> >>>> +static const struct ieee80211_ops ath11k_ops = { >>>> + .tx = ath11k_mac_op_tx, >>> >>> No wake_tx_queue? :( >> >> Yes, packet queueing is handled in firmware. This makes sense >> especially when we enable 802.11 encap offload support where most of >> the data path processing in mac80211 will be skipped and packet is >> given to driver/firmware in 802.3 format itself. Then firmware would >> take care of all the classification, queueing and encapsulation >> operations. > > Well, so does ath10k, and yet we still saw a significant improvement by > moving queueing back into the host where it can be handled by the > FQ-CoDel-enabled queueing structure. > Sure, we could probably try that with ath11k as well at some point when we have a baseline with HE support. Vasanth