public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
	guptarud@gmail.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	"Rudraksha Gupta" <guptarud@gmail.com>,
	"Ondrej Jirman" <megi@xff.cz>,
	"Martijn Braam" <martijn@brixit.nl>,
	"Kamil Trzciński" <ayufan@ayufan.eu>
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Remove interrupt GPIO for WiFi for the Pinephone Pro
Date: Tue, 13 Jan 2026 11:26:21 +0100	[thread overview]
Message-ID: <14738774.lVVuGzaMjS@diego> (raw)
In-Reply-To: <20260112-ppp_connectivity-v1-3-284d6e83b212@gmail.com>

Am Dienstag, 13. Januar 2026, 07:42:26 Mitteleuropäische Normalzeit schrieb Rudraksha Gupta via B4 Relay:
> From: Ondrej Jirman <megi@xff.cz>
> 
> Wifi is currently unusable if interrupts are defined. Let's remove them
> so that Wifi networks are actually discoverable.

Please don't describe not what you're doing but why.

The interrupt seems to the one that is connected to wifi, so I'd expect
a description why that causes problems first, instead of going
"doesn't work for me" - "just remove it" .

As the below just looks like a temporary hack until the real cause is
found.

> Co-developed-by: Martijn Braam <martijn@brixit.nl>
> Signed-off-by: Martijn Braam <martijn@brixit.nl>
> Co-developed-by: Kamil Trzciński <ayufan@ayufan.eu>
> Signed-off-by: Kamil Trzciński <ayufan@ayufan.eu>
> Signed-off-by: Ondrej Jirman <megi@xff.cz>
> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> index 97d0bf455258..69bb9de4ce55 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> @@ -834,9 +834,6 @@ &sdio0 {
>  	brcmf: wifi@1 {
>  		compatible = "brcm,bcm4329-fmac";
>  		reg = <1>;
> -		interrupt-parent = <&gpio4>;
> -		interrupts = <RK_PD0 IRQ_TYPE_LEVEL_HIGH>;
> -		interrupt-names = "host-wake";
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&wifi_host_wake_l>;
>  	};
> 
> 

Thanks
Heiko



  parent reply	other threads:[~2026-01-13 10:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13  6:42 [PATCH 0/3] Pinephone Pro Connectivity: Adding Modem, Bluetooth, and Wi-Fi Rudraksha Gupta via B4 Relay
2026-01-13  6:42 ` [PATCH 1/3] arm64: dts: rockchip: Add modem to the Pinephone Pro Rudraksha Gupta via B4 Relay
2026-01-13  7:22   ` Krzysztof Kozlowski
2026-01-14  5:57     ` Danct12
2026-01-13 20:47   ` Ondřej Jirman
2026-01-13  6:42 ` [PATCH 2/3] mfd: rk8xx-core: Configure `rk808-clkout2` function Rudraksha Gupta via B4 Relay
2026-01-13 10:23   ` Heiko Stübner
2026-01-13 11:04   ` Lee Jones
2026-01-13 20:20   ` Ondřej Jirman
2026-01-13  6:42 ` [PATCH 3/3] arm64: dts: rockchip: Remove interrupt GPIO for WiFi for the Pinephone Pro Rudraksha Gupta via B4 Relay
2026-01-13  7:23   ` Krzysztof Kozlowski
2026-01-13 10:26   ` Heiko Stübner [this message]
2026-01-13 21:22   ` Ondřej Jirman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14738774.lVVuGzaMjS@diego \
    --to=heiko@sntech.de \
    --cc=ayufan@ayufan.eu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=guptarud@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=martijn@brixit.nl \
    --cc=megi@xff.cz \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox