* [PATCH v5] devicetree: bindings: uart: Add new compatible string for ZynqMP
@ 2016-09-26 14:06 Nava kishore Manne
2016-10-03 18:42 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Nava kishore Manne @ 2016-09-26 14:06 UTC (permalink / raw)
To: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
jslaby-IBi9RG/b67k, michal.simek-gjFFaj9aHVfQT0dZR+AlfA,
soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA,
linux-serial-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
punnaia-gjFFaj9aHVfQT0dZR+AlfA
Cc: Nava kishore Manne, Nava kishore Manne
From: Nava kishore Manne <nava.manne-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
This patch Adds the new compatible string for ZynqMP SoC.
Signed-off-by: Nava kishore Manne <navam-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
---
Changes for v5:
-Fixed some minor comments.
Changes for v4:
-Modified the ChangeLog comment.
Changes for v3:
-Added changeLog comment.
Changes for v2:
-None
Documentation/devicetree/bindings/serial/cdns,uart.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.txt b/Documentation/devicetree/bindings/serial/cdns,uart.txt
index a3eb154..30c885c 100644
--- a/Documentation/devicetree/bindings/serial/cdns,uart.txt
+++ b/Documentation/devicetree/bindings/serial/cdns,uart.txt
@@ -1,7 +1,9 @@
Binding for Cadence UART Controller
Required properties:
-- compatible : should be "cdns,uart-r1p8", or "xlnx,xuartps"
+- compatible :
+ Use "cdns,uart-r1p8", or "xlnx,xuartps" for Zynq-7xxx SoC.
+ Use "cdns,uart-r1p12" for Zynq Ultrascale+ MPSoC.
- reg: Should contain UART controller registers location and length.
- interrupts: Should contain UART controller interrupts.
- clocks: Must contain phandles to the UART clocks
--
2.1.2
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v5] devicetree: bindings: uart: Add new compatible string for ZynqMP
2016-09-26 14:06 [PATCH v5] devicetree: bindings: uart: Add new compatible string for ZynqMP Nava kishore Manne
@ 2016-10-03 18:42 ` Rob Herring
2016-10-05 12:23 ` Nava kishore Manne
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2016-10-03 18:42 UTC (permalink / raw)
To: Nava kishore Manne
Cc: gregkh, mark.rutland, jslaby, michal.simek, soren.brinkmann,
linux-serial, devicetree, linux-kernel, linux-arm-kernel, punnaia,
Nava kishore Manne
On Mon, Sep 26, 2016 at 07:36:41PM +0530, Nava kishore Manne wrote:
> From: Nava kishore Manne <nava.manne@xilinx.com>
>
> This patch Adds the new compatible string for ZynqMP SoC.
>
> Signed-off-by: Nava kishore Manne <navam@xilinx.com>
> ---
> Changes for v5:
> -Fixed some minor comments.
Not a useful changelog. The point of these comments is to remind the
reviewers of what they commented on.
> Changes for v4:
> -Modified the ChangeLog comment.
> Changes for v3:
> -Added changeLog comment.
> Changes for v2:
> -None
>
> Documentation/devicetree/bindings/serial/cdns,uart.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.txt b/Documentation/devicetree/bindings/serial/cdns,uart.txt
> index a3eb154..30c885c 100644
> --- a/Documentation/devicetree/bindings/serial/cdns,uart.txt
> +++ b/Documentation/devicetree/bindings/serial/cdns,uart.txt
> @@ -1,7 +1,9 @@
> Binding for Cadence UART Controller
>
> Required properties:
> -- compatible : should be "cdns,uart-r1p8", or "xlnx,xuartps"
> +- compatible :
> + Use "cdns,uart-r1p8", or "xlnx,xuartps" for Zynq-7xxx SoC.
This is still not right. It was wrong before, but you are touching it so
make it right.
OR doesn't match the dts files. It is AND and the opposite order.
xlnx,xuartps wasn't the best naming, but it's in use so we'll have to
live with it for zynq-7xxx.
> + Use "cdns,uart-r1p12" for Zynq Ultrascale+ MPSoC.
What I meant here was this should have something like "xlnx,mpsoc-uart"
as the first compatible with "cdns,uart-r1p12" as the second. Not sure
if "mpsoc" is the best name here.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v5] devicetree: bindings: uart: Add new compatible string for ZynqMP
2016-10-03 18:42 ` Rob Herring
@ 2016-10-05 12:23 ` Nava kishore Manne
[not found] ` <C89496FEAE474D468F30D558A9468D9F26D2AB89-4lKfpRxZ5enZMOc0yg5rMog+Gb3gawCHQz34XiSyOiE@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Nava kishore Manne @ 2016-10-05 12:23 UTC (permalink / raw)
To: Rob Herring
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
gregkh@linuxfoundation.org, michal.simek@xilinx.com,
linux-kernel@vger.kernel.org, Soren Brinkmann,
linux-serial@vger.kernel.org, jslaby@suse.com,
Punnaiah Choudary Kalluri, linux-arm-kernel@lists.infradead.org
Hi Rob,
Thanks for the review...
> > Changes for v5:
> > -Fixed some minor comments.
>
> Not a useful changelog. The point of these comments is to remind the
> reviewers of what they commented on.
Ok will take care from next version onwards...
> > Required properties:
> > -- compatible : should be "cdns,uart-r1p8", or "xlnx,xuartps"
> > +- compatible :
> > + Use "cdns,uart-r1p8", or "xlnx,xuartps" for Zynq-7xxx SoC.
>
> This is still not right. It was wrong before, but you are touching it so make it
> right.
>
> OR doesn't match the dts files. It is AND and the opposite order.
>
> xlnx,xuartps wasn't the best naming, but it's in use so we'll have to live with it
> for zynq-7xxx.
>
> > + Use "cdns,uart-r1p12" for Zynq Ultrascale+ MPSoC.
>
> What I meant here was this should have something like "xlnx,mpsoc-uart"
> as the first compatible with "cdns,uart-r1p12" as the second. Not sure if
> "mpsoc" is the best name here.
You mean something like below
Use "xlnx,xuartps" or "cdns,uart-r1p8" for Zynq-7xxx SoC.
Use "xlnx,zynqmp-uart" or " cdns,uart-r1p12" for Zynq Ultrascale+ MPSoC.
Please correct me if my understanding is wrong.
Regards,
Navakishore.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-05 12:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-26 14:06 [PATCH v5] devicetree: bindings: uart: Add new compatible string for ZynqMP Nava kishore Manne
2016-10-03 18:42 ` Rob Herring
2016-10-05 12:23 ` Nava kishore Manne
[not found] ` <C89496FEAE474D468F30D558A9468D9F26D2AB89-4lKfpRxZ5enZMOc0yg5rMog+Gb3gawCHQz34XiSyOiE@public.gmane.org>
2016-10-05 12:52 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).