* [PATCH] ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes
@ 2016-09-30 9:17 Brian Kim
[not found] ` <1475227059-17462-1-git-send-email-brian.kim-vC+yAUbXFBlQ0OI7PeSoCw@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Brian Kim @ 2016-09-30 9:17 UTC (permalink / raw)
To: linux-usb, linux-amlogic, khilman, carlo
Cc: mark.rutland, devicetree, johnyoun, catalin.marinas, will.deacon,
kishon, robh+dt, moon.linux, linux-arm-kernel
Enable both gxbb USB controller and add a 5V regulator for the OTG port
VBUS
Signed-off-by: Brian Kim <brian.kim@hardkernel.com>
---
.../arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 29 ++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 8d89edc..997c671 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -64,6 +64,18 @@
reg = <0x0 0x0 0x0 0x80000000>;
};
+ usb_pwr: regulator-usb-pwrs {
+ compatible = "regulator-fixed";
+
+ regulator-name = "USB_PWR";
+
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+
+ gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
leds {
compatible = "gpio-leds";
blue {
@@ -149,6 +161,23 @@
pinctrl-names = "default";
};
+&usb0_phy {
+ status = "okay";
+ phy-supply = <&usb_pwr>;
+};
+
+&usb1_phy {
+ status = "okay";
+};
+
+&usb0 {
+ status = "okay";
+};
+
+&usb1 {
+ status = "okay";
+};
+
/* SD */
&sd_emmc_b {
status = "okay";
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1475227059-17462-1-git-send-email-brian.kim-vC+yAUbXFBlQ0OI7PeSoCw@public.gmane.org>]
* Re: [PATCH] ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes [not found] ` <1475227059-17462-1-git-send-email-brian.kim-vC+yAUbXFBlQ0OI7PeSoCw@public.gmane.org> @ 2016-09-30 15:49 ` Kevin Hilman [not found] ` <7h7f9tgzg8.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Kevin Hilman @ 2016-09-30 15:49 UTC (permalink / raw) To: Brian Kim Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, carlo-KA+7E9HrN00dnm+yROfE0A, mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA, will.deacon-5wv7dgnIgG8, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, catalin.marinas-5wv7dgnIgG8, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, johnyoun-HKixBCOQz3hWk0Htik3J/w, kishon-l0cyMroinI0, moon.linux-vC+yAUbXFBlQ0OI7PeSoCw Brian Kim <brian.kim-vC+yAUbXFBlQ0OI7PeSoCw@public.gmane.org> writes: > Enable both gxbb USB controller and add a 5V regulator for the OTG port > VBUS > > Signed-off-by: Brian Kim <brian.kim-vC+yAUbXFBlQ0OI7PeSoCw@public.gmane.org> Thanks for the patch. In the future, please state what branch the patch should apply to when not using mainline. Because of the sd_emmc nodes in your patch, I could tell that it was based on my integ branch so was able to figure it out, but it's very helpful to maintainers if you state the branch and/or any dependencies explicity. > --- > .../arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 29 ++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > index 8d89edc..997c671 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > @@ -64,6 +64,18 @@ > reg = <0x0 0x0 0x0 0x80000000>; > }; > > + usb_pwr: regulator-usb-pwrs { minor nit: since this is specific to the OTG part, can you call this usb_otg_pwr? ... > + compatible = "regulator-fixed"; > + > + regulator-name = "USB_PWR"; ... and rename this also? > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + > + gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > + Thanks Kevin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <7h7f9tgzg8.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>]
* Re: [PATCH] ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes [not found] ` <7h7f9tgzg8.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> @ 2016-10-04 2:00 ` Brian Kim 0 siblings, 0 replies; 3+ messages in thread From: Brian Kim @ 2016-10-04 2:00 UTC (permalink / raw) To: Kevin Hilman Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, carlo-KA+7E9HrN00dnm+yROfE0A, mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA, will.deacon-5wv7dgnIgG8, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, catalin.marinas-5wv7dgnIgG8, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, johnyoun-HKixBCOQz3hWk0Htik3J/w, kishon-l0cyMroinI0, moon.linux-vC+yAUbXFBlQ0OI7PeSoCw On 2016년 10월 01일 00:49, Kevin Hilman wrote: > Brian Kim <brian.kim-vC+yAUbXFBlQ0OI7PeSoCw@public.gmane.org> writes: > >> Enable both gxbb USB controller and add a 5V regulator for the OTG port >> VBUS >> >> Signed-off-by: Brian Kim <brian.kim-vC+yAUbXFBlQ0OI7PeSoCw@public.gmane.org> > Thanks for the patch. > > In the future, please state what branch the patch should apply to when > not using mainline. Because of the sd_emmc nodes in your patch, I could > tell that it was based on my integ branch so was able to figure it out, > but it's very helpful to maintainers if you state the branch and/or any > dependencies explicity. Okay, I will do next time. I guessed the branch is your latest working branch by the commit logs. > >> --- >> .../arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 29 ++++++++++++++++++++++ >> 1 file changed, 29 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts >> index 8d89edc..997c671 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts >> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts >> @@ -64,6 +64,18 @@ >> reg = <0x0 0x0 0x0 0x80000000>; >> }; >> >> + usb_pwr: regulator-usb-pwrs { > minor nit: since this is specific to the OTG part, can you call this > usb_otg_pwr? ... Sure. > >> + compatible = "regulator-fixed"; >> + >> + regulator-name = "USB_PWR"; > ... and rename this also? Yes, I will change the name to "USB_OTG_PWR". > >> + regulator-min-microvolt = <5000000>; >> + regulator-max-microvolt = <5000000>; >> + >> + gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>; >> + enable-active-high; >> + }; >> + > Thanks > > Kevin > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-04 2:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-30 9:17 [PATCH] ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes Brian Kim
[not found] ` <1475227059-17462-1-git-send-email-brian.kim-vC+yAUbXFBlQ0OI7PeSoCw@public.gmane.org>
2016-09-30 15:49 ` Kevin Hilman
[not found] ` <7h7f9tgzg8.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-10-04 2:00 ` Brian Kim
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).