From mboxrd@z Thu Jan 1 00:00:00 1970 From: Horng-Shyang Liao Subject: Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver Date: Fri, 30 Sep 2016 17:47:09 +0800 Message-ID: <1475228829.3658.1.camel@mtksdaap41> References: <1473039885-24009-1-git-send-email-hs.liao@mediatek.com> <1473039885-24009-3-git-send-email-hs.liao@mediatek.com> <1475204778.13398.28.camel@mtksdaap41> <1475225778.25044.35.camel@mtksdaap41> <1475226691.13398.35.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1475226691.13398.35.camel@mtksdaap41> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: CK Hu Cc: Rob Herring , Matthias Brugger , Jassi Brar , Daniel Kurtz , Sascha Hauer , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Sascha Hauer , Philipp Zabel , Nicolas Boichat , cawa cheng , Bibby Hsieh , YT Shen , Daoyuan Huang , Damon Chu , Josh-YC Liu , Glory Hung List-Id: devicetree@vger.kernel.org On Fri, 2016-09-30 at 17:11 +0800, CK Hu wrote: > Hi, HS: > > One comment inline > > On Fri, 2016-09-30 at 16:56 +0800, Horng-Shyang Liao wrote: > > Hi CK, > > > > Please see my inline reply. > > > > On Fri, 2016-09-30 at 11:06 +0800, CK Hu wrote: > > > Hi, HS: > > > > > > On Mon, 2016-09-05 at 09:44 +0800, HS Liao wrote: > > > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > > > CMDQ is used to help write registers with critical time limitation, > > > > such as updating display configuration during the vblank. It controls > > > > Global Command Engine (GCE) hardware to achieve this requirement. > > > > Currently, CMDQ only supports display related hardwares, but we expect > > > > it can be extended to other hardwares for future requirements. > > > > > > > > Signed-off-by: HS Liao > > > > Signed-off-by: CK Hu > > > > --- > > > > > > [snip...] > > > > > > > + > > > > +struct cmdq_task { > > > > + struct cmdq *cmdq; > > > > + struct list_head list_entry; > > > > + void *va_base; > > > > + dma_addr_t pa_base; > > > > + size_t cmd_buf_size; /* command occupied size */ > > > > + size_t buf_size; /* real buffer size */ > > > > + bool finalized; > > > > + struct cmdq_thread *thread; > > > > > > I think thread info could be removed from cmdq_task. Only > > > cmdq_task_handle_error() and cmdq_task_insert_into_thread() use > > > task->thread and caller of both function has the thread info. So you > > > could just pass thread info into these two function and remove thread > > > info in cmdq_task. > > > > This modification will remove 1 pointer but add 2 pointers. Moreover, > > more pointers will need to be delivered between functions for future > > extension. IMHO, it would be better to keep thread pointer inside > > cmdq_task. > > > > > > + struct cmdq_task_cb cb; > > > > > > I think this callback function is equal to mailbox client tx_done > > > callback. It's better to use already-defined interface rather than > > > creating your own. > > > > This is because CMDQ driver allows different callback functions for > > different tasks, but mailbox only allows one callback function per > > channel. But, I think I can add a wrapper for tx_done to call CMDQ > > callback functions. So, I will use tx_done in CMDQ v15. > > Up to now, one callback function for one channel is enough for DRM. So > 'different callback function for different sent-message' looks like an > advanced function. Maybe you should not include it in first patch. > > Regards, > CK Hi CK, OK. I will do it. Thanks, HS [snip...] -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html