* [PATCH v7 0/5] ARM: dts: imx6q: Add Engicam i.CoreM6 dts
@ 2016-10-14 9:27 Jagan Teki
[not found] ` <1476437243-13297-1-git-send-email-jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>
` (3 more replies)
0 siblings, 4 replies; 12+ messages in thread
From: Jagan Teki @ 2016-10-14 9:27 UTC (permalink / raw)
To: Shawn Guo
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Matteo Lisi,
Michael Trimarchi, Jagan Teki
This is series add dts support for Engicam I.Core M6 qdl modules. just
rebased on top of linux-next of previous set[1].
[1] http://www.spinics.net/lists/kernel/msg2358233.html
Jagan Teki (5):
ARM: dts: imx6q: Add Engicam i.CoreM6 Quad/Dual initial support
ARM: dts: imx6q: Add Engicam i.CoreM6 DualLite/Solo initial support
ARM: dts: imx6qdl-icore: Add usbhost support
ARM: dts: imx6qdl-icore: Add usbotg support
ARM: dts: imx6qdl-icore: Add FEC support
arch/arm/boot/dts/Makefile | 2 +
arch/arm/boot/dts/imx6dl-icore.dts | 59 ++++++++
arch/arm/boot/dts/imx6q-icore.dts | 59 ++++++++
arch/arm/boot/dts/imx6qdl-icore.dtsi | 271 +++++++++++++++++++++++++++++++++++
4 files changed, 391 insertions(+)
create mode 100644 arch/arm/boot/dts/imx6dl-icore.dts
create mode 100644 arch/arm/boot/dts/imx6q-icore.dts
create mode 100644 arch/arm/boot/dts/imx6qdl-icore.dtsi
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread[parent not found: <1476437243-13297-1-git-send-email-jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>]
* [PATCH v7 1/5] ARM: dts: imx6q: Add Engicam i.CoreM6 Quad/Dual initial support [not found] ` <1476437243-13297-1-git-send-email-jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org> @ 2016-10-14 9:27 ` Jagan Teki 2016-10-14 9:27 ` [PATCH v7 2/5] ARM: dts: imx6q: Add Engicam i.CoreM6 DualLite/Solo " Jagan Teki 2016-10-14 9:27 ` [PATCH v7 5/5] ARM: dts: imx6qdl-icore: Add FEC support Jagan Teki 2 siblings, 0 replies; 12+ messages in thread From: Jagan Teki @ 2016-10-14 9:27 UTC (permalink / raw) To: Shawn Guo Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Matteo Lisi, Michael Trimarchi, Jagan Teki, Sascha Hauer, Fabio Estevam From: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> i.CoreM6 Quad/Dual modules are system on module solutions manufactured by Engicam with following characteristics: CPU NXP i.MX6 DQ, 800MHz RAM 1GB, 32, 64 bit, DDR3-800/1066 NAND SLC,512MB Power supply Single 5V MAX LCD RES FULLHD and more info at http://www.engicam.com/en/products/embedded/som/sodimm/i-core-m6s-dl-d-q Cc: Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Cc: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org> Cc: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: Matteo Lisi <matteo.lisi-4s7YQHO/iPVBDgjK7y7TUQ@public.gmane.org> Cc: Michael Trimarchi <michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> Signed-off-by: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> --- Changes for v7: - none Changes for v6: - none Changes for v5: - removed fsl,legacy-bch-geometry property from gpmi node Changes for v4: - new patch Changes for v3: - Use compatible as engicam,imx6-icore instead of fsl,imx6-icore - Update IOMUX value for can1 and can2 nodes - Added reg_3p3v for can1 and can2 nodes Changes for v2: - s/oaky/okay/g arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/imx6q-icore.dts | 59 +++++++++++ arch/arm/boot/dts/imx6qdl-icore.dtsi | 196 +++++++++++++++++++++++++++++++++++ 3 files changed, 256 insertions(+) create mode 100644 arch/arm/boot/dts/imx6q-icore.dts create mode 100644 arch/arm/boot/dts/imx6qdl-icore.dtsi diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index befcd26..89a3eea 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -381,6 +381,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \ imx6q-gw553x.dtb \ imx6q-h100.dtb \ imx6q-hummingboard.dtb \ + imx6q-icore.dtb \ imx6q-icore-rqs.dtb \ imx6q-marsboard.dtb \ imx6q-nitrogen6x.dtb \ diff --git a/arch/arm/boot/dts/imx6q-icore.dts b/arch/arm/boot/dts/imx6q-icore.dts new file mode 100644 index 0000000..025f543 --- /dev/null +++ b/arch/arm/boot/dts/imx6q-icore.dts @@ -0,0 +1,59 @@ +/* + * Copyright (C) 2016 Amarula Solutions B.V. + * Copyright (C) 2016 Engicam S.r.l. + * + * This file is dual-licensed: you can use it either under the terms + * of the GPL or the X11 license, at your option. Note that this dual + * licensing only applies to this file, and not this project as a + * whole. + * + * a) This file is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * version 2 as published by the Free Software Foundation. + * + * This file is distributed in the hope that it will be useful + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * Or, alternatively + * + * b) Permission is hereby granted, free of charge, to any person + * obtaining a copy of this software and associated documentation + * files (the "Software"), to deal in the Software without + * restriction, including without limitation the rights to use + * copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following + * conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. + */ + +/dts-v1/; + +#include "imx6q.dtsi" +#include "imx6qdl-icore.dtsi" + +/ { + model = "Engicam i.CoreM6 Quad/Dual Starter Kit"; + compatible = "engicam,imx6-icore", "fsl,imx6q"; +}; + +&can1 { + status = "okay"; +}; + +&can2 { + status = "okay"; +}; diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi new file mode 100644 index 0000000..f424cd5 --- /dev/null +++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi @@ -0,0 +1,196 @@ +/* + * Copyright (C) 2016 Amarula Solutions B.V. + * Copyright (C) 2016 Engicam S.r.l. + * + * This file is dual-licensed: you can use it either under the terms + * of the GPL or the X11 license, at your option. Note that this dual + * licensing only applies to this file, and not this project as a + * whole. + * + * a) This file is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * version 2 as published by the Free Software Foundation. + * + * This file is distributed in the hope that it will be useful + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * Or, alternatively + * + * b) Permission is hereby granted, free of charge, to any person + * obtaining a copy of this software and associated documentation + * files (the "Software"), to deal in the Software without + * restriction, including without limitation the rights to use + * copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following + * conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. + */ + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> + +/ { + memory { + reg = <0x10000000 0x80000000>; + }; + + reg_3p3v: regulator-3p3v { + compatible = "regulator-fixed"; + regulator-name = "3P3V"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; +}; + +&can1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_flexcan1>; + xceiver-supply = <®_3p3v>; +}; + +&can2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_flexcan2>; + xceiver-supply = <®_3p3v>; +}; + +&clks { + assigned-clocks = <&clks IMX6QDL_CLK_LVDS2_SEL>; + assigned-clock-parents = <&clks IMX6QDL_CLK_OSC>; +}; + +&gpmi { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_gpmi_nand>; + nand-on-flash-bbt; + status = "okay"; +}; + +&i2c1 { + clock-frequency = <100000>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c1>; + status = "okay"; +}; + +&i2c2 { + clock-frequency = <100000>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c2>; + status = "okay"; +}; + +&i2c3 { + clock-frequency = <100000>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c3>; + status = "okay"; +}; + +&uart4 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_uart4>; + status = "okay"; +}; + +&usdhc1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usdhc1>; + cd-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>; + no-1-8-v; + status = "okay"; +}; + +&iomuxc { + pinctrl_flexcan1: flexcan1grp { + fsl,pins = < + MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x1b020 + MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x1b020 + >; + }; + + pinctrl_flexcan2: flexcan2grp { + fsl,pins = < + MX6QDL_PAD_KEY_COL4__FLEXCAN2_TX 0x1b020 + MX6QDL_PAD_KEY_ROW4__FLEXCAN2_RX 0x1b020 + >; + }; + + pinctrl_gpmi_nand: gpmi-nand { + fsl,pins = < + MX6QDL_PAD_NANDF_CLE__NAND_CLE 0xb0b1 + MX6QDL_PAD_NANDF_ALE__NAND_ALE 0xb0b1 + MX6QDL_PAD_NANDF_WP_B__NAND_WP_B 0xb0b1 + MX6QDL_PAD_NANDF_RB0__NAND_READY_B 0xb000 + MX6QDL_PAD_NANDF_CS0__NAND_CE0_B 0xb0b1 + MX6QDL_PAD_NANDF_CS1__NAND_CE1_B 0xb0b1 + MX6QDL_PAD_SD4_CMD__NAND_RE_B 0xb0b1 + MX6QDL_PAD_SD4_CLK__NAND_WE_B 0xb0b1 + MX6QDL_PAD_NANDF_D0__NAND_DATA00 0xb0b1 + MX6QDL_PAD_NANDF_D1__NAND_DATA01 0xb0b1 + MX6QDL_PAD_NANDF_D2__NAND_DATA02 0xb0b1 + MX6QDL_PAD_NANDF_D3__NAND_DATA03 0xb0b1 + MX6QDL_PAD_NANDF_D4__NAND_DATA04 0xb0b1 + MX6QDL_PAD_NANDF_D5__NAND_DATA05 0xb0b1 + MX6QDL_PAD_NANDF_D6__NAND_DATA06 0xb0b1 + MX6QDL_PAD_NANDF_D7__NAND_DATA07 0xb0b1 + MX6QDL_PAD_SD4_DAT0__NAND_DQS 0x00b1 + >; + }; + + pinctrl_i2c1: i2c1grp { + fsl,pins = < + MX6QDL_PAD_EIM_D21__I2C1_SCL 0x4001b8b1 + MX6QDL_PAD_EIM_D28__I2C1_SDA 0x4001b8b1 + >; + }; + + pinctrl_i2c2: i2c2grp { + fsl,pins = < + MX6QDL_PAD_EIM_EB2__I2C2_SCL 0x4001b8b1 + MX6QDL_PAD_KEY_ROW3__I2C2_SDA 0x4001b8b1 + >; + }; + + pinctrl_i2c3: i2c3grp { + fsl,pins = < + MX6QDL_PAD_GPIO_5__I2C3_SCL 0x4001b8b1 + MX6QDL_PAD_EIM_D18__I2C3_SDA 0x4001b8b1 + MX6QDL_PAD_GPIO_0__CCM_CLKO1 0x130b0 + >; + }; + + pinctrl_uart4: uart4grp { + fsl,pins = < + MX6QDL_PAD_KEY_COL0__UART4_TX_DATA 0x1b0b1 + MX6QDL_PAD_KEY_ROW0__UART4_RX_DATA 0x1b0b1 + >; + }; + + pinctrl_usdhc1: usdhc1grp { + fsl,pins = < + MX6QDL_PAD_SD1_CMD__SD1_CMD 0x17070 + MX6QDL_PAD_SD1_CLK__SD1_CLK 0x10070 + MX6QDL_PAD_SD1_DAT0__SD1_DATA0 0x17070 + MX6QDL_PAD_SD1_DAT1__SD1_DATA1 0x17070 + MX6QDL_PAD_SD1_DAT2__SD1_DATA2 0x17070 + MX6QDL_PAD_SD1_DAT3__SD1_DATA3 0x17070 + >; + }; +}; -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v7 2/5] ARM: dts: imx6q: Add Engicam i.CoreM6 DualLite/Solo initial support [not found] ` <1476437243-13297-1-git-send-email-jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org> 2016-10-14 9:27 ` [PATCH v7 1/5] ARM: dts: imx6q: Add Engicam i.CoreM6 Quad/Dual initial support Jagan Teki @ 2016-10-14 9:27 ` Jagan Teki 2016-10-14 9:27 ` [PATCH v7 5/5] ARM: dts: imx6qdl-icore: Add FEC support Jagan Teki 2 siblings, 0 replies; 12+ messages in thread From: Jagan Teki @ 2016-10-14 9:27 UTC (permalink / raw) To: Shawn Guo Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Matteo Lisi, Michael Trimarchi, Jagan Teki, Sascha Hauer, Fabio Estevam From: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> i.CoreM6 DualLite/Solo modules are system on module solutions manufactured by Engicam with following characteristics: CPU NXP i.MX6 DL, 800MHz RAM 1GB, 32, 64 bit, DDR3-800/1066 NAND SLC,512MB Power supply Single 5V MAX LCD RES FULLHD and more info at http://www.engicam.com/en/products/embedded/som/sodimm/i-core-m6s-dl-d-q Cc: Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Cc: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org> Cc: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: Matteo Lisi <matteo.lisi-4s7YQHO/iPVBDgjK7y7TUQ@public.gmane.org> Cc: Michael Trimarchi <michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> Signed-off-by: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> --- Changes for v7: - none Changes for v6: - none Changes for v5: - none Changes for v4: - new patch Changes for v3: - Use compatible as engicam,imx6-icore instead of fsl,imx6-icore Changes for v2: - s/oaky/okay/g arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/imx6dl-icore.dts | 59 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 60 insertions(+) create mode 100644 arch/arm/boot/dts/imx6dl-icore.dts diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 89a3eea..8f8b14b 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -340,6 +340,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \ imx6dl-gw552x.dtb \ imx6dl-gw553x.dtb \ imx6dl-hummingboard.dtb \ + imx6dl-icore.dtb \ imx6dl-nit6xlite.dtb \ imx6dl-nitrogen6x.dtb \ imx6dl-phytec-pbab01.dtb \ diff --git a/arch/arm/boot/dts/imx6dl-icore.dts b/arch/arm/boot/dts/imx6dl-icore.dts new file mode 100644 index 0000000..aec332c --- /dev/null +++ b/arch/arm/boot/dts/imx6dl-icore.dts @@ -0,0 +1,59 @@ +/* + * Copyright (C) 2016 Amarula Solutions B.V. + * Copyright (C) 2016 Engicam S.r.l. + * + * This file is dual-licensed: you can use it either under the terms + * of the GPL or the X11 license, at your option. Note that this dual + * licensing only applies to this file, and not this project as a + * whole. + * + * a) This file is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * version 2 as published by the Free Software Foundation. + * + * This file is distributed in the hope that it will be useful + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * Or, alternatively + * + * b) Permission is hereby granted, free of charge, to any person + * obtaining a copy of this software and associated documentation + * files (the "Software"), to deal in the Software without + * restriction, including without limitation the rights to use + * copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following + * conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. + */ + +/dts-v1/; + +#include "imx6dl.dtsi" +#include "imx6qdl-icore.dtsi" + +/ { + model = "Engicam i.CoreM6 DualLite/Solo Starter Kit"; + compatible = "engicam,imx6-icore", "fsl,imx6dl"; +}; + +&can1 { + status = "okay"; +}; + +&can2 { + status = "okay"; +}; -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v7 5/5] ARM: dts: imx6qdl-icore: Add FEC support [not found] ` <1476437243-13297-1-git-send-email-jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org> 2016-10-14 9:27 ` [PATCH v7 1/5] ARM: dts: imx6q: Add Engicam i.CoreM6 Quad/Dual initial support Jagan Teki 2016-10-14 9:27 ` [PATCH v7 2/5] ARM: dts: imx6q: Add Engicam i.CoreM6 DualLite/Solo " Jagan Teki @ 2016-10-14 9:27 ` Jagan Teki 2016-10-21 1:31 ` Shawn Guo 2 siblings, 1 reply; 12+ messages in thread From: Jagan Teki @ 2016-10-14 9:27 UTC (permalink / raw) To: Shawn Guo Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Matteo Lisi, Michael Trimarchi, Jagan Teki, Sascha Hauer, Fabio Estevam From: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> Add FEC support for Engicam i.CoreM6 dql modules. Observed similar 'eth0: link is not ready' issue which was discussed in [1] due rmii mode with external ref_clk, so added clock node along with the properties mentioned by Shawn in [2] FEC link log: ------------ $ ifconfig eth0 up [ 27.905187] SMSC LAN8710/LAN8720 2188000.ethernet:00: attached PHY driver [SMSC LAN8710/LAN8720] (mii_bus:phy_addr=2188000.ethernet:00, irq=-1) [ 27.918982] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready [1] https://patchwork.kernel.org/patch/3491061/ [2] https://patchwork.kernel.org/patch/3490511/ Cc: Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Cc: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org> Cc: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: Matteo Lisi <matteo.lisi-4s7YQHO/iPVBDgjK7y7TUQ@public.gmane.org> Cc: Michael Trimarchi <michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> Signed-off-by: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> --- Changes for v7: - none Changes for v6: - none Changes for v5: - new patch arch/arm/boot/dts/imx6qdl-icore.dtsi | 37 ++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi index 4e79858..972f48f 100644 --- a/arch/arm/boot/dts/imx6qdl-icore.dtsi +++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi @@ -48,6 +48,18 @@ reg = <0x10000000 0x80000000>; }; + clocks { + #address-cells = <1>; + #size-cells = <0>; + + rmii_clk: clock@0 { + compatible = "fixed-clock"; + reg = <0>; + #clock-cells = <0>; + clock-frequency = <25000000>; /* 25MHz for example */ + }; + }; + reg_3p3v: regulator-3p3v { compatible = "regulator-fixed"; regulator-name = "3P3V"; @@ -93,6 +105,15 @@ assigned-clock-parents = <&clks IMX6QDL_CLK_OSC>; }; +&fec { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_enet>; + phy-reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>; + clocks = <&clks 117>, <&clks 117>, <&rmii_clk>; + phy-mode = "rmii"; + status = "okay"; +}; + &gpmi { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_gpmi_nand>; @@ -150,6 +171,22 @@ }; &iomuxc { + pinctrl_enet: enetgrp { + fsl,pins = < + MX6QDL_PAD_ENET_CRS_DV__ENET_RX_EN 0x1b0b0 + MX6QDL_PAD_GPIO_16__ENET_REF_CLK 0x1b0b1 + MX6QDL_PAD_ENET_TX_EN__ENET_TX_EN 0x1b0b0 + MX6QDL_PAD_ENET_RXD1__ENET_RX_DATA1 0x1b0b0 + MX6QDL_PAD_ENET_RXD0__ENET_RX_DATA0 0x1b0b0 + MX6QDL_PAD_ENET_TXD1__ENET_TX_DATA1 0x1b0b0 + MX6QDL_PAD_ENET_TXD0__ENET_TX_DATA0 0x1b0b0 + MX6QDL_PAD_ENET_MDC__ENET_MDC 0x1b0b0 + MX6QDL_PAD_ENET_MDIO__ENET_MDIO 0x1b0b0 + MX6QDL_PAD_ENET_REF_CLK__GPIO1_IO23 0x1b0b0 + MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x1b0b0 + >; + }; + pinctrl_flexcan1: flexcan1grp { fsl,pins = < MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x1b020 -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v7 5/5] ARM: dts: imx6qdl-icore: Add FEC support 2016-10-14 9:27 ` [PATCH v7 5/5] ARM: dts: imx6qdl-icore: Add FEC support Jagan Teki @ 2016-10-21 1:31 ` Shawn Guo 0 siblings, 0 replies; 12+ messages in thread From: Shawn Guo @ 2016-10-21 1:31 UTC (permalink / raw) To: Jagan Teki Cc: linux-arm-kernel, devicetree, linux-kernel, Matteo Lisi, Michael Trimarchi, Jagan Teki, Sascha Hauer, Fabio Estevam On Fri, Oct 14, 2016 at 02:57:23PM +0530, Jagan Teki wrote: > From: Jagan Teki <jagan@amarulasolutions.com> > > Add FEC support for Engicam i.CoreM6 dql modules. > > Observed similar 'eth0: link is not ready' issue which was > discussed in [1] due rmii mode with external ref_clk, so added > clock node along with the properties mentioned by Shawn in [2] > > FEC link log: > ------------ > $ ifconfig eth0 up > [ 27.905187] SMSC LAN8710/LAN8720 2188000.ethernet:00: attached PHY driver > [SMSC LAN8710/LAN8720] (mii_bus:phy_addr=2188000.ethernet:00, irq=-1) > [ 27.918982] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready > > [1] https://patchwork.kernel.org/patch/3491061/ > [2] https://patchwork.kernel.org/patch/3490511/ > > Cc: Sascha Hauer <kernel@pengutronix.de> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Matteo Lisi <matteo.lisi@engicam.com> > Cc: Michael Trimarchi <michael@amarulasolutions.com> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Changes for v7: > - none > Changes for v6: > - none > Changes for v5: > - new patch > > arch/arm/boot/dts/imx6qdl-icore.dtsi | 37 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi > index 4e79858..972f48f 100644 > --- a/arch/arm/boot/dts/imx6qdl-icore.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi > @@ -48,6 +48,18 @@ > reg = <0x10000000 0x80000000>; > }; > > + clocks { > + #address-cells = <1>; > + #size-cells = <0>; DT maintainers do not like this container node. So please, just like fix regulator node, put the fixed clock directly under root and give the node an unique name like clock-xxx. > + > + rmii_clk: clock@0 { > + compatible = "fixed-clock"; > + reg = <0>; > + #clock-cells = <0>; > + clock-frequency = <25000000>; /* 25MHz for example */ > + }; > + }; > + > reg_3p3v: regulator-3p3v { > compatible = "regulator-fixed"; > regulator-name = "3P3V"; > @@ -93,6 +105,15 @@ > assigned-clock-parents = <&clks IMX6QDL_CLK_OSC>; > }; > > +&fec { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_enet>; > + phy-reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>; > + clocks = <&clks 117>, <&clks 117>, <&rmii_clk>; s/117/IMX6QDL_CLK_ENET Shawn > + phy-mode = "rmii"; > + status = "okay"; > +}; > + > &gpmi { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_gpmi_nand>; > @@ -150,6 +171,22 @@ > }; > > &iomuxc { > + pinctrl_enet: enetgrp { > + fsl,pins = < > + MX6QDL_PAD_ENET_CRS_DV__ENET_RX_EN 0x1b0b0 > + MX6QDL_PAD_GPIO_16__ENET_REF_CLK 0x1b0b1 > + MX6QDL_PAD_ENET_TX_EN__ENET_TX_EN 0x1b0b0 > + MX6QDL_PAD_ENET_RXD1__ENET_RX_DATA1 0x1b0b0 > + MX6QDL_PAD_ENET_RXD0__ENET_RX_DATA0 0x1b0b0 > + MX6QDL_PAD_ENET_TXD1__ENET_TX_DATA1 0x1b0b0 > + MX6QDL_PAD_ENET_TXD0__ENET_TX_DATA0 0x1b0b0 > + MX6QDL_PAD_ENET_MDC__ENET_MDC 0x1b0b0 > + MX6QDL_PAD_ENET_MDIO__ENET_MDIO 0x1b0b0 > + MX6QDL_PAD_ENET_REF_CLK__GPIO1_IO23 0x1b0b0 > + MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x1b0b0 > + >; > + }; > + > pinctrl_flexcan1: flexcan1grp { > fsl,pins = < > MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x1b020 > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v7 3/5] ARM: dts: imx6qdl-icore: Add usbhost support 2016-10-14 9:27 [PATCH v7 0/5] ARM: dts: imx6q: Add Engicam i.CoreM6 dts Jagan Teki [not found] ` <1476437243-13297-1-git-send-email-jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org> @ 2016-10-14 9:27 ` Jagan Teki 2016-10-21 1:21 ` Shawn Guo 2016-10-14 9:27 ` [PATCH v7 4/5] ARM: dts: imx6qdl-icore: Add usbotg support Jagan Teki 2016-10-18 12:00 ` [PATCH v7 0/5] ARM: dts: imx6q: Add Engicam i.CoreM6 dts Jagan Teki 3 siblings, 1 reply; 12+ messages in thread From: Jagan Teki @ 2016-10-14 9:27 UTC (permalink / raw) To: Shawn Guo Cc: linux-arm-kernel, devicetree, linux-kernel, Matteo Lisi, Michael Trimarchi, Jagan Teki, Sascha Hauer, Fabio Estevam From: Jagan Teki <jagan@amarulasolutions.com> Add usbhost support for Engicam i.CoreM6 dql modules. Cc: Sascha Hauer <kernel@pengutronix.de> Cc: Fabio Estevam <fabio.estevam@nxp.com> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Matteo Lisi <matteo.lisi@engicam.com> Cc: Michael Trimarchi <michael@amarulasolutions.com> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- Changes for v7: - none Changes for v6: - none Changes for v5: - none Changes for v4: - new patch arch/arm/boot/dts/imx6qdl-icore.dtsi | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi index f424cd5..ffec879 100644 --- a/arch/arm/boot/dts/imx6qdl-icore.dtsi +++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi @@ -56,6 +56,15 @@ regulator-boot-on; regulator-always-on; }; + + reg_usb_h1_vbus: usb_h1_vbus { + compatible = "regulator-fixed"; + regulator-name = "usb_h1_vbus"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-boot-on; + regulator-always-on; + }; }; &can1 { @@ -109,6 +118,12 @@ status = "okay"; }; +&usbh1 { + vbus-supply = <®_usb_h1_vbus>; + disable-over-current; + status = "okay"; +}; + &usdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_usdhc1>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v7 3/5] ARM: dts: imx6qdl-icore: Add usbhost support 2016-10-14 9:27 ` [PATCH v7 3/5] ARM: dts: imx6qdl-icore: Add usbhost support Jagan Teki @ 2016-10-21 1:21 ` Shawn Guo 0 siblings, 0 replies; 12+ messages in thread From: Shawn Guo @ 2016-10-21 1:21 UTC (permalink / raw) To: Jagan Teki Cc: linux-arm-kernel, devicetree, linux-kernel, Matteo Lisi, Michael Trimarchi, Jagan Teki, Sascha Hauer, Fabio Estevam On Fri, Oct 14, 2016 at 02:57:21PM +0530, Jagan Teki wrote: > From: Jagan Teki <jagan@amarulasolutions.com> > > Add usbhost support for Engicam i.CoreM6 dql modules. > > Cc: Sascha Hauer <kernel@pengutronix.de> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Matteo Lisi <matteo.lisi@engicam.com> > Cc: Michael Trimarchi <michael@amarulasolutions.com> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Changes for v7: > - none > Changes for v6: > - none > Changes for v5: > - none > Changes for v4: > - new patch > > arch/arm/boot/dts/imx6qdl-icore.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi > index f424cd5..ffec879 100644 > --- a/arch/arm/boot/dts/imx6qdl-icore.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi > @@ -56,6 +56,15 @@ > regulator-boot-on; > regulator-always-on; > }; > + > + reg_usb_h1_vbus: usb_h1_vbus { Hyphen instead of underscore should be used in node name. Also please name fixed regulator in the following schema: reg_xxx: regulator-xxx { ... }; Shawn > + compatible = "regulator-fixed"; > + regulator-name = "usb_h1_vbus"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > }; > > &can1 { > @@ -109,6 +118,12 @@ > status = "okay"; > }; > > +&usbh1 { > + vbus-supply = <®_usb_h1_vbus>; > + disable-over-current; > + status = "okay"; > +}; > + > &usdhc1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_usdhc1>; > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v7 4/5] ARM: dts: imx6qdl-icore: Add usbotg support 2016-10-14 9:27 [PATCH v7 0/5] ARM: dts: imx6q: Add Engicam i.CoreM6 dts Jagan Teki [not found] ` <1476437243-13297-1-git-send-email-jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org> 2016-10-14 9:27 ` [PATCH v7 3/5] ARM: dts: imx6qdl-icore: Add usbhost support Jagan Teki @ 2016-10-14 9:27 ` Jagan Teki [not found] ` <1476437243-13297-5-git-send-email-jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org> 2016-10-18 12:00 ` [PATCH v7 0/5] ARM: dts: imx6q: Add Engicam i.CoreM6 dts Jagan Teki 3 siblings, 1 reply; 12+ messages in thread From: Jagan Teki @ 2016-10-14 9:27 UTC (permalink / raw) To: Shawn Guo Cc: linux-arm-kernel, devicetree, linux-kernel, Matteo Lisi, Michael Trimarchi, Jagan Teki, Sascha Hauer, Fabio Estevam From: Jagan Teki <jagan@amarulasolutions.com> Add usbotg support for Engicam i.CoreM6 dql modules. Cc: Sascha Hauer <kernel@pengutronix.de> Cc: Fabio Estevam <fabio.estevam@nxp.com> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Matteo Lisi <matteo.lisi@engicam.com> Cc: Michael Trimarchi <michael@amarulasolutions.com> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- Changes for v7: - none Changes for v6: - none Changes for v5: - none Changes for v4: - new patch arch/arm/boot/dts/imx6qdl-icore.dtsi | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi index ffec879..4e79858 100644 --- a/arch/arm/boot/dts/imx6qdl-icore.dtsi +++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi @@ -65,6 +65,15 @@ regulator-boot-on; regulator-always-on; }; + + reg_usb_otg_vbus: usb_otg_vbus { + compatible = "regulator-fixed"; + regulator-name = "usb_otg_vbus"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-boot-on; + regulator-always-on; + }; }; &can1 { @@ -124,6 +133,14 @@ status = "okay"; }; +&usbotg { + vbus-supply = <®_usb_otg_vbus>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbotg>; + disable-over-current; + status = "okay"; +}; + &usdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_usdhc1>; @@ -198,6 +215,12 @@ >; }; + pinctrl_usbotg: usbotggrp { + fsl,pins = < + MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059 + >; + }; + pinctrl_usdhc1: usdhc1grp { fsl,pins = < MX6QDL_PAD_SD1_CMD__SD1_CMD 0x17070 -- 2.7.4 ^ permalink raw reply related [flat|nested] 12+ messages in thread
[parent not found: <1476437243-13297-5-git-send-email-jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>]
* Re: [PATCH v7 4/5] ARM: dts: imx6qdl-icore: Add usbotg support [not found] ` <1476437243-13297-5-git-send-email-jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org> @ 2016-10-21 1:25 ` Shawn Guo 0 siblings, 0 replies; 12+ messages in thread From: Shawn Guo @ 2016-10-21 1:25 UTC (permalink / raw) To: Jagan Teki Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Matteo Lisi, Michael Trimarchi, Jagan Teki, Sascha Hauer, Fabio Estevam On Fri, Oct 14, 2016 at 02:57:22PM +0530, Jagan Teki wrote: > From: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> > > Add usbotg support for Engicam i.CoreM6 dql modules. > > Cc: Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> > Cc: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org> > Cc: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > Cc: Matteo Lisi <matteo.lisi-4s7YQHO/iPVBDgjK7y7TUQ@public.gmane.org> > Cc: Michael Trimarchi <michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> > Signed-off-by: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> > --- > Changes for v7: > - none > Changes for v6: > - none > Changes for v5: > - none > Changes for v4: > - new patch > > arch/arm/boot/dts/imx6qdl-icore.dtsi | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi > index ffec879..4e79858 100644 > --- a/arch/arm/boot/dts/imx6qdl-icore.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi > @@ -65,6 +65,15 @@ > regulator-boot-on; > regulator-always-on; > }; > + > + reg_usb_otg_vbus: usb_otg_vbus { Same as host patch, please fix the node name. Shawn > + compatible = "regulator-fixed"; > + regulator-name = "usb_otg_vbus"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > }; > > &can1 { > @@ -124,6 +133,14 @@ > status = "okay"; > }; > > +&usbotg { > + vbus-supply = <®_usb_otg_vbus>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usbotg>; > + disable-over-current; > + status = "okay"; > +}; > + > &usdhc1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_usdhc1>; > @@ -198,6 +215,12 @@ > >; > }; > > + pinctrl_usbotg: usbotggrp { > + fsl,pins = < > + MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059 > + >; > + }; > + > pinctrl_usdhc1: usdhc1grp { > fsl,pins = < > MX6QDL_PAD_SD1_CMD__SD1_CMD 0x17070 > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v7 0/5] ARM: dts: imx6q: Add Engicam i.CoreM6 dts 2016-10-14 9:27 [PATCH v7 0/5] ARM: dts: imx6q: Add Engicam i.CoreM6 dts Jagan Teki ` (2 preceding siblings ...) 2016-10-14 9:27 ` [PATCH v7 4/5] ARM: dts: imx6qdl-icore: Add usbotg support Jagan Teki @ 2016-10-18 12:00 ` Jagan Teki 2016-10-21 1:35 ` Shawn Guo 3 siblings, 1 reply; 12+ messages in thread From: Jagan Teki @ 2016-10-18 12:00 UTC (permalink / raw) To: Shawn Guo Cc: devicetree, Matteo Lisi, linux-kernel@vger.kernel.org, Jagan Teki, Michael Trimarchi, linux-arm-kernel@lists.infradead.org Hi Shawn, On Fri, Oct 14, 2016 at 2:57 PM, Jagan Teki <jteki@openedev.com> wrote: > This is series add dts support for Engicam I.Core M6 qdl modules. just > rebased on top of linux-next of previous set[1]. > > [1] http://www.spinics.net/lists/kernel/msg2358233.html > > Jagan Teki (5): > ARM: dts: imx6q: Add Engicam i.CoreM6 Quad/Dual initial support > ARM: dts: imx6q: Add Engicam i.CoreM6 DualLite/Solo initial support > ARM: dts: imx6qdl-icore: Add usbhost support > ARM: dts: imx6qdl-icore: Add usbotg support > ARM: dts: imx6qdl-icore: Add FEC support > > arch/arm/boot/dts/Makefile | 2 + > arch/arm/boot/dts/imx6dl-icore.dts | 59 ++++++++ > arch/arm/boot/dts/imx6q-icore.dts | 59 ++++++++ > arch/arm/boot/dts/imx6qdl-icore.dtsi | 271 +++++++++++++++++++++++++++++++++++ > 4 files changed, 391 insertions(+) > create mode 100644 arch/arm/boot/dts/imx6dl-icore.dts > create mode 100644 arch/arm/boot/dts/imx6q-icore.dts > create mode 100644 arch/arm/boot/dts/imx6qdl-icore.dtsi Can you pick this series? thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v7 0/5] ARM: dts: imx6q: Add Engicam i.CoreM6 dts 2016-10-18 12:00 ` [PATCH v7 0/5] ARM: dts: imx6q: Add Engicam i.CoreM6 dts Jagan Teki @ 2016-10-21 1:35 ` Shawn Guo 2016-10-21 7:55 ` Jagan Teki 0 siblings, 1 reply; 12+ messages in thread From: Shawn Guo @ 2016-10-21 1:35 UTC (permalink / raw) To: Jagan Teki Cc: devicetree, Matteo Lisi, linux-kernel@vger.kernel.org, Jagan Teki, Michael Trimarchi, linux-arm-kernel@lists.infradead.org On Tue, Oct 18, 2016 at 05:30:28PM +0530, Jagan Teki wrote: > Hi Shawn, > > On Fri, Oct 14, 2016 at 2:57 PM, Jagan Teki <jteki@openedev.com> wrote: > > This is series add dts support for Engicam I.Core M6 qdl modules. just > > rebased on top of linux-next of previous set[1]. > > > > [1] http://www.spinics.net/lists/kernel/msg2358233.html > > > > Jagan Teki (5): > > ARM: dts: imx6q: Add Engicam i.CoreM6 Quad/Dual initial support > > ARM: dts: imx6q: Add Engicam i.CoreM6 DualLite/Solo initial support > > ARM: dts: imx6qdl-icore: Add usbhost support > > ARM: dts: imx6qdl-icore: Add usbotg support > > ARM: dts: imx6qdl-icore: Add FEC support > > > > arch/arm/boot/dts/Makefile | 2 + > > arch/arm/boot/dts/imx6dl-icore.dts | 59 ++++++++ > > arch/arm/boot/dts/imx6q-icore.dts | 59 ++++++++ > > arch/arm/boot/dts/imx6qdl-icore.dtsi | 271 +++++++++++++++++++++++++++++++++++ > > 4 files changed, 391 insertions(+) > > create mode 100644 arch/arm/boot/dts/imx6dl-icore.dts > > create mode 100644 arch/arm/boot/dts/imx6q-icore.dts > > create mode 100644 arch/arm/boot/dts/imx6qdl-icore.dtsi > > Can you pick this series? Sorry for the delay. The first two patches look good, and I had a couple of small comments on the other 3. Also, for the initial board support submission like this, you do not need to split it per device support. That said, please squash the series into one patch when resending. Shawn ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v7 0/5] ARM: dts: imx6q: Add Engicam i.CoreM6 dts 2016-10-21 1:35 ` Shawn Guo @ 2016-10-21 7:55 ` Jagan Teki 0 siblings, 0 replies; 12+ messages in thread From: Jagan Teki @ 2016-10-21 7:55 UTC (permalink / raw) To: Shawn Guo Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Matteo Lisi, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michael Trimarchi, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org On Fri, Oct 21, 2016 at 7:05 AM, Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > On Tue, Oct 18, 2016 at 05:30:28PM +0530, Jagan Teki wrote: >> Hi Shawn, >> >> On Fri, Oct 14, 2016 at 2:57 PM, Jagan Teki <jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org> wrote: >> > This is series add dts support for Engicam I.Core M6 qdl modules. just >> > rebased on top of linux-next of previous set[1]. >> > >> > [1] http://www.spinics.net/lists/kernel/msg2358233.html >> > >> > Jagan Teki (5): >> > ARM: dts: imx6q: Add Engicam i.CoreM6 Quad/Dual initial support >> > ARM: dts: imx6q: Add Engicam i.CoreM6 DualLite/Solo initial support >> > ARM: dts: imx6qdl-icore: Add usbhost support >> > ARM: dts: imx6qdl-icore: Add usbotg support >> > ARM: dts: imx6qdl-icore: Add FEC support >> > >> > arch/arm/boot/dts/Makefile | 2 + >> > arch/arm/boot/dts/imx6dl-icore.dts | 59 ++++++++ >> > arch/arm/boot/dts/imx6q-icore.dts | 59 ++++++++ >> > arch/arm/boot/dts/imx6qdl-icore.dtsi | 271 +++++++++++++++++++++++++++++++++++ >> > 4 files changed, 391 insertions(+) >> > create mode 100644 arch/arm/boot/dts/imx6dl-icore.dts >> > create mode 100644 arch/arm/boot/dts/imx6q-icore.dts >> > create mode 100644 arch/arm/boot/dts/imx6qdl-icore.dtsi >> >> Can you pick this series? > > Sorry for the delay. The first two patches look good, and I had a > couple of small comments on the other 3. Also, for the initial board > support submission like this, you do not need to split it per device > support. That said, please squash the series into one patch when > resending. Sent v8 by squash the usb host and otg with first patch and second and third one keep separated as one is new board dts and other one though it is FEC support it also have a rmii_clk addition which is kind of new compared to other qdl dtsi files. So please let me know if have any more comments. thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-10-21 7:55 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-14 9:27 [PATCH v7 0/5] ARM: dts: imx6q: Add Engicam i.CoreM6 dts Jagan Teki
[not found] ` <1476437243-13297-1-git-send-email-jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>
2016-10-14 9:27 ` [PATCH v7 1/5] ARM: dts: imx6q: Add Engicam i.CoreM6 Quad/Dual initial support Jagan Teki
2016-10-14 9:27 ` [PATCH v7 2/5] ARM: dts: imx6q: Add Engicam i.CoreM6 DualLite/Solo " Jagan Teki
2016-10-14 9:27 ` [PATCH v7 5/5] ARM: dts: imx6qdl-icore: Add FEC support Jagan Teki
2016-10-21 1:31 ` Shawn Guo
2016-10-14 9:27 ` [PATCH v7 3/5] ARM: dts: imx6qdl-icore: Add usbhost support Jagan Teki
2016-10-21 1:21 ` Shawn Guo
2016-10-14 9:27 ` [PATCH v7 4/5] ARM: dts: imx6qdl-icore: Add usbotg support Jagan Teki
[not found] ` <1476437243-13297-5-git-send-email-jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>
2016-10-21 1:25 ` Shawn Guo
2016-10-18 12:00 ` [PATCH v7 0/5] ARM: dts: imx6q: Add Engicam i.CoreM6 dts Jagan Teki
2016-10-21 1:35 ` Shawn Guo
2016-10-21 7:55 ` Jagan Teki
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).